From: Christopher Baines <mail@cbaines.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 33185@debbugs.gnu.org
Subject: [bug#33185] [PATCH 7/7] services: Add patchwork.
Date: Tue, 20 Nov 2018 18:22:03 +0000 [thread overview]
Message-ID: <87d0qzsj78.fsf@cbaines.net> (raw)
In-Reply-To: <87d0r1xblc.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1942 bytes --]
Ludovic Courtès <ludo@gnu.org> writes:
> Hello,
>
> swedebugia <swedebugia@riseup.net> skribis:
>
>> On 2018-11-04 11:44, Christopher Baines wrote:
>>> ---
>>> gnu/services/web.scm | 297 ++++++++++++++++++++++++++++++++++++++++++-
>>> gnu/tests/web.scm | 104 ++++++++++++++-
>>> 2 files changed, 399 insertions(+), 2 deletions(-)
>>
>> Nice work with the service-declaration. :) (untested)
>
> +1!
>
>> Would you be willing to update the patch with documentation also?
>
> Yes, also with ‘documentation’ fields. :-)
>
> I spotted a typo here:
>
> +(define-record-type* <patchwork-configuration>
> + patchwork-configuration make-patchwork-configuration
> + patckwork-configuration?
> ^^
Good spot!
> Regarding ‘patchwork-setup-gexp’, I wonder if you could use
> ‘make-forkexec-constructor’ with the appropriate environment variables
> and move the “createuser” bit to an activation snippet.
>
> Hmm maybe the activation snippet would run too early, right? In that
> case, perhaps you could create another Shepherd service,
> ‘patchwork-initialization’, that would do the createuser stuff, and have
> ‘patchwork’ depend on it.
So, I've made some changes since I last sent this patch, the biggest
being splitting the database creation out from running of the database
migrations.
Assuming that the shepherd service defined as part of the
patchwork-service-type just runs the migrations, yes, it needs
PostgreSQL (or whatever database you're using) to be available.
At the moment, the service is hardcoded to use mod_wsgi, so it runs
through the httpd-service, no shepherd service for running patchwork is
needed in the service-type at least.
It would be good to try and make it more flexible in the future, at
least so that you can pick and choose a bit more (and instead use uwsgi,
gunicorn, ...).
Thanks for taking a look :)
Chris
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]
next prev parent reply other threads:[~2018-11-20 18:27 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-28 9:21 [bug#33185] [PATCH 0/7] Add patchwork package and service Christopher Baines
2018-10-28 9:26 ` [bug#33185] [PATCH 1/7] gnu: Add python-jsmin Christopher Baines
2018-10-28 9:26 ` [bug#33185] [PATCH 2/7] gnu: Add python-slimit Christopher Baines
2018-11-19 16:30 ` Ludovic Courtès
2018-11-20 19:58 ` Christopher Baines
2018-10-28 9:26 ` [bug#33185] [PATCH 3/7] gnu: Add python-django-pipeline Christopher Baines
2018-11-19 16:30 ` Ludovic Courtès
2018-10-28 9:26 ` [bug#33185] [PATCH 4/7] gnu: Add python-django-jinja Christopher Baines
2018-10-28 9:27 ` [bug#33185] [PATCH 5/7] gnu: Add python-django-debug-toolbar Christopher Baines
2018-10-28 9:27 ` [bug#33185] [PATCH 6/7] gnu: Add patchwork Christopher Baines
2018-10-28 9:27 ` [bug#33185] [PATCH 7/7] services: " Christopher Baines
2018-11-19 16:29 ` [bug#33185] [PATCH 1/7] gnu: Add python-jsmin Ludovic Courtès
2018-11-04 10:44 ` Christopher Baines
2018-11-04 10:44 ` [bug#33185] [PATCH 2/7] gnu: Add python-slimit Christopher Baines
2018-11-04 10:44 ` [bug#33185] [PATCH 3/7] gnu: Add python-django-pipeline Christopher Baines
2018-11-04 10:44 ` [bug#33185] [PATCH 4/7] gnu: Add python-django-jinja Christopher Baines
2018-11-19 16:33 ` Ludovic Courtès
2018-11-20 20:02 ` Christopher Baines
2018-11-04 10:44 ` [bug#33185] [PATCH 5/7] gnu: Add python-django-debug-toolbar Christopher Baines
2018-11-19 16:33 ` Ludovic Courtès
2018-11-20 20:03 ` Christopher Baines
2018-11-04 10:44 ` [bug#33185] [PATCH 6/7] gnu: Add patchwork Christopher Baines
2018-11-04 19:09 ` swedebugia
2019-01-22 22:36 ` Christopher Baines
2018-11-19 16:37 ` Ludovic Courtès
2019-01-22 22:31 ` Christopher Baines
2018-11-04 10:44 ` [bug#33185] [PATCH 7/7] services: " Christopher Baines
2018-11-04 19:10 ` swedebugia
2018-11-19 16:42 ` Ludovic Courtès
2018-11-20 18:22 ` Christopher Baines [this message]
2018-11-20 18:06 ` Christopher Baines
2019-01-22 22:09 ` [bug#33185] [PATCH v2 1/2] gnu: " Christopher Baines
2019-01-22 22:09 ` [bug#33185] [PATCH v2 2/2] services: " Christopher Baines
2019-01-22 22:40 ` Christopher Baines
2019-01-23 9:28 ` [bug#33185] [PATCH v2 1/2] gnu: " Ricardo Wurmus
2019-01-25 21:04 ` Christopher Baines
2019-01-25 21:00 ` [bug#33185] [PATCH v3 " Christopher Baines
2019-01-25 21:00 ` [bug#33185] [PATCH v3 2/2] services: " Christopher Baines
2019-05-03 19:16 ` [bug#33185] [PATCH 0/7] Add patchwork package and service Christopher Baines
2019-05-03 19:30 ` [bug#33185] [PATCH 1/3] services: Add getmail Christopher Baines
2019-05-03 19:30 ` [bug#33185] [PATCH 2/3] gnu: Add patchwork Christopher Baines
2019-05-03 19:30 ` [bug#33185] [PATCH 3/3] services: " Christopher Baines
2019-05-31 19:43 ` bug#33185: [PATCH 0/7] Add patchwork package and service Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0qzsj78.fsf@cbaines.net \
--to=mail@cbaines.net \
--cc=33185@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).