From: ludo@gnu.org (Ludovic Courtès)
To: Oleg Pykhalov <go.wigust@gmail.com>
Cc: 33448@debbugs.gnu.org
Subject: [bug#33448] [PATCH 2/3] describe: Add json format.
Date: Wed, 21 Nov 2018 22:33:32 +0100 [thread overview]
Message-ID: <87d0qyru8j.fsf@gnu.org> (raw)
In-Reply-To: <20181121141715.16417-2-go.wigust@gmail.com> (Oleg Pykhalov's message of "Wed, 21 Nov 2018 17:17:14 +0300")
Oleg Pykhalov <go.wigust@gmail.com> skribis:
> * guix/channels.scm (channel->json): New procedure.
> * guix/scripts/describe.scm (%options): Add 'json' option.
> (display-checkout-info, display-profile-info): Use 'channel->json'.
> * doc/guix.texi (Invoking guix describe): Document this.
[...]
> +(define channel->json
> + (match-lambda
> + (($ <channel> name url branch commit location)
> + (scm->json-string
> + (list
> + (cons 'name name)
> + (cons 'url url)
> + (cons 'commit commit))))))
Since this is not a core feature of channels and add a dependency on
(json), what about moving this procedure to (guix scripts describe)?
(‘channel->sexp’ could got to (guix scripts describe) as well maybe; no
big deal.)
Otherwise LGTM!
Ludo’.
next prev parent reply other threads:[~2018-11-21 21:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 22:26 [bug#33448] [PATCH] describe: Fix 'format' option Oleg Pykhalov
2018-11-21 7:00 ` [bug#33448] [PATCH] describe: Add json format Oleg Pykhalov
2018-11-21 10:53 ` Ludovic Courtès
2018-11-21 14:10 ` Oleg Pykhalov
2018-11-21 21:36 ` Ludovic Courtès
2018-11-21 10:47 ` [bug#33448] [PATCH] describe: Fix 'format' option Ludovic Courtès
2018-11-21 11:46 ` Oleg Pykhalov
2018-11-21 14:17 ` [bug#33448] [PATCH 1/3] describe: Use a procedure to format output Oleg Pykhalov
2018-11-21 14:17 ` [bug#33448] [PATCH 2/3] describe: Add json format Oleg Pykhalov
2018-11-21 21:33 ` Ludovic Courtès [this message]
2018-11-22 12:54 ` Oleg Pykhalov
2018-11-22 16:53 ` Ludovic Courtès
2018-11-22 18:23 ` Oleg Pykhalov
2018-11-21 14:17 ` [bug#33448] [PATCH 3/3] describe: Add recutils format Oleg Pykhalov
2018-11-21 21:34 ` Ludovic Courtès
2018-11-21 21:31 ` [bug#33448] [PATCH 1/3] describe: Use a procedure to format output Ludovic Courtès
2018-11-22 12:54 ` Oleg Pykhalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0qyru8j.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=33448@debbugs.gnu.org \
--cc=go.wigust@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).