From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:45162) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gwukL-0001RX-Ox for guix-patches@gnu.org; Thu, 21 Feb 2019 15:15:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gwukK-0005Jg-N4 for guix-patches@gnu.org; Thu, 21 Feb 2019 15:15:05 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:59117) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gwukK-0005J7-Fh for guix-patches@gnu.org; Thu, 21 Feb 2019 15:15:04 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gwukK-0002Pp-5F for guix-patches@gnu.org; Thu, 21 Feb 2019 15:15:04 -0500 Subject: [bug#34548] [PATCH 06/24] gnu: Add r-leaflet. Resent-Message-ID: References: <87a7isv3u9.fsf@posteo.net> <87pnroudwk.fsf@elephly.net> <87va1faatv.fsf@posteo.net> <5AB7CFA8-FD34-48D3-8392-9102042F3596@riseup.net> From: Brett Gilio In-reply-to: <5AB7CFA8-FD34-48D3-8392-9102042F3596@riseup.net> Date: Thu, 21 Feb 2019 14:14:18 -0600 Message-ID: <87d0nknbl1.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: swedebugia Cc: 34548@debbugs.gnu.org swedebugia writes: > Brett Gilio skrev: (19 februari 2019 19:32:12 CET) >> >>Ricardo Wurmus writes: >> >>> Hi Brett, >>> >>>> From 26fbdbeee9ec293511648dc321abb09b6989fadc Mon Sep 17 00:00:00 >>2001 >>>> From: Brett Gilio >>>> Date: Mon, 18 Feb 2019 19:37:02 -0600 >>>> Subject: [PATCH 06/24] gnu: Add r-leaflet. >>>> >>>> * gnu/packages/cran.scm (r-leaflet): New variable. >>> >>> Unfortunately, this one is not okay. It=E2=80=99s been on my list to a= dd >>> r-leaflet, but the package bundles minified JavaScript libraries. >>> >>> These sources of these libraries will need to be added as native >>inputs >>> to replace the bundled sources. We can minify them with the >>uglify-js >>> package. >> >>Understood. I will make a note to look that and see if I can revise the >>patch if that option seems formidable. However, on that note, do we >>have >>any progress on an npm importer? I know that came up awhile back. > > Julien is sitting on the patchset right now since a few weeks.=20 > > It still has some defects still but is mostly working. > > The problem of circular dependencies is still unsolved. I suggest we add = to our importer the ability to parse and select versions recursively. I tri= ed but failed to get it to work before I gave up. Hey, where is the patchset located? I wouldn't mind taking a look.