From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:34529) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h73iU-0004nY-KJ for guix-patches@gnu.org; Thu, 21 Mar 2019 15:51:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h73iS-0000rH-VF for guix-patches@gnu.org; Thu, 21 Mar 2019 15:51:06 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:40100) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h73iR-0000hy-5p for guix-patches@gnu.org; Thu, 21 Mar 2019 15:51:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h73iR-0007dP-3d for guix-patches@gnu.org; Thu, 21 Mar 2019 15:51:03 -0400 Subject: bug#34900: Add emacs-semantic-refactor Resent-To: guix-patches@gnu.org Resent-Message-ID: From: Marius Bakke In-Reply-To: References: Date: Thu, 21 Mar 2019 20:49:58 +0100 Message-ID: <87d0mk0zyx.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Jack Hill , 34900-done@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Jack Hill writes: > Hi Guix, > > The attached patch adds the emacs-semantic-refactor package. Thanks! > When reviewing this patch some particular things to look out for/question= s=20 > I have: > > 0) There are different sections in the (gnu packages emacs-xyz) module=20 > that are delineated by comments (e.g. Emacs Hacking, Web Browsing, and=20 > Miscellaneous). I've added the definition of emacs-semantic-refactor near= =20 > the end of the file in the Miscellaneous section. I wonder if this is=20 > correct or if it should go in the Emacs Hacking section. Paredit, which=20 > would be used in similar scenarios to semantic-refactor is in the Emacs=20 > Hacking section. I don't have a good answer, so I went with your initial approach. > 1) The upstream source contains a number of animated gif files=20 > demonstrating usage in the srefactor-demos directory. I do not see a buil= d=20 > process for these, and assume they were created by hand. Are we free to=20 > distribute these in Guix? As long as they are free to use and redistribute (i.e. not under a separate license), it should be okay for Guix. GIFs generally don't come with build instructions :-) > 2) semantic-refactor has an optional integration with projectile whose=20 > availability is checked for with (featurep 'projectile). I have not added= =20 > projectile as an input or propagated-input. Is this OK? Great! Optional dependencies are typically not propagated. > 3) I'm still new to writing package definitions, so extra scrutiny is=20 > warranted, particularly for the synopsis and description. I added a "This package provides a ..." prefix to the description to provide a little more context for the prospective reader. Pushed as ea4a1e5d0b13b5c548804ac854e6eb30c5149ce4, thank you! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlyT6uYACgkQoqBt8qM6 VPqX4gf/RkRSoLhUT7hSq5oz2k5+5H4o60lgvpo/uWosbjb8BeUKbKABtaBpsk1H 5smNIfZa+Wb2/qDFZBo8pXrFVbsoKzpOrrAET4lRtBIhdiY7TAkcYpfEPe3RjyYG iERvv8qGdBRPI2PlhKpftuU05t3kluj0dmQNZr+FakKiFHYxiz6BtP8XCw9WiXrx Wq5clmSwgiYB0OPkCpTdCU67iskZvFYrWFgw6Gwnf3p+JIq0Z6gYqNCIGsmfUZbf izcRKhypZrk6Cw2GeJ5FPkuw6OG450SuMb0xDDpbvD5ap8Lk7NS6UZULIxWgs3aW ULDce2PuHCfpk3kvvzPLhWhVGr5hNA== =eoox -----END PGP SIGNATURE----- --=-=-=--