From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:51553)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hIBv1-0008AT-9e
	for guix-patches@gnu.org; Sun, 21 Apr 2019 08:50:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hIBv0-0007kc-6s
	for guix-patches@gnu.org; Sun, 21 Apr 2019 08:50:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:34372)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1hIBv0-0007jk-3D
	for guix-patches@gnu.org; Sun, 21 Apr 2019 08:50:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hIBuz-000137-OM
	for guix-patches@gnu.org; Sun, 21 Apr 2019 08:50:01 -0400
Subject: [bug#35288] [PATCH 1/3] gnu: Add dumb.
Resent-Message-ID: <handler.35288.B35288.15558509874008@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20190415135134.31839-1-kkebreau@posteo.net>
	<87bm13qq1t.fsf@gnu.org> <87imv8jtv1.fsf@posteo.net>
Date: Sun, 21 Apr 2019 14:49:33 +0200
In-Reply-To: <87imv8jtv1.fsf@posteo.net> (Kei Kebreau's message of "Sat, 20
	Apr 2019 16:37:38 -0400")
Message-ID: <87d0lf8qw2.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Kei Kebreau <kkebreau@posteo.net>
Cc: 35288@debbugs.gnu.org

Hello Kei,

Kei Kebreau <kkebreau@posteo.net> skribis:

> Ludovic Court=C3=A8s <ludo@gnu.org> writes:
>
>> Hello,
>>
>> Kei Kebreau <kkebreau@posteo.net> skribis:
>>
>>> * gnu/packages/music.scm (dumb): New variable.
>>
>> [...]
>>
>>> +    (home-page "https://github.com/kode54/dumb")
>>> +    (synopsis "Module audio renderer library")
>>> +    (description
>>> + "DUMB is a tracker library with support for IT, XM, S3M and MOD
>>> files.  It
>>> +targets maximum accuracy to the original formats, with low-pass
>>> resonant filters
>>> +for the IT files, accurate timing and pitching, and three resampling q=
uality
>>> +settings (aliasing, linear interpolation and cubic interpolation).")
>>> +    (license (license:fsf-free "file://LICENSE"))))
>>
>> This looks good, but the license deserves close reading (which I haven=
=E2=80=99t
>> done).  What=E2=80=99s your interpretation of it?  It would be nice to p=
ut a
>> comment above to summarize our findings.
>>
>
> I've added the comment below in the patch summarizing my interpretation
> of the DUMB license:
>
> ;; The DUMB license is a bit peculiar.
> ;; Clause 8 states that clauses 4, 5 and 6 are null and void, leaving only
> ;; the first three clauses for genuine consideration.
> ;; Clauses 1, 2 and 3 are analogous to clauses 1, 2 and 3 of the zlib
> ;; license, a known free software license.
> ;; Therefore, the DUMB license may be considered a free software license.
>
> What do you think?

Sounds good!  (It=E2=80=99s available in Debian too, which is a good sign:
<https://packages.debian.org/sid/libdumb1>.)

>>> +(define-public vcvrack
>>> +  (package
>>> +    (name "vcvrack")
>>> +    (version "0.6.2b")
>>
>> What=E2=80=99s this doin=E2=80=99 here?  :-)
>>
>
> Very basic packaging work on some other software, whoops!

Heheh.  :-)

OK with these changes!

Thank you,
Ludo=E2=80=99.