unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Meiyo Peng <meiyo@riseup.net>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: stefanx2ovic@gmail.com, 36073 <36073@debbugs.gnu.org>
Subject: [bug#36073] [PATCH 2/5] gnu: sway: Update to 1.1.1.
Date: Mon, 10 Jun 2019 14:01:30 +0800	[thread overview]
Message-ID: <87d0jmnflx.fsf@riseup.net> (raw)
In-Reply-To: <87ftoi5ecu.fsf@nckx>

[-- Attachment #1: Type: text/plain, Size: 754 bytes --]

Hi Tobias,

Tobias Geerinckx-Rice writes:

> Meiyo Peng wrote:
>> The author states that swaybg is now a standalone program but it should
>> be treated as a required dependency of sway.  So we should add swaybg
>> into sway's propagated-inputs.
>
> I don't quite see the connection between these two sentences…  Why propagated?

"output" is a built-in command of sway.  Lack of swaybg breaks this
command:

#+begin_src conf
  output "*" background ~/Pictures/wallpaper.jpg fill
#+end_src

I somehow forgot the Guix way to solve this problem is to hardcode the
path to /gnu/store/*-swaybg-*/bin/swaybg.  Silly me.  And thank you for
your remind.

See the new attachment.  Thanks.


--
Meiyo Peng
https://www.pengmeiyu.com/


[-- Attachment #2: 0001-gnu-sway-Hardcode-path-to-swaybg.patch --]
[-- Type: text/x-patch, Size: 2016 bytes --]

From 92ea5e8bade96f6f9a19c76de35fa54bfd2ff84f Mon Sep 17 00:00:00 2001
From: Meiyo Peng <meiyo@riseup.net>
Date: Sun, 9 Jun 2019 16:15:50 +0800
Subject: [PATCH] gnu: sway: Hardcode path to swaybg.

* gnu/packages/wm.scm (sway)[arguments]: Hardcode path to swaybg.
  [inputs]: Add swaybg.
---
 gnu/packages/wm.scm | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index f0589e98f1..eac17e0837 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -17,7 +17,7 @@
 ;;; Copyright © 2017 Oleg Pykhalov <go.wigust@gmail.com>
 ;;; Copyright © 2018, 2019 Tobias Geerinckx-Rice <me@tobias.gr>
 ;;; Copyright © 2018 Pierre-Antoine Rouby <contact@parouby.fr>
-;;; Copyright © 2018 Meiyo Peng <meiyo.peng@gmail.com>
+;;; Copyright © 2018, 2019 Meiyo Peng <meiyo@riseup.net>
 ;;; Copyright © 2019 Rutger Helling <rhelling@mykolab.com>
 ;;; Copyright © 2019 Timothy Sample <samplet@ngyro.com>
 ;;;
@@ -1201,6 +1201,12 @@ modules for building a Wayland compositor.")
        (modify-phases %standard-phases
          (add-before 'configure 'hardcode-paths
            (lambda* (#:key inputs #:allow-other-keys)
+             ;; Hardcode path to swaybg.
+             (substitute* "sway/config.c"
+               (("strdup..swaybg..")
+                (string-append "strdup(\"" (assoc-ref inputs "swaybg")
+                               "/bin/swaybg\")")))
+             ;; Hardcode path to scdoc.
              (substitute* "meson.build"
                (("scdoc.get_pkgconfig_variable..scdoc..")
                 (string-append "'" (assoc-ref inputs "scdoc")
@@ -1214,6 +1220,7 @@ modules for building a Wayland compositor.")
               ("libinput" ,libinput)
               ("libxkbcommon" ,libxkbcommon)
               ("pango" ,pango)
+              ("swaybg" ,swaybg)
               ("wayland" ,wayland)
               ("wlroots" ,wlroots)))
     (native-inputs `(("git" ,git)
-- 
2.22.0


  reply	other threads:[~2019-06-10  6:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-03 16:58 [bug#36073] [PATCH 0/5] Update sway window manager and related utilities Stefan Stefanović
2019-06-03 17:01 ` [bug#36073] [PATCH 1/5] gnu: wlroots: Update to 0.6.0 Stefan Stefanović
2019-06-03 17:03 ` [bug#36073] [PATCH 2/5] gnu: sway: Update to 1.1.1 Stefan Stefanović
2019-06-10  2:17   ` Meiyo Peng
2019-06-10  3:05     ` Tobias Geerinckx-Rice
2019-06-10  6:01       ` Meiyo Peng [this message]
2019-06-14 12:10         ` Marius Bakke
2019-06-03 17:04 ` [bug#36073] [PATCH 3/5] gnu: swayidle: Update to 1.3 Stefan Stefanović
2019-06-10  2:22   ` Meiyo Peng
2019-06-15 12:52     ` Marius Bakke
2019-06-03 17:05 ` [bug#36073] [PATCH 4/5] gnu: swaylock: Update to 1.4 Stefan Stefanović
2019-06-03 17:07 ` [bug#36073] [PATCH 5/5] gnu: Add swaybg Stefan Stefanović
2019-06-07  7:51 ` bug#36073: [PATCH 0/5] Update sway window manager and related utilities Rutger Helling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d0jmnflx.fsf@riseup.net \
    --to=meiyo@riseup.net \
    --cc=36073@debbugs.gnu.org \
    --cc=me@tobias.gr \
    --cc=stefanx2ovic@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).