From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:47940)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1i81fH-0004V4-3W
 for guix-patches@gnu.org; Wed, 11 Sep 2019 08:24:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1i81fG-0003PY-6M
 for guix-patches@gnu.org; Wed, 11 Sep 2019 08:24:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:33288)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1i81fF-0003PK-Vy
 for guix-patches@gnu.org; Wed, 11 Sep 2019 08:24:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1i81fF-0003z8-OW
 for guix-patches@gnu.org; Wed, 11 Sep 2019 08:24:01 -0400
Subject: [bug#37364] [PATCH 1/1] gnu: Add z for zsh
Resent-Message-ID: <handler.37364.B37364.156820460615269@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <87woeg3mcy.fsf@rekahsoft.ca> <87v9u03m3m.fsf@rekahsoft.ca>
Date: Wed, 11 Sep 2019 14:23:17 +0200
In-Reply-To: <87v9u03m3m.fsf@rekahsoft.ca> (Collin J. Doering's message of
 "Mon, 09 Sep 2019 22:45:49 -0400")
Message-ID: <87d0g7vx6y.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: "Collin J. Doering" <collin@rekahsoft.ca>
Cc: 37364@debbugs.gnu.org

Hello Collin,

"Collin J. Doering" <collin@rekahsoft.ca> skribis:

> * gnu/packages/shellutils.scm (z): New variable.
>
> Signed-off-by: Collin J. Doering <collin@rekahsoft.ca>

[...]

> +(define-public z
> +  (package
> +    (name "z")

So far there=E2=80=99s only one package with a one-letter name.  I=E2=80=99=
d be tempted
to rename =E2=80=9Cz=E2=80=9D to =E2=80=9Csh-z=E2=80=9D (because it works w=
ith both Zsh and Bash) or
something similar, WDYT?

> +               (mkdir-p man-path)
> +               (invoke "gzip" "z.1")
> +               (copy-file "z.1.gz" (string-append man-path "/z.1.gz"))

You can omit the =E2=80=9Cgzip=E2=80=9D invocation because the =E2=80=98com=
press-documentation=E2=80=99
phase takes care of that, and passes the =E2=80=98-n=E2=80=99 flag, which i=
s important
for bitwise reproducibility.

Also, you can remove the =E2=80=98mkdir-p=E2=80=99 call and replace the =E2=
=80=98copy-file=E2=80=99 call
with:

  (install-file "z.1" man)

Last: please remove =E2=80=98-path=E2=80=99 from variable names=E2=80=94in =
GNU the convention is
touse the term =E2=80=9Cpath=E2=80=9D only for search paths ($PATH, etc.)

> +    (synopsis "Jump about directories")
> +    (description
> +     "Tracks your most used directories, based on freecency.  After a sh=
ort
> +learning phase, z will take you to the most frecent directory that match=
es
> +ALL of the regexes given on the command line in order.")

It=E2=80=99s suggest writing =E2=80=9C``frecency''=E2=80=9D (with quotes) t=
o make it clear that
it=E2=80=99s not a typo.  :-)

Could you send an updated patch?

Thanks,
Ludo=E2=80=99.