From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:38378)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iCoJE-0004Wm-7T
 for guix-patches@gnu.org; Tue, 24 Sep 2019 13:09:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iCoJD-0002jQ-4S
 for guix-patches@gnu.org; Tue, 24 Sep 2019 13:09:04 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:59457)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1iCoJC-0002ip-Kj
 for guix-patches@gnu.org; Tue, 24 Sep 2019 13:09:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iCoJC-0001LD-8W
 for guix-patches@gnu.org; Tue, 24 Sep 2019 13:09:02 -0400
Subject: [bug#37434] [PATCH 1/2] gnu: ghc-megaparsec: Update to 7.0.5.
Resent-Message-ID: <handler.37434.B37434.15693448955089@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20190917033730.28806-1-ericbavier@centurylink.net>
 <87ftkqpv2l.fsf@gnu.org> <87impmtxr9.fsf@ngyro.com>
 <878sqitxky.fsf@ngyro.com> <87muevl8qm.fsf@gnu.org>
 <1991034139.35893173.1569290364575.JavaMail.zimbra@centurylink.net>
 <87a7auqi3x.fsf@gnu.org>
 <1509023901.36105334.1569334019062.JavaMail.zimbra@centurylink.net>
Date: Tue, 24 Sep 2019 19:08:03 +0200
In-Reply-To: <1509023901.36105334.1569334019062.JavaMail.zimbra@centurylink.net>
 (Eric Bavier's message of "Tue, 24 Sep 2019 10:06:59 -0400 (EDT)")
Message-ID: <87d0fpoc5o.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Eric Bavier <ericbavier@centurylink.net>
Cc: 37434 <37434@debbugs.gnu.org>, bavier <bavier@member.fsf.org>

Hi Eric,

Eric Bavier <ericbavier@centurylink.net> skribis:

> From 832529b71c2c5c7e6aa6e88a206c0db65e8a0c2e Mon Sep 17 00:00:00 2001
> From: Eric Bavier <bavier@member.fsf.org>
> Date: Mon, 16 Sep 2019 22:20:23 -0500
> Subject: [PATCH] gnu: idris: Update to 1.3.2.
>
> * gnu/packages/idris.scm (ghc-network-2.8, ghc-megaparsec-7): New variabl=
es.
> (idris): Update to 1.3.2.
> [source]: Remove patch.
> [inputs]: Use ghc-network-2.8 and ghc-megaparsec-7.
> * gnu/packages/patches/idris-test-no-node.patch: Delete.
> * gnu/local.mk (dist_patch_DATA): Remove it.

[...]

> +++ b/gnu/packages/idris.scm
> @@ -30,15 +30,50 @@
>    #:use-module (gnu packages perl)
>    #:use-module (guix build-system gnu)
>    #:use-module (guix build-system haskell)
> +  #:use-module (guix utils)
>    #:use-module (guix download)
>    #:use-module (guix git-download)
>    #:use-module ((guix licenses) #:prefix license:)
>    #:use-module (guix packages))
>=20=20
> +;;; Until we update our default GHC to >=3D8.6 we cannot update our ghc-=
network
> +;;; package, since the 'cabal-install' package that supports the current
> +;;; 'Cabal' module requires 'network=3D=3D2.6.*'.  Providing a local ghc=
-network
> +;;; works in this case since we use it only for a standalone program.
> +(define ghc-network-2.8
> +  (package
> +    (inherit ghc-network)

You should only inherit from packages defined in the same module,
otherwise we risk hitting the dreaded circular dependency mess (actually
this particular case is fine because idris.scm is a =E2=80=9Cleaf=E2=80=9D,=
 but still,
let=E2=80=99s not take this risk.)

So I recommend moving these two ghc-* packages next to their friends.

With this change the patch LGTM.

Thanks,
Ludo=E2=80=99.