From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:43088) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iLXr1-0001gn-UR for guix-patches@gnu.org; Fri, 18 Oct 2019 15:24:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iLXr0-0002j1-ME for guix-patches@gnu.org; Fri, 18 Oct 2019 15:24:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42762) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iLXr0-0002ix-JA for guix-patches@gnu.org; Fri, 18 Oct 2019 15:24:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iLXr0-0007OL-E3 for guix-patches@gnu.org; Fri, 18 Oct 2019 15:24:02 -0400 Subject: [bug#37741] [PATCH 2/3] gnu: Add arm-trusted-firmware-rk3399. Resent-Message-ID: From: Vagrant Cascadian In-Reply-To: References: <20191014001407.28367-1-nomble@palism.com> <20191014060136.31144-1-nomble@palism.com> <877e56vep3.fsf@yucca> <00df76bd-4997-0906-5e51-884704b4b0b9@rock-chips.com> <87o8yfudp1.fsf@yucca> Date: Fri, 18 Oct 2019 12:22:54 -0700 Message-ID: <87d0etuacx.fsf@yucca> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Kever Yang , nomble@palism.com, 37741@debbugs.gnu.org Cc: Danny Milosavljevic --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2019-10-17, Kever Yang wrote: > On 2019/10/17 =E4=B8=8B=E5=8D=881:46, Vagrant Cascadian wrote: >> On 2019-10-15, Kever Yang wrote: >>> On 2019/10/15 =E4=B8=8B=E5=8D=8812:02, Vagrant Cascadian wrote: >>>> On 2019-10-14, nomble@palism.com wrote: >>>>> * gnu/packages/bootloaders.scm (arm-trusted-firmware-rk3399): New exp= orted >>>>> variable. >>>> Thanks for working on this! >>>> >>>> Unfortunately this currently embeds a binary blob >>>> (plat/rockchip/rk3399/drivers/dp/hdcp.bin) with no license. >>>> >>>> I reported the issue upstream: >>>> >>>> https://github.com/ARM-software/tf-issues/issues/651 >>> >>> I have send the patch to ATF to remove the hdpc.bin, you can comment on= it. >>> >>> https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/2194 >> On both Debian and Guix it fails to build with: >> >> plat/rockchip/rk3399/plat_sip_calls.c: In function >> =E2=80=98rockchip_plat_sip_handler=E2=80=99: >> plat/rockchip/rk3399/plat_sip_calls.c:59:15: error: unused variable =E2= =80=98x6=E2=80=99 >> [-Werror=3Dunused-variable] >> uint64_t x5, x6; ... > Sorry, I do catch this issue last week, but forgot to update it to the=20 > Gerrit. > > Already update to a new patch set now. Thanks! Was able to test on a rockpro64-rk3399 board, and it worked with u-boot. Pushed a slightly modified patch adding arm-trusted-firmware-rk3399 to guix/master in commit 074554a2891830900e2ff9335799416723094fcb. Will work on pushing the rest of the series as well; I've made some relatively minor changes locally... live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCXaoRDgAKCRDcUY/If5cW qlDAAP9raLKi7euR1kYjS/C0hJNTOuOmfUyReT5Yda5uxhMXWwEAoNMH85/uNrLK 8JhubYT2ifH5VDxxba9ZO9VZ4UqXJwU= =Na8Z -----END PGP SIGNATURE----- --=-=-=--