unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Vagrant Cascadian <vagrant@debian.org>
To: Kever Yang <kever.yang@rock-chips.com>,
	nomble@palism.com, 37741@debbugs.gnu.org
Cc: Danny Milosavljevic <dannym@scratchpost.org>
Subject: [bug#37741] [PATCH 2/3] gnu: Add arm-trusted-firmware-rk3399.
Date: Fri, 18 Oct 2019 12:22:54 -0700	[thread overview]
Message-ID: <87d0etuacx.fsf@yucca> (raw)
In-Reply-To: <aea8edd5-347c-db27-7a5a-b022979376f4@rock-chips.com>

[-- Attachment #1: Type: text/plain, Size: 1543 bytes --]

On 2019-10-17, Kever Yang wrote:
> On 2019/10/17 下午1:46, Vagrant Cascadian wrote:
>> On 2019-10-15, Kever Yang wrote:
>>> On 2019/10/15 下午12:02, Vagrant Cascadian wrote:
>>>> On 2019-10-14, nomble@palism.com wrote:
>>>>> * gnu/packages/bootloaders.scm (arm-trusted-firmware-rk3399): New exported
>>>>> variable.
>>>> Thanks for working on this!
>>>>
>>>> Unfortunately this currently embeds a binary blob
>>>> (plat/rockchip/rk3399/drivers/dp/hdcp.bin) with no license.
>>>>
>>>> I reported the issue upstream:
>>>>
>>>>     https://github.com/ARM-software/tf-issues/issues/651
>>>
>>> I have send the patch to ATF to remove the hdpc.bin, you can comment on it.
>>>
>>> https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/2194
>> On both Debian and Guix it fails to build with:
>>
>> plat/rockchip/rk3399/plat_sip_calls.c: In function
>> ‘rockchip_plat_sip_handler’:
>> plat/rockchip/rk3399/plat_sip_calls.c:59:15: error: unused variable ‘x6’
>> [-Werror=unused-variable]
>>    uint64_t x5, x6;
...
> Sorry, I do catch this issue last week, but forgot to update it to the 
> Gerrit.
>
> Already update to a new patch set now.

Thanks! Was able to test on a rockpro64-rk3399 board, and it worked with
u-boot.

Pushed a slightly modified patch adding arm-trusted-firmware-rk3399 to
guix/master in commit 074554a2891830900e2ff9335799416723094fcb.

Will work on pushing the rest of the series as well; I've made some
relatively minor changes locally...


live well,
  vagrant

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

  reply	other threads:[~2019-10-18 19:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-14  0:14 [bug#37741] [PATCH 0/3] Update u-boot to 2019.10 and add u-boot-rockpro64-rk3399 nomble
2019-10-14  6:01 ` [bug#37741] [PATCH 1/3] gnu: u-boot: Update to 2019.10 nomble
2019-10-15  4:07   ` Vagrant Cascadian
2019-10-14  6:01 ` [bug#37741] [PATCH 2/3] gnu: Add arm-trusted-firmware-rk3399 nomble
2019-10-15  4:02   ` Vagrant Cascadian
2019-10-15  6:38     ` Kever Yang
2019-10-17  5:46       ` Vagrant Cascadian
2019-10-17  6:43         ` Kever Yang
2019-10-18 19:22           ` Vagrant Cascadian [this message]
2019-10-14  6:01 ` [bug#37741] [PATCH 3/3] gnu: Add u-boot-rockpro64-rk3399 nomble
2019-10-18 20:44 ` bug#37741: [PATCH 0/3] Update u-boot to 2019.10 and add u-boot-rockpro64-rk3399 Vagrant Cascadian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d0etuacx.fsf@yucca \
    --to=vagrant@debian.org \
    --cc=37741@debbugs.gnu.org \
    --cc=dannym@scratchpost.org \
    --cc=kever.yang@rock-chips.com \
    --cc=nomble@palism.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).