From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:55994) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iPEC7-0005YZ-OP for guix-patches@gnu.org; Mon, 28 Oct 2019 19:13:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iPEC6-0005uJ-F7 for guix-patches@gnu.org; Mon, 28 Oct 2019 19:13:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:37745) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iPEC6-0005uF-BI for guix-patches@gnu.org; Mon, 28 Oct 2019 19:13:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iPEC6-0004Sg-4n for guix-patches@gnu.org; Mon, 28 Oct 2019 19:13:02 -0400 Subject: [bug#37717] [PATCH 0/3] gnu: Add kmonad. Resent-Message-ID: From: Marius Bakke In-Reply-To: <4ba7596b-5f84-f3ab-e15a-7a99011ad4c1@ajgrf.com> References: <4551b258-a4e3-49f8-9c22-5840edbbd3a7@www.fastmail.com> <87lfthyjpj.fsf@devup.no> <4ba7596b-5f84-f3ab-e15a-7a99011ad4c1@ajgrf.com> Date: Tue, 29 Oct 2019 00:11:53 +0100 Message-ID: <87d0egtqh2.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Alex Griffin , 37717@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Alex Griffin writes: > On 10/18/19 1:47 PM, Marius Bakke wrote: >> I sent some feedback on the individual patches. Can you create an >> account on Savannah if you haven't already? Then you can push the next >> version yourself. :-) >>=20 >> Please also send a reply to this message signed by the same GPG key that >> you will use to sign commits, and make sure to upload it to Savannah. > > Thanks! I've attached updated patches with the suggested changes, > created a Savannah account, and this email should be signed with my GPG k= ey. Great! I have added you to the Savannah project now. \o/ Make sure to read HACKING, and enjoy your new commit superpowers. :-) > Kmonad 0.3 was released last week, but I don't think it can be updated > in Guix until we move to a newer Stackage. Right. Rumor has it that a new Stackage LTS 14 branch is coming up, perhaps you can be an early tester? ;-) >> Should this not be provided by 'ghc-primitive'? Perhaps it is >> expecting a different version? > > From what I can gather, there were a few commits upstream to add support > for primitive 0.7 without breaking 0.6, but they forgot to make the same > change in the test suite. > > https://github.com/jberryman/unagi-chan/commit/b4af3f2b0d76de701ec8ca4a17= ab88f776fe80a9 OK. Can you adjust the comment to mention that a newer ghc-primitive is required? Otherwise LGTM. Thanks, and welcome! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl23dbkACgkQoqBt8qM6 VPrCogf8CSRzPXXWUPBi3UhYo1HtBh0zVCSRXBHRTcyOi67GhPgW+DTC1cvrn7oh /yICJZwOnCQ365owXGXvjLezQYvkLNPg/6UH+VnX3/BI0IJqqmuYP9RCGRdJJTAo 9Dq0BT/hu8O9LCxYFGErWROuUJyyw7TIGEIc10UUyGfm2HTV+ZiJuY/PweptsNnC bN+ueNZACaQKsUPPCpjRZJglKojz7uAWsIFOzKhKCyeYxZJCwprTSm1r6KIfWbvV Pqp6K0QQlPY34bk2f2HhIMcAPD7cWDxQm3Cf1FskQRMx1GLAuEsb8fVn9KFDmO8X K7CbM1DDUZ7pgWt7wp/+MG9tihEBhg== =oStX -----END PGP SIGNATURE----- --=-=-=--