From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:33240) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iTv6t-0008KT-S6 for guix-patches@gnu.org; Sun, 10 Nov 2019 16:51:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iTv6s-0004yP-In for guix-patches@gnu.org; Sun, 10 Nov 2019 16:51:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:43937) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iTv6s-0004yD-CN for guix-patches@gnu.org; Sun, 10 Nov 2019 16:51:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iTv6s-0006mq-9q for guix-patches@gnu.org; Sun, 10 Nov 2019 16:51:02 -0500 Subject: bug#38128: [PATCH] gnu: Add boost-with-python3 Resent-To: guix-patches@gnu.org Resent-Message-ID: From: Marius Bakke In-Reply-To: <2894916c81c703293e028556070cd964@autistici.org> References: <2894916c81c703293e028556070cd964@autistici.org> Date: Sun, 10 Nov 2019 22:50:18 +0100 Message-ID: <87d0dzl7tx.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: goodoldpaul@autistici.org, 38128-done@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Giacomo, goodoldpaul@autistici.org writes: > Hello Guixers! > > Given the recent discussion about dropping python 2 completely I thought= =20 > it's time to build our libboost against python 3. I didn't have the time= =20 > to check if every boost dependency (there are a lot ;) ) supported=20 > python 3, so I added a new variable "boost-with-python3". I'm not sure=20 > if I should have made it hidden or if I should have update directly=20 > boost definition so any feedback is welcome. Thank you for this patch! Have you tried building anything with this new Boost yet? Boost has 4623 dependent packages according to 'guix refresh -l boost', so we can not change the package definition on the master branch. Such changes has to go through the 'core-updates' branch. Adding a separate variable was the right choice. It would be great if you could work on a follow-up patch for 'core-updates' that merges this variant with the regular 'Boost'. I left that as a TODO comment. :-) > From 6eef72ea2bc904ff1371fbbe1211a3890625d99c Mon Sep 17 00:00:00 2001 > From: Giacomo Leidi > Date: Fri, 8 Nov 2019 11:52:42 +0100 > Subject: [PATCH] gnu: Add boost-with-python3. > > * gnu/packages/boost.scm (boost-with-python3): New variable. [...] =20=20 > +(define-public boost-with-python3 > + (package > + (inherit boost) > + (source (origin > + (inherit (package-source boost)))) I removed this part, as the source is already inherited. I also gave it a different name (boost-python3) to avoid a naming conflict on the CLI. [...] > + (replace 'provide-libboost_python > + (lambda* (#:key outputs #:allow-other-keys) > + (let ((out (assoc-ref outputs "out"))) > + (with-directory-excursion (string-append out = "/lib") > + ;; Boost can build support for both Python = 2 and Python 3 since > + ;; version 1.67.0, and suffixes each librar= y with the Python > + ;; version. Many consumers only check for = libboost_python > + ;; however, so we provide it here as sugges= ted in > + ;; . ...and dropped this comment, since it is already explained in the regular Boost package. Applied, thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl3IhhoACgkQoqBt8qM6 VPoRdwf/YhNbR0ERUqOqQblIu+XEP4uyi8QaHesJ/miQamF3ME5Lk8SsN8I5IUOh WneRyKivoyc6NxrqgJx7xFRN2Zd/fi51vDpBlBu7WrDXHXII0pNXaD7hxUU5RBB9 sFkTgei5qX1+PVlUpgXr6AnRH7BWIb0UhMTrvlLOLEZWVPDW9Q7ZSvh6mjYACpv0 6QXGSjQvoVZ4Snb0Tf1oQMCibnpeoUP7zl7wddXHgER6zkugmYOluEvyWf9y5ynK UeQC3p8U3/Uxg4LOniHr/x3tw9gkTr5bTvq8vCrfPfoDLs9pSVkTeDK8uGobMZEN Uf7FqNpBexdYoMyYFiG9l5m62leaLA== =393b -----END PGP SIGNATURE----- --=-=-=--