From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:56614) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1idOtA-0000lY-5A for guix-patches@gnu.org; Fri, 06 Dec 2019 20:28:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1idOt8-0005L3-RQ for guix-patches@gnu.org; Fri, 06 Dec 2019 20:28:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:41235) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1idOt8-0005I0-D7 for guix-patches@gnu.org; Fri, 06 Dec 2019 20:28:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1idOt8-0007JL-6s for guix-patches@gnu.org; Fri, 06 Dec 2019 20:28:02 -0500 Subject: [bug#38509] [PATCH] gnu: libuv: Update to 1.34.0 Resent-Message-ID: From: Brett Gilio References: <20191206085713.27096-1-andrew@interpretmath.pw> Date: Fri, 06 Dec 2019 19:27:43 -0600 In-Reply-To: <20191206085713.27096-1-andrew@interpretmath.pw> (Andrew Miloradovsky's message of "Fri, 6 Dec 2019 11:57:13 +0300") Message-ID: <87d0d0org0.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Andrew Miloradovsky Cc: 38509@debbugs.gnu.org Andrew Miloradovsky writes: > - (arguments > - '(;; XXX: Some tests want /dev/tty, attempt to make connections, etc. > - #:tests? #f)) > + (arguments '(#:tests? #f)) > + ;; tests 122-124 (getnameinfo_basic_ip*) fail > + ;; https://github.com/libuv/libuv/issues/2531 Hi Andrew, Thank you for your submission. I have some questions before we go forward with this patch. First, I'd like to note that this change would trigger a huge rebuild of thousands of dependent packages. --8<---------------cut here---------------start------------->8--- brettg@oryx ~/Repos/guix$ ./pre-inst-env guix refresh -l libuv Building the following 2067 packages would ensure 5397 dependent packages are rebuilt: --8<---------------cut here---------------end--------------->8--- That said, is there some particular functionality or security that is provided with this patch? If so, it would be great if you could elaborate on that in the Git sub-header of the commit message. Since this patch would trigger such a massive rebuild it will need to go to the `core-updates` branch to rest before it sees master. So having that detail in the commit message will make it easier for us to see what we are working with. Lastly, just curious if there is a way to work around the issues with tests 122-124 as shown in your above snippet. I know that the tests were blanket disabled before, so I am just curious if there is a _better_ way to do this, maybe i'm wrong. If the issue is that the tests require network functionality that can usually be spoofed with some effort. Also, stylistically, comments not on the same line as the code they are commenting usually go before the code in question. I hope that makes sense! Let me know if you have any questions, I am happy to help. -- Brett M. Gilio https://git.sr.ht/~brettgilio/