From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:50459) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iluzk-0002YX-3U for guix-patches@gnu.org; Mon, 30 Dec 2019 08:22:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iluzi-0008Aw-Pz for guix-patches@gnu.org; Mon, 30 Dec 2019 08:22:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:54603) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iluzi-0008Aq-Mo for guix-patches@gnu.org; Mon, 30 Dec 2019 08:22:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iluzi-00069O-Hr for guix-patches@gnu.org; Mon, 30 Dec 2019 08:22:02 -0500 Subject: [bug#38811] gnu: Add gnome-menus. Resent-Message-ID: From: Jan Nieuwenhuizen References: <4e1c706ce6c604d95f5a6e34fab3a819@disroot.org> Date: Mon, 30 Dec 2019 14:21:09 +0100 In-Reply-To: (Raghav Gururajan's message of "Mon, 30 Dec 2019 12:55:05 +0000") Message-ID: <87d0c6hrui.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Raghav Gururajan Cc: 38811@debbugs.gnu.org Raghav Gururajan writes: Hello Raghav, I was about to commit your patch with changes and then decided there are a bit too many small things to fix. In essence your package is fine, just a a number of cleanups are needed. Comments in-line below. Have you tried to running the package; I do not use GNOME? > From db24eb52caec6097b95d1604adcfeb8a29c72488 Mon Sep 17 00:00:00 2001 > From: Raghav Gururajan > Date: Mon, 30 Dec 2019 07:47:30 -0500 > Subject: [PATCH] gnu: Add gnome-menus. > > * gnu/packages/gnome.scm (gnome-menus). New Variable. Use lower case on variable: New variable. > --- > gnu/packages/gnome.scm | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm > index e0712bf99a..607a546768 100644 > --- a/gnu/packages/gnome.scm > +++ b/gnu/packages/gnome.scm > @@ -3848,6 +3848,27 @@ It is a basic GtkUIManager replacement based on GA= ction. It is suitable for > both a traditional UI or a modern UI with a GtkHeaderBar.") > (license license:lgpl2.1+))) >=20=20 > +(define-public gnome-menus > + (package > + (name "gnome-menus") > + (version "3.32.0") > + (source (origin > + (method url-fetch) ^ Use spaces instead of TABs. > + (uri (string-append "mirror://gnome/sources/gnome-menus/" > + (version-major+minor version) "/gnome-menus-" version ".tar.xz")) Use spaces instead of TABs, add line break to stay within 80 columns. > + (sha256 > + (base32=20 ^ Remove trailing whitespace. > + "0x2blzqrapmbsbfzxjcdcpa3vkw9hq5k96h9kvjmy9kl415wcl68")))) > + (build-system gnu-build-system) > + (native-inputs > + `(("gettext" ,gettext-minimal) > + ("glib" ,glib) > + ("pkg-config" ,pkg-config))) > + (synopsis "GNOME Menus") This is too non-descriptive, use something like "GNOME implementation of the freedesktop menu specification" > + (description "It contains the libgnome-menu library, the layout conf= iguration files for the GNOME menu, as well as a simple menu editor. The li= bgnome-menu library implements the 'Desktop Menu Specification' from freede= sktop.org.") Instead of "It", start with GNOME Menus contains ... add line breaks to stay within 80 columns, use two spaces after each senten= ce. > + (home-page "https://gitlab.gnome.org/GNOME/gnome-menus") > + (license license:gpl2+))) It looks like the package is licensed partly under gpl2 and lgpl2 (not gpl2+). Can you please double check? > + > (define-public devhelp > (package > (name "devhelp") Can you please send and updated patch? Most of the corrections are reported by guix lint, before you send it please run ./pre-inst-env guix lint gnome-menus and make sure there are no errors reported. Thanks for your contribution! Greetings, janneke --=20 Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.com