From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:39253) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4pQh-0000Si-34 for guix-patches@gnu.org; Thu, 20 Feb 2020 12:16:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j4pQg-00077v-5d for guix-patches@gnu.org; Thu, 20 Feb 2020 12:16:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:39827) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j4pQg-00077r-2R for guix-patches@gnu.org; Thu, 20 Feb 2020 12:16:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j4pQf-0007ep-UO for guix-patches@gnu.org; Thu, 20 Feb 2020 12:16:01 -0500 Subject: [bug#39698] [PATCH] file-systems: Set default value of the check? field to #f for NFS Resent-Message-ID: Received: from eggs.gnu.org ([2001:470:142:3::10]:39175) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4pQD-0000PX-UD for guix-patches@gnu.org; Thu, 20 Feb 2020 12:15:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j4pQC-0006it-Vz for guix-patches@gnu.org; Thu, 20 Feb 2020 12:15:33 -0500 Received: from mail-qk1-x743.google.com ([2607:f8b0:4864:20::743]:44706) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j4pQC-0006hE-Q0 for guix-patches@gnu.org; Thu, 20 Feb 2020 12:15:32 -0500 Received: by mail-qk1-x743.google.com with SMTP id j8so4238309qka.11 for ; Thu, 20 Feb 2020 09:15:32 -0800 (PST) Received: from raisin ([2607:fad8:4:6:235e:8579:8464:aacc]) by smtp.gmail.com with ESMTPSA id y62sm108394qka.19.2020.02.20.09.15.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Feb 2020 09:15:31 -0800 (PST) From: Maxim Cournoyer Date: Thu, 20 Feb 2020 12:15:30 -0500 Message-ID: <87d0a9i3il.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 39698@debbugs.gnu.org --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain The attached patch makes the default value of the record check? filed smarter, and avoids boot failures when using an NFS system and omitting to specify "check? #f". There are no checkers for NFS and none are required. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-file-systems-Set-default-value-of-the-check-field-to.patch Content-Transfer-Encoding: quoted-printable From=20d6b5a47036b21ec4bf4109cd781ed76208713b71 Mon Sep 17 00:00:00 2001 From: Maxim Cournoyer Date: Thu, 20 Feb 2020 11:51:37 -0500 Subject: [PATCH] file-systems: Set default value of the check? field to #f = for NFS. Network file systems do not need to be checked locally, so provide a better default value. * gnu/system/file-systems.scm (): Make the check? field thunke= d, and compute the default value based on its own type. =2D-- gnu/system/file-systems.scm | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/gnu/system/file-systems.scm b/gnu/system/file-systems.scm index 7b78731524..03b143fcac 100644 =2D-- a/gnu/system/file-systems.scm +++ b/gnu/system/file-systems.scm @@ -101,6 +101,8 @@ (define-record-type* %file-system make-file-system file-system? + this-file-system + (device file-system-device) ; string | | (mount-point file-system-mount-point) ; string (type file-system-type) ; string @@ -113,7 +115,10 @@ (needed-for-boot? %file-system-needed-for-boot? ; Boolean (default #f)) (check? file-system-check? ; Boolean =2D (default #t)) + (thunked) + (default (not (string-prefix-ci? + (file-system-type this-file-system) + "nfs")))) (create-mount-point? file-system-create-mount-point? ; Boolean (default #f)) (dependencies file-system-dependencies ; list of =2D-=20 2.25.0 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEJ9WGpPiQCFQyn/CfEmDkZILmNWIFAl5OvrIACgkQEmDkZILm NWJ9fBAAj+BIFeU+DYvglksrHnlT5znoramfzzBkTSVlCGKVhW9rTv3MjY+d597o s4U0YdJVYxsCE/eo36e4goKWp8aM4HSVtU65LlCdN69YaqOMMWF/0Nf1vkvfuadT kZOHBQvWH66Q/DaNwVAjg2AM7EBaZCyd6dFSzhcFct7Zk9aYCsh3cNwb2Skh6Fmw 4bvAtuXXaywl5Ap6R4QnyexvsKNrDmy7i/y6TRlmuZ2S2cY/eO3yu7KZshOj5nzG YFPMh2cD3NyIQYLHQPEe11s44MWvo1/b0ZtVI7NWd1wuc8m8xMx0CvywWmoH9Foy gDJeBF9U0l2rarahdl7ToXV9Nlsgzaw6UPH6SaprRpvAo3y1Tf9B/lVvw4eT1Gkq 5felyijOBV35PtuGsghhhC3eiW121cdW/jpB7LepL8emoBlK2waJBAS05HGBpSiS 4qLhT43s4f0tRQDGbcwQ2L9wiaiB551YvSwEluRSuFXebTOd8A3NGMaB7vikS9Js ufszb3kat1M/bcDAGxVhlfQ9mGjCszhxl3dj16fDK9Uy3pL90geJItnzlM9L7UBN E6YSVow1y0JyOpUFiGosAHwFpquzVDmx9bT5eNidAlBog0AAfKBOewpCn6RV/F0C qPX729JKEn8Yf1QDvbetb1gB9X8x4x9NtYhsDLNX605JCIHKp0s= =lOTZ -----END PGP SIGNATURE----- --==-=-=--