From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:45057)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jIuBz-0004Pe-Cj
 for guix-patches@gnu.org; Mon, 30 Mar 2020 09:11:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jIuBy-0007Ae-8i
 for guix-patches@gnu.org; Mon, 30 Mar 2020 09:11:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:49596)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jIuBy-0007AL-5L
 for guix-patches@gnu.org; Mon, 30 Mar 2020 09:11:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jIuBy-00012R-0U
 for guix-patches@gnu.org; Mon, 30 Mar 2020 09:11:02 -0400
Subject: [bug#40258] [PATCH] gnu: Add emacs-flycheck-elm.
Resent-Message-ID: <handler.40258.B40258.15855738193930@debbugs.gnu.org>
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
References: <87tv29iieh.fsf@asu.edu> <87pncw43rc.fsf@asu.edu>
Date: Mon, 30 Mar 2020 15:10:06 +0200
In-Reply-To: <87pncw43rc.fsf@asu.edu> (John Soo's message of "Sat, 28 Mar 2020
 13:35:03 -0700")
Message-ID: <87d08u7zv5.fsf@nicolasgoaziou.fr>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: John Soo <jsoo1@asu.edu>
Cc: 40258@debbugs.gnu.org

Hello,

John Soo <jsoo1@asu.edu> writes:

> Subject: [PATCH] gnu: Add emacs-flycheck-elm.
>
> * gnu/packages/emacs-xyz.scm (emacs-flycheck-elm): New variable.

Thank you.

> +;;; Copyright =C2=A9 2020 John Soo <jsoo1@asu.edu>

You can remove this line, already applied in a previous patch.


> +(define-public emacs-flycheck-elm
> +  (package
> +    (name "emacs-flycheck-elm")
> +    (version "debd0af")

This is not a proper version string (not monotonic). You should bind
`commit' to "debd0af563cb6c2944367a691c7fa3021d9378c1" and `revision' to
"O" at the top of your package definition, and use

  (version (git-version "0" revision commit))

> +         (commit version)))

In the case above, this should be:

  (commit commit)

> +    (inputs
> +     `(("emacs-flycheck" ,emacs-flycheck)
> +       ("emacs-let-alist" ,emacs-let-alist)
> +       ("emacs-seq" ,emacs-seq)))

I don't think you need "emacs-seq" since we build packages with Emacs
26.3, which includes "seq.el" already.

> +    (build-system emacs-build-system)
> +    (home-page "https://github.com/bsermons/flycheck-elm")
> +    (synopsis "Flycheck support for the elm language")
> +    (description "Flycheck support for the elm language.")

Nitpick: I would use Elm.

The description needs to be a full sentence.

> +    (license license:gpl2+)))

All source code files are GPL3+, so this probably makes the project
GPL3+ licensed. LICENSE file is GPL2 (not 2+), but I would trust source
code in this case.

You may want to tell upstream about this discrepancy.

Could you send an updated patch?

Regards,

--=20
Nicolas Goaziou