From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:54976) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jPiZ5-0006DL-2w for guix-patches@gnu.org; Sat, 18 Apr 2020 04:11:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jPiZ3-0008Pt-Pa for guix-patches@gnu.org; Sat, 18 Apr 2020 04:11:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58657) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jPiZ3-0008PI-Ma for guix-patches@gnu.org; Sat, 18 Apr 2020 04:11:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jPiZ3-0001IA-I9 for guix-patches@gnu.org; Sat, 18 Apr 2020 04:11:01 -0400 Subject: [bug#40684] [PATCH core-updates] guix: self: Use guile with libgc-7. Resent-Message-ID: References: <20200417172142.23741-1-mail@cbaines.net> <87mu79akqw.fsf@gnu.org> From: Christopher Baines In-reply-to: <87mu79akqw.fsf@gnu.org> Date: Sat, 18 Apr 2020 09:10:11 +0100 Message-ID: <87d0855i58.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 40684@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Hi! > > Christopher Baines skribis: > >> Rather than libgc version 8. This should avoid crashes that can occur, >> particularly when loading data in to the Guix Data Service [1]. >> >> 1: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D40525 >> >> * gnu/packages/guile.scm (guile-3.0/libgc-7): New variable. >> * guix/self.scm (specification->package): Use guile-3.0/libgc-7 for guil= e. >> --- >> gnu/packages/guile.scm | 12 ++++++++++++ >> guix/self.scm | 2 +- >> 2 files changed, 13 insertions(+), 1 deletion(-) >> >> diff --git a/gnu/packages/guile.scm b/gnu/packages/guile.scm >> index 8ccbc22f26..6b7bd492ed 100644 >> --- a/gnu/packages/guile.scm >> +++ b/gnu/packages/guile.scm >> @@ -309,6 +309,18 @@ without requiring the source code to be rewritten.") >> >> (define-public guile-next guile-3.0) >> >> +(define-public guile-3.0/libgc-7 >> + (hidden-package >> + (package >> + (inherit guile-3.0) >> + (propagated-inputs >> + (map (lambda (input) >> + (if (string=3D? (car input) >> + "bdw-gc") >> + (list "bdw-gc" libgc-7) >> + input)) > > Nitpicking: please write it as: > > `(("bdw-gc" ,libgc-7) > ,@(alist-delete "bdw-gc" (package-propagated-inputs guile-3.0))) > > as we do elsewhere. > > Also, could you add a comment referencing the bug report, so we > immediately see why this variant exists? > > OK with these changes, thanks! Sure, I've sent an updated patch now. Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl6ateNfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XdVeg//XEhkCy8YRugHxQgnHr1n+ArW4ivW+USZRyMvVVY+253eVHmblaXYQ+yK V1yqybidYPPhlqQMODDYVUE/67spv6Rs5pqHR9yt6okefiSlTv9rpBLqjDPseKqk PeAidog7ykufeXMeRcCwfAf7nGpepuSlnXYCHp2IU8ZQkWo7M4cPD4isuK07bF6X 7/ddeAZYLiIp2FVthl8u84+ed1dtFaiiWtUUoZN2Yyk+3OYGlDWaUBa9qH/CXRnH SB8L5GVtBBoRtdGGA5UAjMsqKSSx4ogB+8OdFNwr9eBufZQdsKUN5xun0iTXgzSS 1/mbs+txM8P8TMJnNFCeGJwA1iLxdVaKYJh90vpwQlv9ufiaU3ERsYH56BEgDhPn 7BDoucLwhXHYMN/FvBwI6t+fFM1KA9JnkAUp+PTg19c3w35PH2FjwwprYfZuxmNo /GhqL+rvGv5VxeTWut5dlMpTwvwWgQSX9Or7AXJhe3vXLVjzOj/2GhN95+XdIcAJ oLFAl/x68xVS4APUTE/XB8cTtUtZwAgx7DH5Dmt3BLM6ZTzN3S7emRnO/Pq6eyEw S3Cz1bJVdkjXCR132qOStwlSr71NCWv8L1LbKHYCPLGn0RPiimGK3R1UXALNvfzG fYWwkXWH+vlKfj+XB3dZgdf0RLoruOdAco556AsJ2Etbj0ipbbY= =pSHl -----END PGP SIGNATURE----- --=-=-=--