From: Edouard Klein <edou@rdklein.fr>
To: 41455@debbugs.gnu.org
Subject: [bug#41455] [PATCH 2/2] gnu: Add python-daemux
Date: Tue, 26 May 2020 10:57:45 +0200 [thread overview]
Message-ID: <87d06rysxi.fsf@alice.lan> (raw)
In-Reply-To: <87mu5v63b1.fsf@gnu.org>
Marius Bakke writes:
> Edouard Klein <edk@beaver-labs.com> writes:
>
>> * gnu/packages/tmux.scm (python-daemux): New variable.
>
> [...]
>
>> +(define-public python-daemux
>> + (package
>> + (name "python-daemux")
>> + (version "0.1.0")
>> + (source
>> + ;; We fetch from the Git repo because there are no tests in the PyPI
>> + ;; archive.
>> + (origin
>> + (method git-fetch)
>> + (uri (git-reference
>> + (url "https://github.com/edouardklein/daemux.git")
>> + (commit "58e30331d3cce08655cb5f55e94396568d484f9a")))
>
> This upstream looks familiar... Do you think upstream is willing to tag
> a 0.1.0 release instead of using a "magic" commit identifier? :-)
>
Of course :)
>> + (file-name (git-file-name name version))
>> + (sha256
>> + (base32 "0cb8v552f2hkwz6d3hwsmrz3gd28jikga3lcc3r1zlw8ra7804ph"))))
>> + (build-system python-build-system)
>> + (arguments
>> + `(#:phases (modify-phases %standard-phases
>> + (replace 'check
>> + (lambda _
>> + (mkdir-p "tmptmux")
>> + (setenv "TMUX_TMPDIR" (string-append (getcwd) "/tmptmux"))
>> + (invoke "tmux" "new-session" "-d")
>> + (invoke "make" "test"))))))
>
> Nice! I guess 'tmux' needs to be a native-input if we don't propagate
> it from libtmux.
>
I'm not sure what you mean. tmux is indeed a propagated input of
python-libtmux, which is in turn a propagated input of python-daemux. Do
you mean that it should be added explicitly here instead of being
implicit ?
>> + (propagated-inputs
>> + `(("python-libtmux" ,python-libtmux)))
>> + (native-inputs
>> + `(("python-coverage" ,python-coverage)
>> + ("python-sphinx" ,python-sphinx)))
>> + (home-page "https://github.com/edouardklein/daemux")
>> + (synopsis
>> + "Start, stop, restart and check daemons via tmux")
>
> This line break is unnecessary.
>
> Otherwise LGTM, thanks!
Cool ! Thank you for reviewing.
next prev parent reply other threads:[~2020-05-26 13:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 13:10 [bug#41455] [PATCH] gnu: Add python-daemux Edouard Klein
2020-05-23 18:45 ` Marius Bakke
2020-05-25 9:31 ` Edouard Klein
2020-05-25 9:32 ` [bug#41455] [PATCH 1/2] gnu: Add python-libtmux Edouard Klein
2020-05-25 22:43 ` Marius Bakke
2020-05-25 9:33 ` [bug#41455] [PATCH 2/2] gnu: Add python-daemux Edouard Klein
2020-05-25 22:46 ` Marius Bakke
2020-05-26 8:57 ` Edouard Klein [this message]
2020-05-30 12:04 ` Marius Bakke
2020-05-26 8:23 ` [bug#41455] [PATCH 1/2] gnu: Add python-pytest-4 Edouard Klein
2020-05-30 12:07 ` Marius Bakke
2020-05-26 8:24 ` [bug#41455] [PATCH 2/2] gnu: Add python-libtmux Edouard Klein
2020-05-30 12:17 ` Marius Bakke
2020-05-26 8:58 ` [bug#41455] [PATCH] gnu: Add python-daemux Edouard Klein
2020-05-30 12:18 ` Marius Bakke
[not found] ` <handler.41455.B.159015302429679.ack@debbugs.gnu.org>
2020-06-03 8:17 ` [bug#41455] Acknowledgement ([PATCH] gnu: Add python-daemux) Edouard Klein
2020-06-03 8:19 ` [bug#41455] [PATCH 1/2] gnu: Add python-libtmux Edouard Klein
2020-06-22 19:49 ` Marius Bakke
2020-06-03 8:20 ` [bug#41455] [PATCH 2/2] gnu: Add python-daemux Edouard Klein
2020-06-22 19:52 ` bug#41455: " Marius Bakke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d06rysxi.fsf@alice.lan \
--to=edou@rdklein.fr \
--cc=41455@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).