From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id QK5zFv4D8V5YPgAA0tVLHw (envelope-from ) for ; Mon, 22 Jun 2020 19:18:22 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id WBM8Ev4D8V4rSQAA1q6Kng (envelope-from ) for ; Mon, 22 Jun 2020 19:18:22 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D216A940225 for ; Mon, 22 Jun 2020 19:18:21 +0000 (UTC) Received: from localhost ([::1]:53214 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jnRxS-00074T-TP for larch@yhetil.org; Mon, 22 Jun 2020 15:18:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51548) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jnRxD-00071o-37 for guix-patches@gnu.org; Mon, 22 Jun 2020 15:18:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51250) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jnRxC-0006b4-MA for guix-patches@gnu.org; Mon, 22 Jun 2020 15:18:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jnRxC-0007ze-GT for guix-patches@gnu.org; Mon, 22 Jun 2020 15:18:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41293] [PATCH 1/3] gnu: Add sideload. Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 22 Jun 2020 19:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41293 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: rprior@protonmail.com, 41293@debbugs.gnu.org X-Debbugs-Original-To: Ryan Prior , Ryan Prior via Guix-patches , 41293@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.159285342230619 (code B ref -1); Mon, 22 Jun 2020 19:18:02 +0000 Received: (at submit) by debbugs.gnu.org; 22 Jun 2020 19:17:02 +0000 Received: from localhost ([127.0.0.1]:34557 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnRwD-0007xk-Kw for submit@debbugs.gnu.org; Mon, 22 Jun 2020 15:17:02 -0400 Received: from lists.gnu.org ([209.51.188.17]:50258) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnRwA-0007xS-F5 for submit@debbugs.gnu.org; Mon, 22 Jun 2020 15:17:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51372) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jnRwA-0006Ce-8W for guix-patches@gnu.org; Mon, 22 Jun 2020 15:16:58 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47339) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jnRw9-0006VZ-ID; Mon, 22 Jun 2020 15:16:57 -0400 Received: from ti0006q161-3115.bb.online.no ([88.95.106.80]:56460 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jnRw8-0003i5-T8; Mon, 22 Jun 2020 15:16:57 -0400 From: Marius Bakke In-Reply-To: <20200602012736.4292-2-rprior@protonmail.com> References: <20200602012736.4292-1-rprior@protonmail.com> <20200602012736.4292-2-rprior@protonmail.com> Date: Mon, 22 Jun 2020 21:16:54 +0200 Message-ID: <87d05qdi6x.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -3.11 X-TUID: 8k5fy63qGny6 --=-=-= Content-Type: text/plain Hello! Sorry for the slooow response... Ryan Prior via Guix-patches via writes: > * gnu/packages/pantheon.scm (sideload): New variable. [...] > + (modify-phases %standard-phases > + (add-before 'install 'set-environment-variables > + (lambda _ > + ;; Disable compiling schemas and updating desktop databases > + (setenv "DESTDIR" "/") > + #t)) That's an unorthodox workaround :-) does the build system ignore it when DESTDIR is set, or do they just end up in a different location? Is the "glib:bin" input still needed? > + (inputs > + `(("flatpak" ,flatpak) > + ("granite" ,granite) > + ("gtk" ,gtk+) > + ("libostree" ,libostree))) > + (propagated-inputs > + `(("glib-networking" ,glib-networking))) Can you add a comment about why this needs to be propagated? > + (native-inputs > + `(("cmake" ,cmake) Use 'cmake-minimal' if CMake is required (is it?). > + ("gettext" ,gettext-minimal) > + ("glib" ,glib) > + ("glib:bin" ,glib "bin") > + ("gobject-introspection" ,gobject-introspection) > + ("libgee" ,libgee) > + ("libxml2" ,libxml2) > + ("pkg-config" ,pkg-config) > + ("vala" ,vala))) > + (home-page "https://github.com/elementary/sideload") > + (synopsis "Graphical application to side-load Flatpaks") > + (description "Sideload handles flatpakref files, like those you might find > +on Flathub or another third-party website providing a Flatpak app for > +download.") > + (license license:gpl3))) This should be 'gpl3+' because no source files say "GPL 3 only" (in fact they explicitly mention GPL 3 or any later version). --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl7xA6YACgkQoqBt8qM6 VPrhWQf/UsAxZQXcowqSxjaRSrPlnwnUUnWymTp2+aC0mih13Rsg41LLwHbSho7g 9+HUDbz79GJdDoi+1WOH16cOz2gsrqKZi1Hh/J0Y9xvpw8VRjp36mFSAeW840U3Z u8jMpJkxsiysnB49ZKqav4iLD8jTZvW8rDz4jaeJBt0VQ5Vs0UI0HrT9eUubBY69 FlmNrFh4d2SCsriLr9kEHu2rxlfjWaFq0banTmXXQtljBv1CkfzDPHI+E3cjpaPp J0C2BFoIhjkNLa1vmcDolor/bvwFbRzysEZMLLGBFOYtsCCtvFGSv0nf/xizx2vD GAetdnss5VXwfHolk/kIrqLz7aBMoA== =84iI -----END PGP SIGNATURE----- --=-=-=--