From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id WODzFIPUCF9NNAAA0tVLHw (envelope-from ) for ; Fri, 10 Jul 2020 20:50:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 2NnYEIPUCF+mIwAAB5/wlQ (envelope-from ) for ; Fri, 10 Jul 2020 20:50:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B1735940E97 for ; Fri, 10 Jul 2020 20:50:10 +0000 (UTC) Received: from localhost ([::1]:48704 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jtzyC-0007Z1-Fm for larch@yhetil.org; Fri, 10 Jul 2020 16:50:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46842) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jtzy6-0007Ya-7t for guix-patches@gnu.org; Fri, 10 Jul 2020 16:50:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:60202) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jtzy5-0006pT-TL for guix-patches@gnu.org; Fri, 10 Jul 2020 16:50:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jtzy5-000575-RZ for guix-patches@gnu.org; Fri, 10 Jul 2020 16:50:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42302] [PATCH] gnu: Add xssproxy Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 10 Jul 2020 20:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42302 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ivan Kozlov Cc: 42302@debbugs.gnu.org Received: via spool by 42302-submit@debbugs.gnu.org id=B42302.159441416519606 (code B ref 42302); Fri, 10 Jul 2020 20:50:01 +0000 Received: (at 42302) by debbugs.gnu.org; 10 Jul 2020 20:49:25 +0000 Received: from localhost ([127.0.0.1]:43515 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jtzxV-00056A-Eh for submit@debbugs.gnu.org; Fri, 10 Jul 2020 16:49:25 -0400 Received: from eggs.gnu.org ([209.51.188.92]:32908) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jtzxR-00055s-9N for 42302@debbugs.gnu.org; Fri, 10 Jul 2020 16:49:24 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43022) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jtzxL-0006kf-Ov; Fri, 10 Jul 2020 16:49:15 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=55720 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jtzxL-0004E4-A4; Fri, 10 Jul 2020 16:49:15 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <173331594355886@mail.yandex.ru> Date: Fri, 10 Jul 2020 22:49:13 +0200 In-Reply-To: <173331594355886@mail.yandex.ru> (Ivan Kozlov's message of "Fri, 10 Jul 2020 07:49:54 +0300") Message-ID: <87d053yu2e.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: Z1hOIJjVMb8O Hi, Ivan Kozlov skribis: > xssproxy is a tiny daemon that provides an Idle Inhibition Service specif= ication conformant D-Bus interface to libXss. It allows programs that suppo= rt only this interface (like older Firefox and IceCat) to inhibit screen lo= cking or blanking on systems without a conformant screen locker program. > > * gnu/packages/xdisorg.scm (xssproxy): New variable. Nice! Note: you don=E2=80=99t need to provide a description of the package= in the commit log. Overall the patch looks good to me, modulo minor issues reported by =E2=80=98guix lint=E2=80=99 (see below for how to address them): --8<---------------cut here---------------start------------->8--- gnu/packages/xdisorg.scm:1384:12: xssproxy@1.0.0: 'pkg-config' should proba= bly be a native input gnu/packages/xdisorg.scm:1368:12: xssproxy@1.0.0: the source file name shou= ld contain the package name gnu/packages/xdisorg.scm:1368:12: xssproxy@1.0.0: the source URI should not= be an autogenerated tarball --8<---------------cut here---------------end--------------->8--- > +(define xssproxy Use =E2=80=98define-public=E2=80=99 instead. > + (source (origin > + (method url-fetch) > + (uri (string-append "https://github.com/timakro/xssproxy/a= rchive/v" > + version > + ".tar.gz")) Use =E2=80=99git-fetch=E2=80=99 instead of =E2=80=98url-fetch=E2=80=99 to f= etch the source over Git instead of an autogenerated tarball, and add a =E2=80=98file-name=E2=80=99 = field. > + (synopsis "Forward freedesktop.org Idle Inhibition Service calls to = Xss") > + (description "xssproxy implements the org.freedesktop.ScreenSaver D-= Bus interface > +described in the Idle Inhibition Service Draft by the freedesktop.org de= velopers. > +The inhibition of the screensaver is then controlled using the XScreenSa= verSuspend > +function from the Xss (X11 Screen Saver extension) library.") You can use markup for clarity, for instance @code{org.freedesktop.ScreenSaver}. Could you send an updated patch? Thank you! Ludo=E2=80=99.