From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id EFy3IhmuS1+ZVAAA0tVLHw (envelope-from ) for ; Sun, 30 Aug 2020 13:48:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id WO6LHhmuS184XAAA1q6Kng (envelope-from ) for ; Sun, 30 Aug 2020 13:48:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2042E9401CB for ; Sun, 30 Aug 2020 13:48:09 +0000 (UTC) Received: from localhost ([::1]:58708 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kCNgl-0005jt-Mc for larch@yhetil.org; Sun, 30 Aug 2020 09:48:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41266) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kCNgg-0005ho-Nd for guix-patches@gnu.org; Sun, 30 Aug 2020 09:48:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38118) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kCNgg-0003Fb-E7 for guix-patches@gnu.org; Sun, 30 Aug 2020 09:48:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kCNgg-0000vK-Be for guix-patches@gnu.org; Sun, 30 Aug 2020 09:48:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43101] [PATCH] Add version number in release ISO Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 30 Aug 2020 13:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43101 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Julien Lepiller Cc: 43101@debbugs.gnu.org Received: via spool by 43101-submit@debbugs.gnu.org id=B43101.15987952352542 (code B ref 43101); Sun, 30 Aug 2020 13:48:02 +0000 Received: (at 43101) by debbugs.gnu.org; 30 Aug 2020 13:47:15 +0000 Received: from localhost ([127.0.0.1]:49663 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCNfu-0000eg-L2 for submit@debbugs.gnu.org; Sun, 30 Aug 2020 09:47:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59330) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCNfr-0000Xd-JY for 43101@debbugs.gnu.org; Sun, 30 Aug 2020 09:47:12 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:39985) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kCNfl-0003Dv-OO; Sun, 30 Aug 2020 09:47:05 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=41834 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kCNfl-0003B7-Bq; Sun, 30 Aug 2020 09:47:05 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200829154445.5512d99a@tachikoma.lepiller.eu> Date: Sun, 30 Aug 2020 15:47:04 +0200 In-Reply-To: <20200829154445.5512d99a@tachikoma.lepiller.eu> (Julien Lepiller's message of "Sat, 29 Aug 2020 15:44:45 +0200") Message-ID: <87d038i6uf.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.49 X-TUID: DPRc3uVeZIuz Hi, Julien Lepiller skribis: > I've recently proposed a patch to libosinfo database, and they > suggested that we add the version number to the ISO label, so the tool > can differentiate and identify the ISOs. See > https://gitlab.com/libosinfo/osinfo-db/-/merge_requests/202 Good idea. >>>From a6d4cb90825b9e45c0baeaeaa653c57a9100b21a Mon Sep 17 00:00:00 2001 > From: Julien Lepiller > Date: Sat, 29 Aug 2020 15:34:56 +0200 > Subject: [PATCH 1/2] guix: system: Add `--label' option. > > * guix/scripts/system.scm (%options): Add `--label'. Please describe the other changes (to =E2=80=98system-derivation-for-action= =E2=80=99, etc.) > + (partitions (match (image-partitions base-image) > + ((boot others ...) > + (cons > + ((@ (gnu image) partition) > + (inherit boot) > + (label (or label (partition-label boot)))) Please include (gnu image) and avoid =E2=80=98@=E2=80=99. > + (display (G_ " > + --label=3DLABEL for 'disk-image', label disk image with LABEL= ")) Make sure to add it to doc/guix.texi as well. >>>From cd47229d93b6dd0d7a793230e6a103a40034f6a7 Mon Sep 17 00:00:00 2001 > From: Julien Lepiller > Date: Sat, 29 Aug 2020 15:36:40 +0200 > Subject: [PATCH 2/2] Makefile.am: Set iso label. > > * Makefile.am (release): Add version number in disk image label. LGTM. Thank you! :-) Ludo=E2=80=99.