From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id QL16CgTKZV/VKAAA0tVLHw (envelope-from ) for ; Sat, 19 Sep 2020 09:06:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id WHN0BgTKZV9NHwAAbx9fmQ (envelope-from ) for ; Sat, 19 Sep 2020 09:06:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8A870940274 for ; Sat, 19 Sep 2020 09:06:11 +0000 (UTC) Received: from localhost ([::1]:41426 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJYos-0001lq-Hn for larch@yhetil.org; Sat, 19 Sep 2020 05:06:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39352) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJYok-0001li-A1 for guix-patches@gnu.org; Sat, 19 Sep 2020 05:06:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34089) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kJYok-0001Ia-0j for guix-patches@gnu.org; Sat, 19 Sep 2020 05:06:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kJYoj-0003SK-SP for guix-patches@gnu.org; Sat, 19 Sep 2020 05:06:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43494] [PATCH 1/4] gnu: Add guix-build-coordinator. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 19 Sep 2020 09:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43494 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 43494@debbugs.gnu.org Received: via spool by 43494-submit@debbugs.gnu.org id=B43494.160050631113216 (code B ref 43494); Sat, 19 Sep 2020 09:06:01 +0000 Received: (at 43494) by debbugs.gnu.org; 19 Sep 2020 09:05:11 +0000 Received: from localhost ([127.0.0.1]:45635 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJYnv-0003R4-Iq for submit@debbugs.gnu.org; Sat, 19 Sep 2020 05:05:11 -0400 Received: from mira.cbaines.net ([212.71.252.8]:57726) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJYnt-0003Qx-O4 for 43494@debbugs.gnu.org; Sat, 19 Sep 2020 05:05:10 -0400 Received: from localhost (unknown [46.237.174.246]) by mira.cbaines.net (Postfix) with ESMTPSA id 4518E27BBE7; Sat, 19 Sep 2020 10:05:09 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 68cd3d6e; Sat, 19 Sep 2020 09:05:07 +0000 (UTC) References: <87o8m39bnc.fsf@cbaines.net> <20200918184042.22660-1-mail@cbaines.net> <87lfh6vodj.fsf@gnu.org> User-agent: mu4e 1.4.13; emacs 26.3 From: Christopher Baines In-reply-to: <87lfh6vodj.fsf@gnu.org> Date: Sat, 19 Sep 2020 10:05:06 +0100 Message-ID: <87d02i9lx9.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -3.11 X-TUID: Hwz07xoRhtfa --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Hi! > > Christopher Baines skribis: > >> * gnu/packages/package-management.scm (guix-build-coordinator): New vari= able. > > [...] > >> + (lambda* (#:key inputs outputs #:allow-other-keys) >> + (let* ((out (assoc-ref outputs "out")) >> + (bin (string-append out "/bin")) >> + (guile (assoc-ref inputs "guile")) >> + (guile-effective-version >> + (read-line >> + (open-pipe* OPEN_READ >> + (string-append guile "/bin/guile") >> + "-c" "(display (effective-version))")= )) > > Maybe use =E2=80=98target-guile-effective-version=E2=80=99 from (guix bui= ld > guile-build-system). I've changed this. I'll also try and remember and update the guix-data-service package accordingly, as that's where I copied this from. >> + (wrap-program (string-append bin "/" file) >> + `("PATH" ":" prefix >> + (,bin ,(assoc-ref inputs "sqitch"))) >> + `("PERL5LIB" ":" prefix >> + (,(getenv "PERL5LIB"))) > > Do we really need PERL5LIB here? Shouldn=E2=80=99t it be done in the wra= pper of > =E2=80=98sqitch=E2=80=99 directly? Hmm, when I packaged sqitch, I didn't add all the database drivers which are optional dependencies, but perl-dbd-pg did end up in there somehow (probably because that's needed by the guix-data-service). I've now gone ahead and added the database drivers which Guix has packages for [1], it does increase the closure size a bit, but it was quite big anyway. 1: http://git.savannah.gnu.org/cgit/guix.git/commit/?id=3D6a1c3a908c8aadfde5b5= fe405132839683a01776 All that means I can remove the wrapping here. >> + (scandir bin >> + (match-lambda >> + ((or "." "..") #f) >> + (_ #t)))) > > I think you could just use (find-files bin). Done. >> + (inputs >> + `(("guile" ,guile-3.0-latest) > > Rather ,@(assoc-ref (package-native-inputs guix) "guile"). Done. >> + ("sqitch" ,sqitch) >> + ("perl-dbd-sqlite" ,perl-dbd-sqlite))) > > Shouldn=E2=80=99t perl-dbd-sqlite be a dependency of sqitch? See above. >> + (home-page "https://git.cbaines.net/guile/guix/build-coordinator") >> + (synopsis "") >> + (description >> + "") > > Missing! :-) Ah, yeah, I should have remembered to lint the package. I've attempted to write something now, I'm still working on trying to explain what the Guix Build Coordinator is meant to be. > LGTM with changes along these lines! Thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl9lycJfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XdAdQ/8CgG11hrFpUwT8jxkToEexip5q3Gxt9MwtUK7nEmN6YmiRKO+5aEiWbGl rbLvKuxgtg673rb5+Th3LTUcprxlgh3SGFIXINHHqy3ybzyGm2vOFBDlZ1I8rbsS Hr195bVVHsirWQJzqPk0c4ukfaxEKc9V/QFa+VllJs/LlTobbuo8oqwkQ5wC6wUJ O+ZTJrXZpjDclFXGNGDEGGXJ2KnhxG7CMLt/SrgTrMy/0tpLyHsPYP1OXOOe7YQC dDXAx5zN3EkNSOCGWygi2QGiocRunVKJzhAWJr5WE62Vzn9/XxbuMxECs30kQuza AVKHA5q5hCL2kAFm80goM8nmdYzxZ/tMENpgySCb5FF1pcGQVpLjlsodao4AHPl9 c2x3cgr4DB8wiNx26O5ENEuR1vfInwlQVQz8zvd9tseD8BRh4bk+3f28ZXWs/VDz ZGCQ67Vp83+3poAV12+ScHvFu9MNX3jwICEHtISNnhtYlw8GS+icOpe1pmFCf4D6 4kxyXmj595OcZjv2xfVUso32XccTmTl9+c52Djj+SLlu91mJ20jJt/flxvv7uK6u T5SwfpHX+RThnJMFHjjwoFPV7CsyuTb9sfKDjgrf7hMepHYuX7jGqDjjrMMoXvco 4/0YlIIKP+gR3OvjTyg+YZVP/Fulbjm7xkgkHNZPxS6bXQJrKho= =hrmM -----END PGP SIGNATURE----- --=-=-=--