From: "Ludovic Courtès" <ludo@gnu.org>
To: Lars-Dominik Braun <ldb@leibniz-psychology.org>
Cc: 43699-done@debbugs.gnu.org
Subject: bug#43699: [PATCH] guix: Fix argument order of fxbit-set?
Date: Tue, 29 Sep 2020 22:56:08 +0200 [thread overview]
Message-ID: <87d024480n.fsf@gnu.org> (raw)
In-Reply-To: <20200929082923.GA7294@zpidnp36> (Lars-Dominik Braun's message of "Tue, 29 Sep 2020 10:29:23 +0200")
Hello!
Lars-Dominik Braun <ldb@leibniz-psychology.org> skribis:
> * guix/openpgp.scm (port-ascii-armored?): Fix it here…
> (get-packet*): …and here…
> (parse-subpackets): …and also here.
> * tests/openpgp.scm (%binary-sample): New test vector.
> ("port-ascii-armored?, #t"): Add test.
> ("port-ascii-armored?, #f"): Add another test.
Good catch!
The root problem is that the ‘fxbit-set?’ alias defined at the top of
openpgp.scm had the arguments swapped compared to ‘bit-set?’. So I
changed that alias instead of changing its users (‘fxbit-set?’ is
defined in R6RS).
Pushed as 680b80e37453d4e23ad8188d60894916e1c07162 along with the new
tests.
Thank you!
Ludo’.
next prev parent reply other threads:[~2020-09-29 20:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 8:29 [bug#43699] [PATCH] guix: Fix argument order of fxbit-set? Lars-Dominik Braun
2020-09-29 20:56 ` Ludovic Courtès [this message]
2020-09-30 6:30 ` Lars-Dominik Braun
2020-09-30 9:34 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d024480n.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=43699-done@debbugs.gnu.org \
--cc=ldb@leibniz-psychology.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).