unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Greg Hogan <code@greghogan.com>
Cc: 43913@debbugs.gnu.org
Subject: [bug#43913] [PATCH 0/4] gnu: Add aws-sdk-cpp.
Date: Fri, 23 Oct 2020 15:34:18 +0200	[thread overview]
Message-ID: <87d019nk11.fsf@gnu.org> (raw)
In-Reply-To: <CA+3U0Zmi2puFkuccZ30OgA8VTbN7wvgyVT8wNVpe1vAB9R6YZQ@mail.gmail.com> (Greg Hogan's message of "Sat, 10 Oct 2020 14:13:06 -0400")

Hi Greg,

Overall the patches LGTM.  Two minor issues:

  1. They were mangled on the way.  Could you send them as attachments
     or with ‘git send-email’ to this address?

  2. Could you improve descriptions?  In particular, please write full
     sentences, explain acronyms, and expound a bit as you see fit:

     https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html

Could you send updated patches?

Thanks, and sorry for the delay!

Ludo’.




  parent reply	other threads:[~2020-10-23 13:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-10 18:13 [bug#43913] [PATCH 0/4] gnu: Add aws-sdk-cpp Greg Hogan
     [not found] ` <handler.43913.B.160235361318782.ack@debbugs.gnu.org>
2020-10-10 18:16   ` [bug#43913] [PATCH 1/4] gnu: Add aws-c-common Greg Hogan
2020-10-10 18:18   ` [bug#43913] [PATCH 2/4] gnu: Add aws-checksums Greg Hogan
2020-10-10 18:19   ` [bug#43913] [PATCH 3/4] gnu: Add aws-c-event-stream Greg Hogan
2020-10-10 19:14   ` [bug#43913] [PATCH 4/4] gnu: Add aws-sdk-cpp Greg Hogan
2020-10-23 13:34 ` Ludovic Courtès [this message]
2020-12-09 22:35   ` [bug#43913] [PATCH 0/4] " Greg Hogan
2020-12-17 13:55     ` bug#43913: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d019nk11.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=43913@debbugs.gnu.org \
    --cc=code@greghogan.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).