From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 2GujDq46tl8CWgAA0tVLHw (envelope-from ) for ; Thu, 19 Nov 2020 09:28:14 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 2M2BCq46tl/VQAAA1q6Kng (envelope-from ) for ; Thu, 19 Nov 2020 09:28:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5E9D29400BF for ; Thu, 19 Nov 2020 09:28:13 +0000 (UTC) Received: from localhost ([::1]:36898 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kfgEd-0000to-To for larch@yhetil.org; Thu, 19 Nov 2020 04:28:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34366) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kfgEX-0000t0-GJ for guix-patches@gnu.org; Thu, 19 Nov 2020 04:28:05 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:54884) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kfgEU-00014T-5P for guix-patches@gnu.org; Thu, 19 Nov 2020 04:28:05 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kfgEU-0005PZ-1D for guix-patches@gnu.org; Thu, 19 Nov 2020 04:28:02 -0500 Subject: bug#38625: Fwd: [bug#38625] [PATCH] music.scm: Add glyr Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Thu, 19 Nov 2020 09:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 38625 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Riku Viitanen Cc: 38625-done@debbugs.gnu.org Mail-Followup-To: 38625@debbugs.gnu.org, mail@cbaines.net, riku.viitanen0@gmail.com Received: via spool by 38625-done@debbugs.gnu.org id=D38625.160577803620740 (code D ref 38625); Thu, 19 Nov 2020 09:28:01 +0000 Received: (at 38625-done) by debbugs.gnu.org; 19 Nov 2020 09:27:16 +0000 Received: from localhost ([127.0.0.1]:38197 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kfgDj-0005OR-Hu for submit@debbugs.gnu.org; Thu, 19 Nov 2020 04:27:15 -0500 Received: from mira.cbaines.net ([212.71.252.8]:60374) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kfgDh-0005OH-0G for 38625-done@debbugs.gnu.org; Thu, 19 Nov 2020 04:27:13 -0500 Received: from localhost (188.30.135.14.threembb.co.uk [188.30.135.14]) by mira.cbaines.net (Postfix) with ESMTPSA id 9D1DF27BBF5; Thu, 19 Nov 2020 09:27:11 +0000 (GMT) Received: from capella (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id ba83d017; Thu, 19 Nov 2020 09:27:08 +0000 (UTC) References: <874ky1cjac.fsf@elephly.net> User-agent: mu4e 1.4.13; emacs 27.1 From: Christopher Baines In-reply-to: Date: Thu, 19 Nov 2020 09:27:06 +0000 Message-ID: <87d009lms5.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -3.11 X-TUID: jorCuU+b8hXv --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Riku Viitanen writes: > Hi Ricardo, and thanks for the feedback! > > I think all the mentioned issues should now be fixed. > I checked some of the source files, and it turns out they say permit any > later version of the license, so I changed the license to lgpl3+. > Only the README file mentions "just" LGPLv3 without saying anything about > later versions, so I thought it meant the same as "only". Hi Riku, Apologies for the delay in following up on this. I've gone ahead and pushed the package definition to master as aee183e1a57aa7606c79d9375e8e3f13e7726e41. I made some tweaks which I'll describe below. Also, I couldn't figure out how to apply the patch you included. Because of things like email clients wrapping lines, the best approach for sending patches is "git send-email", and if that isn't an option, attaching the patch files to an email is the next best option. > Here's the new patch in git format: > > From 97d4d5d7d16eb87896d81e070510d919118aa622 Mon Sep 17 00:00:00 2001 > From: Riku Viitanen > Date: Wed, 18 Dec 2019 18:30:14 +0200 > Subject: [PATCH] gnu: Add glyr > > * gnu/packages/music.scm (glyr): New variable > --- > gnu/packages/music.scm | 35 +++++++++++++++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > > diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm > index f80fb067e8..0adfa96fbe 100644 > --- a/gnu/packages/music.scm > +++ b/gnu/packages/music.scm > @@ -25,6 +25,7 @@ > ;;; Copyright =C2=A9 2019 raingloom > ;;; Copyright =C2=A9 2019 David Wilson > ;;; Copyright =C2=A9 2019 Alexandros Theodotou > +;;; Copyright =C2=A9 2019 Riku Viitanen > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -5106,3 +5107,37 @@ MIDI drums and comes as two separate drumkits: Bla= ck > Pearl and Red Zeppelin.") > (description "Helm is a cross-platform polyphonic synthesizer > available standalone > and as an LV2 plugin.") > (license license:gpl3+))) > + > +(define-public glyr > + (package > + (name "glyr") > + (version "1.0.10") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/sahib/glyr.git") > + (commit version))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "1miwbqzkhg0v3zysrwh60pj9sv6ci4lzq2vq2hhc6pc6hdyh8xyr")= ))) > + (build-system cmake-build-system) > + (arguments > + '(#:tests? #f)) So I had a go at running the tests. Unfortunately some of them depend on the network, so I was only able to run some of them. There's also Python tests, but I think that requires packaging some additional Python libraries, so I've just put a comment in about that. > + (inputs > + `(("glib" ,glib) > + ("curl" ,curl) > + ("sqlite" ,sqlite))) > + (native-inputs > + `(("pkg-config" ,pkg-config))) > + (home-page "https://github.com/sahib/glyr") > + (synopsis "Search engine for music related metadata") > + (description > + "Glyr comes both in a command-line interface tool (@command{glyrc}) > and > +as a C library (libglyr), both with an easy to use interface. The sort of > +metadata glyr is searching (and downloading) is usually the data you see= in > +your musicplayer. And indeed, originally it was written to serve as > internally > +library for a musicplayer, but has been extended to work as a standalone > +program which is able to download cover art, lyrics, photos, biographies, > +reviews and more.") > + (license license:lgpl3+))) Thanks again for the patch, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl+2OmpfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XduOw//eIZ2P+q33E7p4lBRM+A+EBbrQdWv8EbE Asukj0JOD+a1PT9VuFxtXxYfGA2K3aFsHsY8HkouWsnTKACPRJ8hvxwZZV+TRlQF zm6mrfZ4K+6tMCl2IkxCJHjaZ4Nd61uYOUc6wwB84ywM0b8f8Uw4UAAFK8VuuBNL pAEM1HyTQxXHe7Llf6OPpvmeWmb7TVvpAoAJKzMRs/D5lLAwx/EmmBzerzEvevyP 7vI7o6WFt6snx8ZMYZv05VFYvsVQr0rFR0sf76aE3CMDrmS9KdZHyxnkUkG3bo3Y eZJNSCrN6/QoLObpmujUJNnPVlvuellXIzLZhdPIndq2VmbImYyjk7kKC0b6ic9D /FiFSPDzAQCzX1/ilJvdjM9B0MpggeFCD6QSA3gMJnQ48ifrEU0u14pUqcJW7CPo nCRibOzU23W+Z0WJvSfeRz5GZxozSK/pro/UWoFvRX68O2k6e2fJEOfHcieyS/Bt B7DFuj/+L7GwHfY49tbfMTRtO1vI1apuGfAqFQKX3X73EHXCikZD+fJ/u/jlhjI+ uhsycXRThijuMcPw4L2HhXQOR8Neg9r9cghDmzghlOt3QyZvBHjfQVLsadealZ+n AWGnjeSJ23Y05tIWXHfAjYoZlscEY25ijYtM/qhgVsfDo/9FPBDdOm62BbH+7QQR 6LkAuAV2smE= =AIcd -----END PGP SIGNATURE----- --=-=-=--