unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / Atom feed
* [bug#38625] [PATCH] music.scm: Add glyr
@ 2019-12-15 16:10 Riku Viitanen
  2019-12-15 22:31 ` Ricardo Wurmus
  0 siblings, 1 reply; 4+ messages in thread
From: Riku Viitanen @ 2019-12-15 16:10 UTC (permalink / raw)
  To: 38625

[-- Attachment #1: Type: text/plain, Size: 2247 bytes --]

Glyr contains a C library and a CLI tool for fetching album art and
metadata about music.

For example, abcde can use it to automatically download cover art.


diff a/guix/gnu/packages/music.scm b/guix/gnu/packages/music.scm
27a28
> ;;; Copyright © 2019 Riku Viitanen <riku.viitanen0@gmail.com>
5108a5110,5166
>
> (define-public glyr
>   (package
>     (name "glyr")
>     (version "1.0.10")
>     (source
>      (origin
>        (method url-fetch)
>        (uri (string-append "https://github.com/sahib/glyr/archive/"
>                            version ".tar.gz"))
>        (sha256
>         (base32 "1s06m1619j3kqgmnh9qv9bbqwvzjd4h4hdja5rhjg38w49hdms3p"))))
>     (build-system cmake-build-system)
>     (arguments
>      '(#:tests? #f)) ; no check target))
>     (inputs
>      `(("glib" ,glib)
>        ("curl" ,curl)
>        ("sqlite" ,sqlite)
>        ("pkg-config" ,pkg-config)))
>     (home-page "https://github.com/sahib/glyr")
>     (synopsis "Search engine for music related metadata")
>     (description
>      "It comes both in a command-line interface tool (@command{glyrc})
and as a C library (libglyr), both
> with an easy to use interface. The sort of metadata glyr is searching
(and
> downloading) is usually the data you see in your musicplayer. And indeed,
> originally it was written to serve as internally library for a
musicplayer,
> but has been extended to work as a standalone program which is able to
download:
> @table @code
> @item cover
> Coverart (front images supported only)
> @item lyrics
> Songtext
> @item artistphotos
> Photos of a certain band (press or live)
> @item rtistbio
> Artist biography from various sites
> @item review
> Album reviews from various sites
> @item albumlist
> A list of albums from a specific artist.
> @item tags
> Tags, either related to artist, album or title
> @item relations
> Links to Wikipedia, Myspace, MusicBrainz …
> @item similarartists
> Similar artists
> @item similarsongs
> Similar songs
> @item tracklist
> Tracklist of an album
> @item guitartabs
> Guitartabs in textual form
> @item backdrops
> Large artist photos, suitable for backgrounds
> @end table")
>     (license license:lgpl3)))

[-- Attachment #2: Type: text/html, Size: 2991 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#38625] [PATCH] music.scm: Add glyr
  2019-12-15 16:10 [bug#38625] [PATCH] music.scm: Add glyr Riku Viitanen
@ 2019-12-15 22:31 ` Ricardo Wurmus
       [not found]   ` <CA+2hkpV44p4Lw2dh46j2_yYMAn0tv0Y5Q4hzQ_mrZWhD1H3ODQ@mail.gmail.com>
  0 siblings, 1 reply; 4+ messages in thread
From: Ricardo Wurmus @ 2019-12-15 22:31 UTC (permalink / raw)
  To: Riku Viitanen; +Cc: 38625


Hi Riku,

thank you for your contribution.
Could you please resend this as a git formatted patch?  See the
Contributing section in the manual for more information on the workflow.

>>     (source
>>      (origin
>>        (method url-fetch)
>>        (uri (string-append "https://github.com/sahib/glyr/archive/"
>>                            version ".tar.gz"))

These /archive tarballs are automatically generated, so they can change
in place without prior notice.  Please use git-fetch instead.

>>     (arguments
>>      '(#:tests? #f)) ; no check target))

Please remove the trailing “))”.

>>     (inputs
>>      `(("glib" ,glib)
>>        ("curl" ,curl)
>>        ("sqlite" ,sqlite)
>>        ("pkg-config" ,pkg-config)))

pkg-config should be a native-input.

>>     (home-page "https://github.com/sahib/glyr")
>>     (synopsis "Search engine for music related metadata")
>>     (description
>>      "It comes both in a command-line interface tool (@command{glyrc})
> and as a C library (libglyr), both […]

Please “reflow” the description to fit 80 columns and perhaps shorten it
a little.

>>     (license license:lgpl3)))

Only version 3 or also any other version?

-- 
Ricardo

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#38625] Fwd: [bug#38625] [PATCH] music.scm: Add glyr
       [not found]   ` <CA+2hkpV44p4Lw2dh46j2_yYMAn0tv0Y5Q4hzQ_mrZWhD1H3ODQ@mail.gmail.com>
@ 2019-12-18 16:57     ` Riku Viitanen
  2020-11-19  9:27       ` bug#38625: " Christopher Baines
  0 siblings, 1 reply; 4+ messages in thread
From: Riku Viitanen @ 2019-12-18 16:57 UTC (permalink / raw)
  To: 38625

[-- Attachment #1: Type: text/plain, Size: 2851 bytes --]

Hi Ricardo, and thanks for the feedback!

I think all the mentioned issues should now be fixed.
I checked some of the source files, and it turns out they say permit any
later version of the license, so I changed the license to lgpl3+.
Only the README file mentions "just" LGPLv3 without saying anything about
later versions, so I thought it meant the same as "only".

Here's the new patch in git format:

From 97d4d5d7d16eb87896d81e070510d919118aa622 Mon Sep 17 00:00:00 2001
From: Riku Viitanen <riku.viitanen0@gmail.com>
Date: Wed, 18 Dec 2019 18:30:14 +0200
Subject: [PATCH] gnu: Add glyr

* gnu/packages/music.scm (glyr): New variable
---
 gnu/packages/music.scm | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index f80fb067e8..0adfa96fbe 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -25,6 +25,7 @@
 ;;; Copyright © 2019 raingloom <raingloom@protonmail.com>
 ;;; Copyright © 2019 David Wilson <david@daviwil.com>
 ;;; Copyright © 2019 Alexandros Theodotou <alex@zrythm.org>
+;;; Copyright © 2019 Riku Viitanen <riku.viitanen0@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -5106,3 +5107,37 @@ MIDI drums and comes as two separate drumkits: Black
Pearl and Red Zeppelin.")
     (description "Helm is a cross-platform polyphonic synthesizer
available standalone
 and as an LV2 plugin.")
     (license license:gpl3+)))
+
+(define-public glyr
+  (package
+    (name "glyr")
+    (version "1.0.10")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                     (url "https://github.com/sahib/glyr.git")
+                     (commit version)))
+              (file-name (git-file-name name version))
+              (sha256
+                (base32
+                 "1miwbqzkhg0v3zysrwh60pj9sv6ci4lzq2vq2hhc6pc6hdyh8xyr"))))
+    (build-system cmake-build-system)
+    (arguments
+     '(#:tests? #f))
+    (inputs
+     `(("glib" ,glib)
+       ("curl" ,curl)
+       ("sqlite" ,sqlite)))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (home-page "https://github.com/sahib/glyr")
+    (synopsis "Search engine for music related metadata")
+    (description
+     "Glyr comes both in a command-line interface tool (@command{glyrc})
and
+as a C library (libglyr), both with an easy to use interface. The sort of
+metadata glyr is searching (and downloading) is usually the data you see in
+your musicplayer. And indeed, originally it was written to serve as
internally
+library for a musicplayer, but has been extended to work as a standalone
+program which is able to download cover art, lyrics, photos, biographies,
+reviews and more.")
+    (license license:lgpl3+)))
-- 
2.24.1

[-- Attachment #2: Type: text/html, Size: 3963 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#38625: Fwd: [bug#38625] [PATCH] music.scm: Add glyr
  2019-12-18 16:57     ` [bug#38625] Fwd: " Riku Viitanen
@ 2020-11-19  9:27       ` Christopher Baines
  0 siblings, 0 replies; 4+ messages in thread
From: Christopher Baines @ 2020-11-19  9:27 UTC (permalink / raw)
  To: Riku Viitanen; +Cc: 38625-done

[-- Attachment #1: Type: text/plain, Size: 3842 bytes --]


Riku Viitanen <riku.viitanen0@gmail.com> writes:

> Hi Ricardo, and thanks for the feedback!
>
> I think all the mentioned issues should now be fixed.
> I checked some of the source files, and it turns out they say permit any
> later version of the license, so I changed the license to lgpl3+.
> Only the README file mentions "just" LGPLv3 without saying anything about
> later versions, so I thought it meant the same as "only".

Hi Riku,

Apologies for the delay in following up on this.

I've gone ahead and pushed the package definition to master as
aee183e1a57aa7606c79d9375e8e3f13e7726e41. I made some tweaks which I'll
describe below.

Also, I couldn't figure out how to apply the patch you included. Because
of things like email clients wrapping lines, the best approach for
sending patches is "git send-email", and if that isn't an option,
attaching the patch files to an email is the next best option.

> Here's the new patch in git format:
>
> From 97d4d5d7d16eb87896d81e070510d919118aa622 Mon Sep 17 00:00:00 2001
> From: Riku Viitanen <riku.viitanen0@gmail.com>
> Date: Wed, 18 Dec 2019 18:30:14 +0200
> Subject: [PATCH] gnu: Add glyr
>
> * gnu/packages/music.scm (glyr): New variable
> ---
>  gnu/packages/music.scm | 35 +++++++++++++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)
>
> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> index f80fb067e8..0adfa96fbe 100644
> --- a/gnu/packages/music.scm
> +++ b/gnu/packages/music.scm
> @@ -25,6 +25,7 @@
>  ;;; Copyright © 2019 raingloom <raingloom@protonmail.com>
>  ;;; Copyright © 2019 David Wilson <david@daviwil.com>
>  ;;; Copyright © 2019 Alexandros Theodotou <alex@zrythm.org>
> +;;; Copyright © 2019 Riku Viitanen <riku.viitanen0@gmail.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -5106,3 +5107,37 @@ MIDI drums and comes as two separate drumkits: Black
> Pearl and Red Zeppelin.")
>      (description "Helm is a cross-platform polyphonic synthesizer
> available standalone
>  and as an LV2 plugin.")
>      (license license:gpl3+)))
> +
> +(define-public glyr
> +  (package
> +    (name "glyr")
> +    (version "1.0.10")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                     (url "https://github.com/sahib/glyr.git")
> +                     (commit version)))
> +              (file-name (git-file-name name version))
> +              (sha256
> +                (base32
> +                 "1miwbqzkhg0v3zysrwh60pj9sv6ci4lzq2vq2hhc6pc6hdyh8xyr"))))
> +    (build-system cmake-build-system)
> +    (arguments
> +     '(#:tests? #f))

So I had a go at running the tests. Unfortunately some of them depend on
the network, so I was only able to run some of them. There's also Python
tests, but I think that requires packaging some additional Python
libraries, so I've just put a comment in about that.

> +    (inputs
> +     `(("glib" ,glib)
> +       ("curl" ,curl)
> +       ("sqlite" ,sqlite)))
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)))
> +    (home-page "https://github.com/sahib/glyr")
> +    (synopsis "Search engine for music related metadata")
> +    (description
> +     "Glyr comes both in a command-line interface tool (@command{glyrc})
> and
> +as a C library (libglyr), both with an easy to use interface. The sort of
> +metadata glyr is searching (and downloading) is usually the data you see in
> +your musicplayer. And indeed, originally it was written to serve as
> internally
> +library for a musicplayer, but has been extended to work as a standalone
> +program which is able to download cover art, lyrics, photos, biographies,
> +reviews and more.")
> +    (license license:lgpl3+)))

Thanks again for the patch,

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-11-19  9:28 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-15 16:10 [bug#38625] [PATCH] music.scm: Add glyr Riku Viitanen
2019-12-15 22:31 ` Ricardo Wurmus
     [not found]   ` <CA+2hkpV44p4Lw2dh46j2_yYMAn0tv0Y5Q4hzQ_mrZWhD1H3ODQ@mail.gmail.com>
2019-12-18 16:57     ` [bug#38625] Fwd: " Riku Viitanen
2020-11-19  9:27       ` bug#38625: " Christopher Baines

unofficial mirror of guix-patches@gnu.org 

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://yhetil.org/guix-patches/1 guix-patches/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 guix-patches guix-patches/ https://yhetil.org/guix-patches \
		guix-patches@gnu.org
	public-inbox-index guix-patches

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://news.yhetil.org/yhetil.gnu.guix.patches


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git