From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id uD9PIo5SzV9/UgAA0tVLHw (envelope-from ) for ; Sun, 06 Dec 2020 21:52:14 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id aDMKHo5SzV+RBwAAbx9fmQ (envelope-from ) for ; Sun, 06 Dec 2020 21:52:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3F5A39403AA for ; Sun, 6 Dec 2020 21:52:14 +0000 (UTC) Received: from localhost ([::1]:55620 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1km1wz-0006Vo-8d for larch@yhetil.org; Sun, 06 Dec 2020 16:52:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44256) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1km1wo-0006VX-K2 for guix-patches@gnu.org; Sun, 06 Dec 2020 16:52:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:39994) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1km1wn-0007X7-UC for guix-patches@gnu.org; Sun, 06 Dec 2020 16:52:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1km1wn-00064K-Su for guix-patches@gnu.org; Sun, 06 Dec 2020 16:52:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45018] [PATCH 2/6] daemon: Use 'Agent' to spawn 'guix substitute --query'. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 06 Dec 2020 21:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45018 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mathieu Othacehe Cc: 45018@debbugs.gnu.org Received: via spool by 45018-submit@debbugs.gnu.org id=B45018.160729149623296 (code B ref 45018); Sun, 06 Dec 2020 21:52:01 +0000 Received: (at 45018) by debbugs.gnu.org; 6 Dec 2020 21:51:36 +0000 Received: from localhost ([127.0.0.1]:51540 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1km1wO-00063g-1v for submit@debbugs.gnu.org; Sun, 06 Dec 2020 16:51:36 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54174) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1km1wM-00063S-R7 for 45018@debbugs.gnu.org; Sun, 06 Dec 2020 16:51:35 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44086) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1km1wH-0007N7-JV for 45018@debbugs.gnu.org; Sun, 06 Dec 2020 16:51:29 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=47042 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1km1wG-00054V-Fi; Sun, 06 Dec 2020 16:51:28 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20201203101930.11210-1-ludo@gnu.org> <20201203101930.11210-2-ludo@gnu.org> <87wnxynfni.fsf@gnu.org> Date: Sun, 06 Dec 2020 22:51:26 +0100 In-Reply-To: <87wnxynfni.fsf@gnu.org> (Mathieu Othacehe's message of "Fri, 04 Dec 2020 09:23:29 +0100") Message-ID: <87czzm4n8h.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.80 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 3F5A39403AA X-Spam-Score: -2.80 X-Migadu-Scanner: ns3122888.ip-94-23-21.eu X-TUID: dPMIzyzyoJhJ Mathieu Othacehe skribis: >> + (("--substitute" store-path destination) >> + ;; Download STORE-PATH and add store it as a Nar in file DEST= INATION. > > add it to store? Oops. >> + const Strings args =3D { "substitute", "--query" }; >> + const std::map env =3D { { "_NIX_OPTIONS", settings.pa= ck() } }; >> + std::unique_ptrfresh(new Agent(settings.guixProgram, args, env)= ); > > You should prefer make_unique to "new" calls. Apparently =E2=80=98make_unique=E2=80=99 is a C++14 thing and we don=E2=80= =99t build against that standard (yet), so I left it as is. The next patch removes this use of =E2=80=98unique_ptr=E2=80=99 anyway.