From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id OJ2VEife8V/FSAAA0tVLHw (envelope-from ) for ; Sun, 03 Jan 2021 15:09:27 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id YGpoDife8V+7YgAAB5/wlQ (envelope-from ) for ; Sun, 03 Jan 2021 15:09:27 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DA633940481 for ; Sun, 3 Jan 2021 15:09:26 +0000 (UTC) Received: from localhost ([::1]:53850 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kw50X-0003Mh-SO for larch@yhetil.org; Sun, 03 Jan 2021 10:09:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53280) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kw50A-0003MO-SY for guix-patches@gnu.org; Sun, 03 Jan 2021 10:09:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:55017) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kw50A-0001YN-Lj for guix-patches@gnu.org; Sun, 03 Jan 2021 10:09:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kw50A-00041f-H1 for guix-patches@gnu.org; Sun, 03 Jan 2021 10:09:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45409] [PATCH 3/3] guix: Split (guix substitute) from (guix scripts substitute). Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 03 Jan 2021 15:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45409 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Received: via spool by 45409-submit@debbugs.gnu.org id=B45409.160968652315448 (code B ref 45409); Sun, 03 Jan 2021 15:09:02 +0000 Received: (at 45409) by debbugs.gnu.org; 3 Jan 2021 15:08:43 +0000 Received: from localhost ([127.0.0.1]:38330 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kw4zq-000415-MP for submit@debbugs.gnu.org; Sun, 03 Jan 2021 10:08:42 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60052) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kw4zp-00040t-MK for 45409@debbugs.gnu.org; Sun, 03 Jan 2021 10:08:41 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43472) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kw4zk-0001PE-Gu; Sun, 03 Jan 2021 10:08:36 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=33262 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kw4zk-0002Qt-2s; Sun, 03 Jan 2021 10:08:36 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20201224172221.21057-1-mail@cbaines.net> <20201224172221.21057-3-mail@cbaines.net> Date: Sun, 03 Jan 2021 16:08:34 +0100 In-Reply-To: <20201224172221.21057-3-mail@cbaines.net> (Christopher Baines's message of "Thu, 24 Dec 2020 17:22:21 +0000") Message-ID: <87czym12j1.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45409@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.83 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: DA633940481 X-Spam-Score: -2.83 X-Migadu-Scanner: scn0.migadu.com X-TUID: 5fFZ2z6B98FZ Hi, Christopher Baines skribis: > This means there's a module for working with substitutes, rather than all= the > code sitting in the script. The need for this can be seen with the weathe= r and > challenge scripts, that now don't have to use code from the substitute sc= ript, > but can instead use the substitute module. > > The separation here between the actual functionality of the substitute sc= ript > and the underlying functionality used both there and elsewhere should make > maintenance easier moving forward. > > This commit just moves code, none of the code should have been changed > significantly. It would still be nice to list the identifiers that were moved in the commit log, it=E2=80=99s boring :-) but it can be helpful when browsing the history. As for the split, I wouldn=E2=80=99t put as much into (guix substitutes) (I= =E2=80=99d use =E2=80=9Csubstitutes=E2=80=9D, plural, for consistency with most other = modules.) As a rule of thumb, I would keep in (guix scripts substitute) anything that=E2=80=99s very much biased towards a single short-lived process: conne= ction cache, host name resolution failure cache, etc. These things are a bit hacky and not designed for use as a library. They=E2=80=99re also very much policy rather than mechanism, and as such they don=E2=80=99t belong in a pr= oper library IMO. > -(define* (http-multiple-get base-uri proc seed requests > - #:key port (verify-certificate? #t) > - (open-connection guix:open-connection-for-ur= i) > - (keep-alive? #t) > - (batch-size 1000)) How about moving this one to (guix http-client), as a separate patch? I think it=E2=80=99s a better fit and could be useful elsewhere. Thanks! Ludo=E2=80=99.