From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id SCScOMvoEWCVYQAA0tVLHw (envelope-from ) for ; Wed, 27 Jan 2021 22:27:23 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id AKR3NMvoEWC8fQAA1q6Kng (envelope-from ) for ; Wed, 27 Jan 2021 22:27:23 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 964509401C0 for ; Wed, 27 Jan 2021 22:27:23 +0000 (UTC) Received: from localhost ([::1]:48172 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l4tHW-0002mC-Ku for larch@yhetil.org; Wed, 27 Jan 2021 17:27:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54562) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l4tHD-0002m3-Vd for guix-patches@gnu.org; Wed, 27 Jan 2021 17:27:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:34826) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l4tHC-0008G1-KC for guix-patches@gnu.org; Wed, 27 Jan 2021 17:27:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l4tHC-0007LE-GE for guix-patches@gnu.org; Wed, 27 Jan 2021 17:27:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#46139] [PATCH] gnu: Add tpm2-tss. Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 27 Jan 2021 22:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46139 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 46139@debbugs.gnu.org Received: via spool by 46139-submit@debbugs.gnu.org id=B46139.161178637728150 (code B ref 46139); Wed, 27 Jan 2021 22:27:02 +0000 Received: (at 46139) by debbugs.gnu.org; 27 Jan 2021 22:26:17 +0000 Received: from localhost ([127.0.0.1]:46366 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4tGP-0007Ju-Q6 for submit@debbugs.gnu.org; Wed, 27 Jan 2021 17:26:17 -0500 Received: from tobias.gr ([80.241.217.52]:36306) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4tGL-0007Jk-UH for 46139@debbugs.gnu.org; Wed, 27 Jan 2021 17:26:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tobias.gr; s=2018; bh=lkWRqytwbRlruH1sFB3snxuXF6h7NO/kQIhcNaXyuZQ=; h=date:in-reply-to: references:subject:to:from; b=U6bzf2kv96197lUFOevAF1eo1uYl6PBD4rRKe5zU UD8lE6mrkTbmElx5QNOv8m4FzANVDQ5OjkiL0XYruYcRyiD4O3yEdnzEdN5SH0Q6cHVZHD tI/Y1suCE0PkeeHUcXZunPdpGncy32NR8CWFfqNx9T3f+l72rJwrQCJs/bJTwvcoEuQYNr kbK9U9e1weBZ6/n2SzjkxN/7Sf5aBcOXN7roKUNuOdMJnJi5pcqgi4+ts66v/lIiHPtaDD ZPI43eWLOnmHVtYEBlJADt4U5eQ5VD9nbJUfYSnnbNbUOtm1g/3Ngy0w8qvRw4EK9ytGI3 aYY+mXMB6oYuUHWSPb0KcQ== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id ee9dcc4c (TLSv1.2:ECDHE-ECDSA-AES256-GCM-SHA384:256:NO) for <46139@debbugs.gnu.org>; Wed, 27 Jan 2021 22:26:47 +0000 (UTC) BIMI-Selector: v=BIMI1; s=default; References: <20210127184227.29258-1-lle-bout@zaclys.net> <87y2geqfdm.fsf@nicolasgoaziou.fr> In-reply-to: <87y2geqfdm.fsf@nicolasgoaziou.fr> Date: Wed, 27 Jan 2021 23:26:11 +0100 Message-ID: <87czxqyq2k.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Tobias Geerinckx-Rice X-ACL-Warn: , Tobias Geerinckx-Rice via Guix-patches From: guix-patches--- via X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.45 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tobias.gr header.s=2018 header.b=U6bzf2kv; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 964509401C0 X-Spam-Score: -4.45 X-Migadu-Scanner: scn0.migadu.com X-TUID: k4p1SwbC8Nq5 --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Leo, Thanks! > (uri (string-append ... name ...)) Nitpick: there is no point in parameterising NAME here. Unlike=20 VERSION, it's more likely to cause future work than to save any.=20 Just hard-code it. > (inputs ...) Did you forget `(use-modules (gnu packages tls))'? > (synopsis "OSS implementation of the TCG TPM2 Software Stack=20 > (TSS2)") s/OSS i/I/ Likewise, Windows support is irrelevant, so we don't mention it.=20 Don't know enough about the =E2=80=98Microsoft software TPM2 simulator=E2= =80=99 to=20 know if it is. > IIRC, the manual suggests description of about 5 lines. At minimum, IMO :-) Between 5 and 10, depending on how much there=20 is to say about the package. Reducing each @item to ~1 sentence would strike a good balance.=20 Be sure to keep any keywords that could help people =E2=80=98guix search=E2= =80=99=20 for this package. Drop the boring spec minutia. > Trusted Computing Group's (TCG) You can mark these up as @acronym{TCG, Trusted Computing Group}. When finished, don't forget to run =E2=80=98guix lint tpm2-tss=E2=80=99. Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCYBHogw0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15NHsBAP6OC67mK9MIAjP2ERpSg5HGG5C/vJE/nlVF3MJT 0fDzAQDWw26JHIgBGlnUu0k/eQ0SWPbocsH1U5HxlfsZIC9vDw== =z3Ig -----END PGP SIGNATURE----- --=-=-=--