From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id EHHOKNQ1GGB7cwAA0tVLHw (envelope-from ) for ; Mon, 01 Feb 2021 17:09:40 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id CIKXJNQ1GGBfLwAAB5/wlQ (envelope-from ) for ; Mon, 01 Feb 2021 17:09:40 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E0439940276 for ; Mon, 1 Feb 2021 17:09:39 +0000 (UTC) Received: from localhost ([::1]:51634 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l6chm-0002tz-Su for larch@yhetil.org; Mon, 01 Feb 2021 12:09:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60456) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6cbO-0003bo-Rg for guix-patches@gnu.org; Mon, 01 Feb 2021 12:03:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:49703) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l6cbO-0001eN-KB for guix-patches@gnu.org; Mon, 01 Feb 2021 12:03:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l6cbO-0003Nb-H8 for guix-patches@gnu.org; Mon, 01 Feb 2021 12:03:02 -0500 Subject: bug#45712: [PATCHES] Improve Python package quality Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Mon, 01 Feb 2021 17:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 45712 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Lars-Dominik Braun Mail-Followup-To: 45712@debbugs.gnu.org, maxim.cournoyer@gmail.com, lars@6xq.net Received: via spool by 45712-done@debbugs.gnu.org id=D45712.161219897912977 (code D ref 45712); Mon, 01 Feb 2021 17:03:02 +0000 Received: (at 45712-done) by debbugs.gnu.org; 1 Feb 2021 17:02:59 +0000 Received: from localhost ([127.0.0.1]:33014 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l6cbJ-0003NC-L5 for submit@debbugs.gnu.org; Mon, 01 Feb 2021 12:02:59 -0500 Received: from mail-qv1-f45.google.com ([209.85.219.45]:36761) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l6cbH-0003N0-LW for 45712-done@debbugs.gnu.org; Mon, 01 Feb 2021 12:02:56 -0500 Received: by mail-qv1-f45.google.com with SMTP id es14so8461692qvb.3 for <45712-done@debbugs.gnu.org>; Mon, 01 Feb 2021 09:02:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=66BT5JEd8a/p1wDw9mcpREWq0CkEvh0h/ll/1H5Xvuo=; b=vViFpl2kUuQGIu8qx0AZWtcWtMHJVrT1ejGTcCiab0PMjitrKsEe3WRuGECIdpoptS 3HCosSQwmbIzayIbnIWGawb5iX6khrL5ScTsjGAbxCXYFC3b66jPj6CPzi4nry5pWj+z gkL03V1IvtrOGterltLrrEHQMKz8N0RZosWrBiVOQR+lBuz3Je32Rqsba1COZrVvE0/z VBxPFFg2kVw67SMnlhxbpB6EfSNVleF+A4vLIZIhkceS3DzN7/6gI2iBw3zuWbr3Ktov GNLHYMcScwrnkbh16SgTGaHRfGzvnj6N/QY9KrCdsZ1tDMvbSMEi3iFighdvpmk4w5zp FEtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=66BT5JEd8a/p1wDw9mcpREWq0CkEvh0h/ll/1H5Xvuo=; b=HQCncKHNHyzIV3amVXO+djFlgazX/s/0eHsn7xfsdqhFvS4fu7x6LGfvY0EvJuYxDv zp2GgNxOBYjaOaWIKbWTz8HyY9Zmk2f8MjVFrU5Ji56FlM1jSPU4ft1lmmqrbO8HMFU4 FCEwQVQBg2ch90zMEghBbwwAO4Rq/ouFfvGOF2cu2vKKPoWu4LHx/eLGUIsm8QD6YRR1 2HseS9Yn4/fkg90p/odnCZL9WmJOBBhfLw+Bp/pvViabPwtBfhEP/EdU6XtLVGyoTped 9Yy2sCSX1cssJmpFiVdQ0J4wMPVA6SfyWaOLnEzQE2zhuwDVVHUKaJA3Ksqk1talzUqh nrbA== X-Gm-Message-State: AOAM5331yxHhBw39RhRY9Dv2JCb1MwLskMh7ws78krQOszaGOWUTYcaD EgluHv84RU7ba4LIjpmDWKeHFrzRtUc= X-Google-Smtp-Source: ABdhPJx4qX918PLSUKSDSn87Cu28Q8wS7q3I2usjSMjurfLHmbJmfGLV5FSb/ukZ5luFHIzmeFkhPQ== X-Received: by 2002:a0c:b4d1:: with SMTP id h17mr15912841qvf.53.1612198969640; Mon, 01 Feb 2021 09:02:49 -0800 (PST) Received: from hurd (dsl-205-236-230-168.b2b2c.ca. [205.236.230.168]) by smtp.gmail.com with ESMTPSA id h63sm13084903qtd.14.2021.02.01.09.02.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Feb 2021 09:02:47 -0800 (PST) From: Maxim Cournoyer References: <87czxs3jel.fsf_-_@gmail.com> <874kj1ysr9.fsf_-_@gmail.com> <87h7mzyg39.fsf_-_@gmail.com> Date: Mon, 01 Feb 2021 12:02:44 -0500 In-Reply-To: (Lars-Dominik Braun's message of "Mon, 1 Feb 2021 08:20:45 +0100") Message-ID: <87czxjsouj.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45712-done@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.26 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=vViFpl2k; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: E0439940276 X-Spam-Score: -1.26 X-Migadu-Scanner: scn1.migadu.com X-TUID: 6yqNAyS8MXi6 Hi Lars, Lars-Dominik Braun writes: > Hi Maxim, > >> Oh yes, sorry I had failed to mention it, this is on the >> cu/farewell-to-pythonpath branch, which is the integration of >> GUIX_PYTHONPATH and this work of yours. I've included your v2 patches, >> with light editing: fixed the script indentation (spot via flake8), I >> removed the python2 tests as Python 2 is obsolete, and removed the space >> between the (procedure)[area/conditional] part of the GNU changelog >> commit messages. > thanks! > >> Another note to help with review; when sending v2 patches, make sure the >> title of your mail reply mentions [PATCH v2]; this helps to spot the >> later versions in email threads. > Sorry about that, will do next time. > >> The branch is shaping up nicely; I encourage you to try it. If no major >> problem is found with it, I'll merge it in core-updates soon. > I=E2=80=99ve been rebuilding packages on my list that use python-build-sy= stem > using this branch and quite a few fail, but in a random sample I found > none that fails due to this patch and also I imagine some issues are > already fixed on core-updates? Is there anything else I can do? I guess we can be bold and merge the branch to core-updates, and fix any breakage that may occur there! I've done so, the last commit of the series is 1b9186828867e77af1f2ee6741063424f8256398. Let's make Python on Guix great again! Thank you :-) Closing, Maxim