From: Mathieu Othacehe <othacehe@gnu.org>
To: Brice Waegeneire <brice@waegenei.re>
Cc: 46504-done@debbugs.gnu.org
Subject: bug#46504: [PATCH] services: wireguard: New service.
Date: Wed, 17 Feb 2021 10:38:33 +0100 [thread overview]
Message-ID: <87czwzghk6.fsf@gnu.org> (raw)
In-Reply-To: <87a6s67m5k.fsf@waegenei.re> (Brice Waegeneire's message of "Sun, 14 Feb 2021 15:35:03 +0100")
Hello Brice,
> Cool, more intergration of Wireguard in Guix! I started wiriting such a
> service but didn't finialized it yet. Tho, I wasn't sure if it needed to
> be implemented with wg-quick since upstream describe it as « a very
> quick and dirty bash script for reading a few extra variables from
> wg(8)-style configuration files, and automatically configures the
> interface »¹.
Yeah, this made me hesitate too. However, I think that having this small
service is always better than a raw configuration file. It would of
course be nice to have a more complete service, maybe relying on
Guile-Netlink in the future.
> wg-quick(8) say that the ”Address” attribute can be specified multiple
> times and is « a comma-separated list of IP (v4 or v6) addresses
> (optionally with CIDR masks) to be assigned to the interface. », so the
> “address” field should probably be “addresses”, a list of string.
You're right, fixed.
> Some of the missing attributes from wg-quick(8) like “DNS” or hooks
> seems realy usefull, maybe a “extra-config” field to the record could be
> added to support all of thoses attributes.
Yes, I'll add it as a follow-up.
> Why having a “public-key” field since it is derived from the private
> key? It seems to allow missconfiguration: what happen if the private
> and public part of a key don't match, or if only the “public-key” is
> set?
The rationale was that when the private key is generated, the user can
just "cat /etc/wireguard/public.key" instead of running "wg pubkey <
/etc/wireguard/private.key" but I agree it is misleading and I removed
this field.
I pushed the revised patch as 43b2e440c38a39eb64088bd6c08771c060aa10fc.
Thanks,
Mathieu
prev parent reply other threads:[~2021-02-17 9:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-14 9:33 [bug#46504] [PATCH] services: wireguard: New service Mathieu Othacehe
2021-02-14 14:35 ` Brice Waegeneire
2021-02-17 9:38 ` Mathieu Othacehe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czwzghk6.fsf@gnu.org \
--to=othacehe@gnu.org \
--cc=46504-done@debbugs.gnu.org \
--cc=brice@waegenei.re \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).