From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id scxKAH4sTmDrTwAA0tVLHw (envelope-from ) for ; Sun, 14 Mar 2021 15:32:14 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id mPZhN30sTmAzYwAA1q6Kng (envelope-from ) for ; Sun, 14 Mar 2021 15:32:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8800013C5D for ; Sun, 14 Mar 2021 16:32:13 +0100 (CET) Received: from localhost ([::1]:48430 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lLSiy-0001af-P1 for larch@yhetil.org; Sun, 14 Mar 2021 11:32:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56190) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lLSip-0001aS-Qp for guix-patches@gnu.org; Sun, 14 Mar 2021 11:32:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:50770) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lLSin-0005eD-Nn for guix-patches@gnu.org; Sun, 14 Mar 2021 11:32:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lLSin-00084k-Jr for guix-patches@gnu.org; Sun, 14 Mar 2021 11:32:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47081] [PATCH v2 5/6] services: Remove mongodb service. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 14 Mar 2021 15:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47081 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: =?UTF-8?Q?L=C3=A9o?= Le Bouter Cc: 47081@debbugs.gnu.org Received: via spool by 47081-submit@debbugs.gnu.org id=B47081.161573591931033 (code B ref 47081); Sun, 14 Mar 2021 15:32:01 +0000 Received: (at 47081) by debbugs.gnu.org; 14 Mar 2021 15:31:59 +0000 Received: from localhost ([127.0.0.1]:34083 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lLSil-00084T-2W for submit@debbugs.gnu.org; Sun, 14 Mar 2021 11:31:59 -0400 Received: from mira.cbaines.net ([212.71.252.8]:37964) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lLSij-00084L-FZ for 47081@debbugs.gnu.org; Sun, 14 Mar 2021 11:31:58 -0400 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:8ac0:b4c7:f5c8:7caa]) by mira.cbaines.net (Postfix) with ESMTPSA id 9667227BC52; Sun, 14 Mar 2021 15:31:56 +0000 (GMT) Received: from capella (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 3eae187f; Sun, 14 Mar 2021 15:31:55 +0000 (UTC) References: <20210312005915.14100-1-lle-bout@zaclys.net> <20210312005915.14100-5-lle-bout@zaclys.net> <87ft0xg50b.fsf@cbaines.net> User-agent: mu4e 1.4.15; emacs 27.1 From: Christopher Baines In-reply-to: Date: Sun, 14 Mar 2021 15:31:52 +0000 Message-ID: <87czw1g39z.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1615735933; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=NiRqNYCTs+jBjXR/jYJYcF9/P9VIZQDtLiEXjlNM51M=; b=Lavu8P5TU0N9KK6eNaxj0Wq53KExZEg48OuNWdh8pOx+TQZdK4McKVgvhg53KCe9RHEpPd cTxLQGVNKyzsUmkvDlRyzzjAoc0am0C0wq0LK0jgi6+JhGHReIckI80zHFcYpoDvVgTD8l FDCIbcX6jNk+A1DTnpNorUFbUmAmqzTSUC5BoFlqarLEdU7wBua/UAfQfLQ7OeWimTMHyL bED6U5R1KXiI0DTPKvmd020Nb0cD0azesYOSP2GJisFOZmsc3H4vmITv4Vcq/Gy1l1HC+p u9Zsrcdb5BVnU095odx7roxI4kSeCqdRzq3WgaeL4VLqfyrcJ01hPRVSbIPBuQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1615735933; a=rsa-sha256; cv=none; b=Pcd0m5UQ6Td7iCeR5NDHgLdGQ+yboOFZLICY3Jd90nxhmo0iSxIsydaZZuK7aHcwMtELLU TFrZCV+7XDpi5uCeqigfeSN3eWRP/qKCzjVtSSrN1RbO955XXwvZjVqhhvkbulxGo1mg5Z Fay6ewIDNg3BXLYcsU3ye/0dGxIdHJHkJZ9dT4yRUZ5313LfdP9hLK+qXSncCJQJOlj9v8 fagnwK3Y+VT8NmLno+mdZmm6/yEKfkInaQDA+asL8Zfra4OtjU4iV7AC7Ej5JIw2q3BcDe QnkNhNCsb76IMZQb5iIjiVtqJJci06dK5+5GwB01oq6F48WJXh5a8jTcxL21kw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -4.50 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 8800013C5D X-Spam-Score: -4.50 X-Migadu-Scanner: scn0.migadu.com X-TUID: AmdlpcjkSrF8 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable L=C3=A9o Le Bouter writes: > On Sun, 2021-03-14 at 14:54 +0000, Christopher Baines wrote: >> I think it would be better to squash this commit in with the two >> previous commits, so there just one commit to remove the service, >> including the tests and documentation. That's a better "atomic" >> change, >> since all three bits (service itself, test and docs) are one thing in >> my >> opinion. > > Oh no, then all the individual commits and ordering work (so no single > commit breaks GNU Guix or makes it inconsistent) is useless now :-( I don't think there's going to be any problems with combining the commits I'm suggesting. Given they're contiguous, there's no chance of it breaking something, right? > I will try squashing ASAP, but what do you recommend as title then? It > seems to me this kind of violates GNU commit message guidelines. I'm no expert at writing commit messages in the Guix/GNU style, but maybe take a look at the commit that added the service [1]. I think "services: Remove MongoDB." would be a reasonable title. 1: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=3D5266ff719e274056= cb3e2b9740183f0063177255 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmBOLGhfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9Xc7eRAAhMcxHwZmmDT4ebxJ3y1gdvmalCKmwmV/ f3scXN4nJz92BL7mwWAwAlBk/VTT7bQPM+A1lk0Zyy7E+Z9x/B407GL0xJJDoN1Q DgVle+KHX4Tj0kRXoUm3vltHxf2qayvuFeUp2lMmb62goP8V+GTaIdREurSHRkQp pijHiCA+dYq39Ony4HDcX15yLw9W4Mo170suMxgPmd0j69304HK5j6nP783AAaVD qe3O1SRtwUbyQbEXfqYPeVLCEO3LxfwMi3EpcQfyWa8PktAYoEqP0FpztfhfFqfT cisC3Mz7JI/HjKca10hsoV5rZG4YX5ZhK7NFsJ1mzUbPAAwkK0BHUFGsKmU2ArPJ 3ZySOtb6pf8IPneViE1xJ9+ZFTS/TknJsrlGLXBG811yiWMqq+eCxYdXeWCKkP/6 Gf6pJjcTHipNjlLRpjJmF8aNIIEptFsuRm/lM5Y78vX1qkPnl+VaLBexOm8ujEuM FEj2PkCoA64T5p7NBnk5mCPj4sIu3H8YkEedDZVryz5tJAk0Bv4FQa/wxu0wq8ux e0IuyNvrpMsmDXoJrqHYDT5kwl0SuR8bYNFstKHtCEGOfRZrKaefXKmwzb7vYO1O 4uYmxw8wvRihKgKFbwo+i5kPEUCffoRwij4ujlp6ZdYAYdUlUFLVabGX/o/w9bqO 6Zu6zBrUC0I= =08x3 -----END PGP SIGNATURE----- --=-=-=--