From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id II3ZI2C8ZWDDiwAAgWs5BA (envelope-from ) for ; Thu, 01 Apr 2021 14:28:16 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id +JeiHWC8ZWB4aAAAbx9fmQ (envelope-from ) for ; Thu, 01 Apr 2021 12:28:16 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 34A6A1EAC5 for ; Thu, 1 Apr 2021 14:28:16 +0200 (CEST) Received: from localhost ([::1]:35850 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lRwQo-0001AM-Sv for larch@yhetil.org; Thu, 01 Apr 2021 08:28:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50646) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lRwQc-00018p-Ow for guix-patches@gnu.org; Thu, 01 Apr 2021 08:28:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:44988) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lRwQb-0002sb-TZ for guix-patches@gnu.org; Thu, 01 Apr 2021 08:28:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lRwQb-00009J-QC for guix-patches@gnu.org; Thu, 01 Apr 2021 08:28:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47459] [PATCH] gnu: Add brython. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 01 Apr 2021 12:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47459 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "jgart" Cc: 47459@debbugs.gnu.org, lle-bout@zaclys.net, rprior@protonmail.com, a.pierre@zaclys.net Received: via spool by 47459-submit@debbugs.gnu.org id=B47459.1617280041517 (code B ref 47459); Thu, 01 Apr 2021 12:28:01 +0000 Received: (at 47459) by debbugs.gnu.org; 1 Apr 2021 12:27:21 +0000 Received: from localhost ([127.0.0.1]:56534 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lRwPt-00008A-2c for submit@debbugs.gnu.org; Thu, 01 Apr 2021 08:27:21 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57474) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lRwPr-00007w-Nw for 47459@debbugs.gnu.org; Thu, 01 Apr 2021 08:27:16 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53410) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lRwPk-0002Lw-96; Thu, 01 Apr 2021 08:27:08 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=60650 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lRwPP-0003Qr-Vx; Thu, 01 Apr 2021 08:26:59 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <6c81552237809c87c157684e550a69a7@dismail.de> Date: Thu, 01 Apr 2021 14:26:46 +0200 In-Reply-To: <6c81552237809c87c157684e550a69a7@dismail.de> (jgart@dismail.de's message of "Mon, 29 Mar 2021 04:23:07 +0000") Message-ID: <87czve9omx.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1617280096; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=dhtCqT8knKBF0cRq1qfeRczsHVvVfv96KW/+zCWjVsM=; b=QX/qpGBHhhGSxu2r/1/Np+uu006iKMFf0puPI9IzesrZgTv4SC36xVAlPlvCqETZ11+4uI u7vLh5gcN4DBExYSxJGQPG2Nfu3I53KHNNwmqUV5jHgUj79DA7VlCbp6jhMoKS9uoxy3Fd lNMbOeANr1KD3rzT/mlJ+S7oWaZcGtyt00h5aN9SSIGya7Fe5IPq5hdOAWJ58wL61dewhs /B7v3FiAf7sLW1L+x/lGfBzXhk5ubWBAcdLAEpe0xqmcLLNUbErymbtIrEZLBDfQwoY20p gVdCIF44SCHcs70PyTJfn6XDMDbFYVOy9x7AOF6h3zt3Jo7VEXfc5PeLXLOuvQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1617280096; a=rsa-sha256; cv=none; b=g2aYt6p55DjjJhazLBDLe4p0v191dnDZX2NkJHMsgp97+dQm/aYJyZGmNvwVrptRAuF7Xx TcXG4Nuw8x4WozpUZvFL57dhIvXzWHRJkED52FAu4lzp6ldciLrdvy0pzR/JXQgcJVX00v Ntd1locy3dVEY9HKd9+8R3vgWSuwbJiw19E5lWRyy2FOdkN7ya/PbkXCdzW1uq4QN9WiMD EP/DD3RavUdCgcZfBeJj0mYB31BBnu8cvi9rtPi6A4WsfQ9acwixtO33APw8E3n167XKDf pAEe4D3ZOoXJCULk5ncyLc54PoGjdxOnX4izVv68zHNsa8ZzsJd/HRAMKf1B1Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.93 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 34A6A1EAC5 X-Spam-Score: -2.93 X-Migadu-Scanner: scn0.migadu.com X-TUID: /7S6C45gMNnY Hi, "jgart" skribis: > This was an effort of today's Guix Packaging Meetup. Nice! > From 519c8d5e5369744cadbe4bc7607b0c4c8f05128a Mon Sep 17 00:00:00 2001 > From: LibreMiami > Date: Sun, 28 Mar 2021 21:13:31 -0400 > Subject: [PATCH 2/2] gnu: Add brython. > MIME-Version: 1.0 > Content-Type: text/plain; charset=3DUTF-8 > Content-Transfer-Encoding: 8bit > > * gnu/packages/web.scm (brython): New variable. > > Co-authored-by: L=C3=A9o Le Bouter > Co-authored-by: jgart > Co-authored-by: Ryan Prior > Co-authored-by: Andrea Pierr=C3=A9 [...] > + (native-inputs > + `(; 'install phase needs the python command > + ("python" ,((package-input-rewriting > + `((,python . ,python-3.9)) > + #:deep? #f) python-wrapper)))) That=E2=80=99s likely to perform very poorly. Normally, you=E2=80=99d save= the result of =E2=80=98package-input-rewriting=E2=80=99 (a procedure) in a variable an= d reuse it anytime you need to make that transformation, so that caching can kick in. > + (arguments > + `(#:python ,python-3.9 ; required during build In current =E2=80=98master=E2=80=99, all Python 3.x package are built again= st 3.8. I think we should stick to that and not introduce different dependencies as this can only lead to bad surprises. Can Brython be built against 3.8? If not, I think it=E2=80=99ll have to go= to the =E2=80=98core-updates=E2=80=99 branch, which may be merged soon after t= he release (end of April). WDYT? > + (lambda* (#:key outputs #:allow-other-keys) > + ;; write access is required to .js files for minifying Nitpick: Please capitalize sentences and end with a period (here and elsewhere). > + (for-each > + (lambda (vv) (chmod vv #o644)) Use =E2=80=98make-file-writable=E2=80=99 instead of this lambda. > + (invoke "python3" "scripts/make_dist.py") > + #t)) No need for the trailing #t. > + (synopsis > + "Run python code in a web browser") This can be on a single line. > + (description > + "@code{Brython} is a compliant implementation of Python 3 that all= ows You can remove @code here (@code is only used for inline code snippets and similar things). Thanks! Ludo=E2=80=99.