unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: "jgart" <jgart@dismail.de>
Cc: 47459@debbugs.gnu.org, lle-bout@zaclys.net,
	rprior@protonmail.com, a.pierre@zaclys.net
Subject: [bug#47459] [PATCH] gnu: Add brython.
Date: Thu, 01 Apr 2021 14:26:46 +0200	[thread overview]
Message-ID: <87czve9omx.fsf@gnu.org> (raw)
In-Reply-To: <6c81552237809c87c157684e550a69a7@dismail.de> (jgart@dismail.de's message of "Mon, 29 Mar 2021 04:23:07 +0000")

Hi,

"jgart" <jgart@dismail.de> skribis:

> This was an effort of today's Guix Packaging Meetup.

Nice!

> From 519c8d5e5369744cadbe4bc7607b0c4c8f05128a Mon Sep 17 00:00:00 2001
> From: LibreMiami <packaging-guix@libremiami.org>
> Date: Sun, 28 Mar 2021 21:13:31 -0400
> Subject: [PATCH 2/2] gnu: Add brython.
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> * gnu/packages/web.scm (brython): New variable.
>
> Co-authored-by: Léo Le Bouter <lle-bout@zaclys.net>
> Co-authored-by: jgart <jgart@dismail.de>
> Co-authored-by: Ryan Prior <rprior@protonmail.com>
> Co-authored-by: Andrea Pierré <a.pierre@zaclys.net>

[...]

> +    (native-inputs
> +     `(; 'install phase needs the python command
> +       ("python" ,((package-input-rewriting
> +                    `((,python . ,python-3.9))
> +                    #:deep? #f) python-wrapper))))

That’s likely to perform very poorly.  Normally, you’d save the result
of ‘package-input-rewriting’ (a procedure) in a variable and reuse it
anytime you need to make that transformation, so that caching can kick
in.

> +    (arguments
> +     `(#:python ,python-3.9 ; required during build

In current ‘master’, all Python 3.x package are built against 3.8.  I
think we should stick to that and not introduce different dependencies
as this can only lead to bad surprises.

Can Brython be built against 3.8?  If not, I think it’ll have to go to
the ‘core-updates’ branch, which may be merged soon after the release
(end of April).

WDYT?

> +           (lambda* (#:key outputs #:allow-other-keys)
> +             ;; write access is required to .js files for minifying

Nitpick: Please capitalize sentences and end with a period (here and
elsewhere).

> +             (for-each
> +              (lambda (vv) (chmod vv #o644))

Use ‘make-file-writable’ instead of this lambda.

> +             (invoke "python3" "scripts/make_dist.py")
> +             #t))

No need for the trailing #t.

> +    (synopsis
> +      "Run python code in a web browser")

This can be on a single line.

> +    (description
> +      "@code{Brython} is a compliant implementation of Python 3 that allows

You can remove @code here (@code is only used for inline code snippets
and similar things).

Thanks!

Ludo’.




  reply	other threads:[~2021-04-01 12:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-29  4:23 [bug#47459] [PATCH] gnu: Add brython jgart via Guix-patches via
2021-04-01 12:26 ` Ludovic Courtès [this message]
2021-07-05 19:48 ` [bug#47459] [PATCH] * gnu/packages/web.scm (brython): New variable jgart via Guix-patches via
2021-07-05 22:29 ` [bug#47459] brython bump to 3.9.5 and fixes for core-updates branch jgart via Guix-patches via
2022-06-22 19:23   ` [bug#47459] [PATCH] gnu: Add brython Maxim Cournoyer
2022-09-28 18:24     ` bug#47459: " Maxim Cournoyer
2022-09-28 20:36       ` [bug#47459] " Ricardo Wurmus
2022-09-28 20:41         ` Ricardo Wurmus
2022-09-29  1:28           ` Maxim Cournoyer
2022-09-28 20:38       ` jgart via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87czve9omx.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=47459@debbugs.gnu.org \
    --cc=a.pierre@zaclys.net \
    --cc=jgart@dismail.de \
    --cc=lle-bout@zaclys.net \
    --cc=rprior@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).