From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id mDJyCaXdZWDP0gAAgWs5BA (envelope-from ) for ; Thu, 01 Apr 2021 16:50:13 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id CNBWA6XdZWBFbAAAB5/wlQ (envelope-from ) for ; Thu, 01 Apr 2021 14:50:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B936F1D12B for ; Thu, 1 Apr 2021 16:50:12 +0200 (CEST) Received: from localhost ([::1]:48430 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lRyeB-0007FW-KT for larch@yhetil.org; Thu, 01 Apr 2021 10:50:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36694) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lRye3-0007ED-CI for guix-patches@gnu.org; Thu, 01 Apr 2021 10:50:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46700) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lRye3-0002Xr-4n for guix-patches@gnu.org; Thu, 01 Apr 2021 10:50:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lRye3-0002HR-2H for guix-patches@gnu.org; Thu, 01 Apr 2021 10:50:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47539] [PATCH 00/28] Add gh and dependencies Resent-From: Xinglu Chen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 01 Apr 2021 14:50:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47539 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Prikler , 47539@debbugs.gnu.org Received: via spool by 47539-submit@debbugs.gnu.org id=B47539.16172885758684 (code B ref 47539); Thu, 01 Apr 2021 14:50:03 +0000 Received: (at 47539) by debbugs.gnu.org; 1 Apr 2021 14:49:35 +0000 Received: from localhost ([127.0.0.1]:58235 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lRyda-0002G0-N8 for submit@debbugs.gnu.org; Thu, 01 Apr 2021 10:49:34 -0400 Received: from h87-96-130-155.cust.a3fiber.se ([87.96.130.155]:34490 helo=mail.yoctocell.xyz) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lRydY-0002Fl-VK for 47539@debbugs.gnu.org; Thu, 01 Apr 2021 10:49:33 -0400 From: Xinglu Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz; s=mail; t=1617288564; bh=XJikYa0FB5YYYQgbIgx63IYeDV/Ol33jZoRODUXhlXI=; h=From:To:Subject:In-Reply-To:References:Date; b=ha4WoTfd4StXbWooYNyKI4+bENhGiRWYn8z9QXInwGuuzUo/57f7CJI/7vW2BSF66 7J0eBx4uWSNGXaXzgWe7KiOKgP8zyaeW0fe+obklGImOwN0O63qBs/FxowEjLXiTiY sD4tdkyppAM9qcynWicDxFLdFU8yQrw/b+jOKPZE= In-Reply-To: <7f41ded1648030ed8f4db3165bfe4ccb2cb6b2a9.camel@student.tugraz.at> References: <7f41ded1648030ed8f4db3165bfe4ccb2cb6b2a9.camel@student.tugraz.at> Date: Thu, 01 Apr 2021 16:49:23 +0200 Message-ID: <87czve3vrg.fsf@yoctocell.xyz> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1617288612; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=7vSwelOTJhTIE50/lZra9m8GY+BRwNhyWJncnQParAY=; b=S1QvXcTrwY8sqmASP5o5vzyrTfGrHJScrIfov+QSCCnqWJgvvmxTS+1ljm8MmdzZOJJrpo fz09Pum9cWjpr2Po17XZ88f9Ir0UJolPTnPhsOThOkKipEEj/6lmXRADQGvBLGFKh1JgYj 3QMZCw4KK9eXo4bhV6k9i/vF5OP0/sLHFgfvlT/+/QBO4dks67HdnslZCUbfH8FmJPmg5M sczOwzRgQHLhs7smK+CaX+PTkGE7UeEwdXsbPnBaXEpaViINVCTtigjIETGLQm33ROPoJy 6v29CqPozDuOZRHVZgtROLD+lOCQHQQNtumDLpdUepY1AGDqQ4/2SZBvLQ8nQQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1617288612; a=rsa-sha256; cv=none; b=fk4gmU2MPMR+UPa5lKbr5CxknhDrzSjddcB1k+mPy7U69jN5pI6IWMNg+2P1n8pMCxH+BX E6TnXtt7vEcw4g7l1pS87JewR6TyFfYffNQ4iN8PVz1qkvbIDZFyq6Dq4SwGeEO8LsvhTr /q3nqAm9iTdF2O/iLYfphDjnxOQomOAh7tKdlqPsyThXHeWZcqwMBVdCrnn5nob/wuV8or PaSDy+6WcyNW4ZyhFm96zbHy1mjK2+Q2ItpgL5lte3STrYRKPLWoP9ugsdV/EJXh+SqxKC xtQxtCDVKto2bwnDDPp0vrhh+g31rA9nS7s4MlyAbc5x/bjnP4IoHtM79KFJgA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=yoctocell.xyz header.s=mail header.b=ha4WoTfd; dmarc=fail reason="SPF not aligned (relaxed)" header.from=yoctocell.xyz (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.33 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=yoctocell.xyz header.s=mail header.b=ha4WoTfd; dmarc=fail reason="SPF not aligned (relaxed)" header.from=yoctocell.xyz (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: B936F1D12B X-Spam-Score: -1.33 X-Migadu-Scanner: scn0.migadu.com X-TUID: Ov1Q0mOQBHbi On Thu, Apr 01 2021, Leo Prikler wrote: > Hi, > > Am Donnerstag, den 01.04.2021, 09:51 +0200 schrieb Xinglu Chen: >> This patchset adds the 'gh' package, a CLI interface to GitHub. The >> Go importer did most of the work. :) > I am not experienced with Go, so I can't comment on the rest too much, > but I wanted to point out, that single, double and triple letter > packages are (imo rightly) frowned upon in the Guix project. > Considering, that this is the *official* Github CLI tool, a name like > "github-cli" would probably make more sense here. Oh yeah, I saw the thread on guix-devel, I should have thought of this. >> - When building'gh', I couldn't get >> 'go-github-com-charmbracelet-glamour' to build without moving some >> native-inputs to propagated-inputs, though, if I was only building >> 'go-github-com-charmbracelet-glamour' it would build without moving >> things to propagated-inputs. I am not sure why this happens. > Perhaps you need to add those native inputs as native inputs to gh as > well? Try adding its native inputs to gh and see whether that changes > something. I will try and report back. >> - The patch marked with 'D' adds a package which has been deprecated >> by upstream, but it is still needed by one of the packages that 'gh' >> depend on. I have marked it as a hidden package, let me know if this >> is the right decision. > Yes, we do so for other packages as well, that require outdated or > otherwise modified versions, that should not show up in user profiles > unless they really, really want to and use manifests to achieve their > goals. Good to know, I will have to mark 'go-github-com-cli-shurcool-graphql' as hidden as well since it's GitHubs' fork of 'go-github-com-shurcool-graphql' and most likely only used by 'gh'. >> - The patch marked with 'W' adds a package which is needed by 'gh', >> but only used on Windows. It is still Free Software (BSD-2), but I >> have also marked it as hidden. > This is at least in some sense an acceptable workaround, but how large > would the effort be to outright drop references to this package, given > that it's already not "actively" being used? I am not familiar with the Go ecosystem so I don't know if this will be possible, but I will look into it. Thank you for the rewiew!