From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 8EYWHN+qtmAgKAEAgWs5BA (envelope-from ) for ; Tue, 01 Jun 2021 23:47:11 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id SKM+F9+qtmB8MgAAB5/wlQ (envelope-from ) for ; Tue, 01 Jun 2021 21:47:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2233F25DD2 for ; Tue, 1 Jun 2021 23:47:11 +0200 (CEST) Received: from localhost ([::1]:43254 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1loCEA-0001gZ-3H for larch@yhetil.org; Tue, 01 Jun 2021 17:47:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33782) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loCE2-0001dO-LP for guix-patches@gnu.org; Tue, 01 Jun 2021 17:47:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54780) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1loCE2-0004Kd-EA for guix-patches@gnu.org; Tue, 01 Jun 2021 17:47:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1loCE2-0002uq-Ao for guix-patches@gnu.org; Tue, 01 Jun 2021 17:47:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47768] [PATCH v3 00/42] Assorted OCaml patches Resent-From: Xinglu Chen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 01 Jun 2021 21:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47768 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: pukkamustard Cc: pukkamustard , divoplade , 47768@debbugs.gnu.org, Maxime Devos , Erik Received: via spool by 47768-submit@debbugs.gnu.org id=B47768.162258400711185 (code B ref 47768); Tue, 01 Jun 2021 21:47:02 +0000 Received: (at 47768) by debbugs.gnu.org; 1 Jun 2021 21:46:47 +0000 Received: from localhost ([127.0.0.1]:38093 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1loCDn-0002uL-00 for submit@debbugs.gnu.org; Tue, 01 Jun 2021 17:46:47 -0400 Received: from h87-96-130-155.cust.a3fiber.se ([87.96.130.155]:56790 helo=mail.yoctocell.xyz) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1loCDl-0002u6-9z for 47768@debbugs.gnu.org; Tue, 01 Jun 2021 17:46:46 -0400 From: Xinglu Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz; s=mail; t=1622583997; bh=Rsqlm4NIHhR2ycSsVhXfoxC62RRBNUqYwUXRfLZGxV4=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=a9wwkLQvOt14URFpu+w4py6zbrnIEiCTnt1xr42IjyIGQ3wvA66iBMKajddcyCBV6 FMlmQC5MNLCRPrlbbBmipJjXR4oaSqBsEd8m0Y4efllqmt3bbvCRb7GRg2xiw4OjTa kka4wAV9eM5K/5u7kQCJ1dCvF72rPdJ+6sT3F+OQ= In-Reply-To: <20210601202203.8587-1-pukkamustard@posteo.net> References: <87lf82hasx.fsf@yoctocell.xyz> <20210601202203.8587-1-pukkamustard@posteo.net> Date: Tue, 01 Jun 2021 23:46:36 +0200 Message-ID: <87czt5xnpf.fsf@yoctocell.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1622584031; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=Rsqlm4NIHhR2ycSsVhXfoxC62RRBNUqYwUXRfLZGxV4=; b=qGbby99sy78nC+Xn7jKRgT1E97IWARSqtn2N7bpISp2lbI18qBjQJdLOEkxwE9GOsXwEo4 7i93Y3z2NKHGzrJ1cKdsT6zH8XAa46TUQzUNQ20urHY17gPsNqJPHi/8dmbSqULAh8sl5q oXfCUpN/YF5yEooc8H6Yre6liuVg0gcrW/Cu7+D6DQ2K38AAmIhmHN+59zndu8QBRCnnTx GLbZnfBSPb4gza15bhlKUMecSmUkmQiNmzfDXTukloUBPS6dLGxdt65gUMQU3j3K3CDvLO d0jrj69dbO4qaCYCclQgGa5nzsb3sMynwb+F5icHpESqPx89eEWk+Jnb6QT0yg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1622584031; a=rsa-sha256; cv=none; b=rhRiBRPBDaKkZCAEiSGMtwpxVPpFhZsW9npyShELKgSl5WuKrz7f4yhLDdrF4N7XxCcI86 xZU4oXwvANviilYklZh/dUqUkhTzMPaNPFRVZdegQ8qhiJa/vo6n+RLljD8PCZE9dia3Fh +R0mo6YWmQX8Orfg3P4HoTTHgUof2n4noDiDnncQi6kLH1zezl6v95ENMSsbkqbXxssudU OmdrJPJzD3YGg4zw4KWR5vZmC2vxCBdXijtC+ev59nd6XD4sIuhkluZZ0hlOtj/hCrusIN AbdQPFiZTmn0voG71AcgJFliu/BKISqnIVtivWQP3whrG9hk1YREMSMpW0+O/g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=yoctocell.xyz header.s=mail header.b=a9wwkLQv; dmarc=fail reason="SPF not aligned (relaxed)" header.from=yoctocell.xyz (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.43 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=yoctocell.xyz header.s=mail header.b=a9wwkLQv; dmarc=fail reason="SPF not aligned (relaxed)" header.from=yoctocell.xyz (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 2233F25DD2 X-Spam-Score: -3.43 X-Migadu-Scanner: scn0.migadu.com X-TUID: E0zFr+7+GNO7 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Tue, Jun 01 2021, pukkamustard wrote: > Hi, > > Xinglu Chen writes: > >> All the packages build fine, but I haven=E2=80=99t tested anything. > > Thanks for the review! You are welcome! > It follows a V3 with the two changes you suggested (add tests for > ocaml-uunf and merge patches 10 and 11 of V2). The changes look good to me, and =E2=80=98ocaml-uunf=E2=80=99 builds fine. > Erik has tested some of the packages and reports that everything seems > to be fine. > >> LGTM! > > Maybe we are good to merge now? No objections from me, but I don=E2=80=99t have commit access. :( Thank you and divoplade for the work! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEAVhh4yyK5+SEykIzrPUJmaL7XHkFAmC2qrwVHHB1YmxpY0B5 b2N0b2NlbGwueHl6AAoJEKz1CZmi+1x5PewP/027YlqTDbkc0KPPn55iYOehvlxT gZ2sNq2iqbJF0mmm2HeEcSCL5lJtYLOgQfvL5CwYjP+bSaCUHlGZYsE+DGK+WYM1 iDl56pPJKe210Lnl4fAANXGXCXo1m6FeH1pIfTW5oKGN+Ztbi82dBAOh8dKU97se pkIbNsd+dmXZkh/0VltvOKClLam62rvtBM5zqXU9Y52m9L/zUDgg9ZRcwgVyuH76 7/f1gCSDXaNKra6P/ll3OU0VYBikMxvz72MJ4qUxeNQikWdcmMInm6oyj08b06XW /BskNmPVo3t3ZhHecIZniiU7LSsGMLI6dSBJopD9doF7PMo6SH/7HriW5USBtaZK pH9OmnwSmNIdlVp6FSfzVH1M7zUkhsBqbFxd6ELzoV2GKn52KhcVdD6jl+DsZ8eP yIgiqxz0e9DaeTG5SALarc3aYRjFbmvZfXFaO11pt5+umxsrv5NwHqia2zvGbmKL 7vrkUUvae/SmwUVoTQg/YnAYw5YxRhGILT/RpKhcgO7bWi+rfwtqCpG6cqE6nAB2 quX0v6Mdq2+S1GHTU3otgR6QFfuuzStSz4yhtLucK4PHc5BPNQ99zvty3mpfAo+k alg2bdhuHKd+gRjT/Sc5bf43JHCCBY9lapdt218/XjxsJXnSUYKxcYHiy0vFUbQ2 yCMIbFgqNezIHRni =Np9A -----END PGP SIGNATURE----- --=-=-=--