From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id DtfvL113WGFDLwEAgWs5BA (envelope-from ) for ; Sat, 02 Oct 2021 17:14:37 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id OODfKl13WGFGbgAAB5/wlQ (envelope-from ) for ; Sat, 02 Oct 2021 15:14:37 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 86F872E851 for ; Sat, 2 Oct 2021 17:14:37 +0200 (CEST) Received: from localhost ([::1]:50446 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mWgii-0003Re-ME for larch@yhetil.org; Sat, 02 Oct 2021 11:14:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54408) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mWgiA-0002bR-0m for guix-patches@gnu.org; Sat, 02 Oct 2021 11:14:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:48724) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mWgi9-0007CL-Nk for guix-patches@gnu.org; Sat, 02 Oct 2021 11:14:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mWgi9-0005vW-JO for guix-patches@gnu.org; Sat, 02 Oct 2021 11:14:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50873] [PATCH 0/5] Fixes to =?UTF-8?Q?=E2=80=98guix?= home =?UTF-8?Q?import=E2=80=99?= Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 02 Oct 2021 15:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50873 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Xinglu Chen Cc: 50873@debbugs.gnu.org, Andrew Tropin Received: via spool by 50873-submit@debbugs.gnu.org id=B50873.163318759522717 (code B ref 50873); Sat, 02 Oct 2021 15:14:01 +0000 Received: (at 50873) by debbugs.gnu.org; 2 Oct 2021 15:13:15 +0000 Received: from localhost ([127.0.0.1]:60270 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mWghP-0005uJ-6q for submit@debbugs.gnu.org; Sat, 02 Oct 2021 11:13:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49148) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mWghN-0005u7-2L for 50873@debbugs.gnu.org; Sat, 02 Oct 2021 11:13:13 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54970) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mWghH-0006TN-Be; Sat, 02 Oct 2021 11:13:07 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=36494 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mWghH-0000bo-2Q; Sat, 02 Oct 2021 11:13:07 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: Date: Sat, 02 Oct 2021 17:13:05 +0200 In-Reply-To: (Xinglu Chen's message of "Tue, 28 Sep 2021 19:33:09 +0200") Message-ID: <87czonwjcu.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1633187677; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=yktR6McEfB7R1rKjPRzMlAEJShtvAqhxEvSnTDr3WNg=; b=JdW7nHewaoy4IUyInM9CAAdosViGS596xz/EOjw20uIU1jMIWUftyQkCo7jF5oju20KDfg eAeE9A94gwVgIR8bf3d3WJrprCEXult5x8s3JdZt4CIhRzdmkH+TosiAtWwFg0IoOHwxc5 ea4SVehKnUTz3sxKWdn+fDSFF0gHuYbE/SvFECUnWmaFahctG0GTrV33B+UPpnGkRgdkuP +nkm46GVlbo8SxJ+RcZpgL6uidBCVrzlDGnvt3A34o8wefn3xTr88FQCXjtviQ9CXaA5Oo JD9JTcJvoW8k8pqrq+UkZv+50hpIUYnHdAAFqaaCjVzjCOnmPMzJBtIpHFNQmQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1633187677; a=rsa-sha256; cv=none; b=N28Nb66OseUxWtb1oE2cDNpZYFnuHDxJfjOsfl16LdsEw/IvgbjV9caV8QJx+53hZM4ZGr LY4xN74/VylDZG8YQ4OBU0arQKM47kMRm54mcjz5N11Cr5M2rHXEVEpen+6K6+YS8ck5Wy TVWjWTSl6tWBhjv0r9YDQ97cuhhuWi1OP5dkui7ADACUj1RsuvWNdK09yKMv2VnhJIi9Ku K5/Zb/QJKsYubw7R4dgoK27OB//g1lxfSD7pVy9cbmwXJ/iaVepUjaRPpSHNPyAJ8h76nD JW6d10HSQHJAipJ+7NwFQIfEno1Y7+d3KYTVnxTEICW8nAwHy5zm/uG3wmPwxg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.90 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 86F872E851 X-Spam-Score: -2.90 X-Migadu-Scanner: scn0.migadu.com X-TUID: pyJmqza4gAJs Xinglu Chen skribis: > This series makes some fixes to the =E2=80=98guix home import=E2=80=99 su= bcommand which > brings it into a usable state. > > The last patch documents the subcommand in the manual. > > As a sidenote, the =E2=80=98manifest->code=E2=80=99 procedure in (guix sc= ripts home > import), which is based on =E2=80=98manifest->code=E2=80=99 from (guix pr= ofiles) should > probably be factorized with the original =E2=80=98manifest->code=E2=80=99= procedure. > > Xinglu Chen (5): > guix home: import: Make the user to specify a destination directory. > guix home: import: Allow multiple modules to be imported for each > service. > guix home: import: Fix module name for Bash service. > guix home: import: Delete duplicate modules when importing. > doc: Document the =E2=80=98guix home import=E2=80=99 subcommand. Could you (Xinglu, Andrew, Oleg?) add tests for this? I think Scheme-level tests like we have for the =E2=80=98guix import=E2=80=99 code = would be fine. It would also help review because it=E2=80=99d give a clearer view o= f how this is supposed to work. Thanks for following up on this! Ludo=E2=80=99.