From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id KIsQMp1rl2GHKgEAgWs5BA (envelope-from ) for ; Fri, 19 Nov 2021 10:17:17 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id OMypLZ1rl2EqQwAAbx9fmQ (envelope-from ) for ; Fri, 19 Nov 2021 09:17:17 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8B0721791E for ; Fri, 19 Nov 2021 10:17:17 +0100 (CET) Received: from localhost ([::1]:58788 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mo01D-0005Ax-G3 for larch@yhetil.org; Fri, 19 Nov 2021 04:17:15 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35238) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mo011-00055v-KS for guix-patches@gnu.org; Fri, 19 Nov 2021 04:17:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:54692) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mo011-0002cC-7D for guix-patches@gnu.org; Fri, 19 Nov 2021 04:17:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mo011-00082l-3R for guix-patches@gnu.org; Fri, 19 Nov 2021 04:17:03 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51091] [PATCH v3] guix: opam: Do not fail when refreshing. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 19 Nov 2021 09:17:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51091 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Julien Lepiller Cc: 51091@debbugs.gnu.org, Xinglu Chen Received: via spool by 51091-submit@debbugs.gnu.org id=B51091.163731340630838 (code B ref 51091); Fri, 19 Nov 2021 09:17:03 +0000 Received: (at 51091) by debbugs.gnu.org; 19 Nov 2021 09:16:46 +0000 Received: from localhost ([127.0.0.1]:37994 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mo00k-00081K-6x for submit@debbugs.gnu.org; Fri, 19 Nov 2021 04:16:46 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34350) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mo00h-000816-QN for 51091@debbugs.gnu.org; Fri, 19 Nov 2021 04:16:44 -0500 Received: from [2001:470:142:3::e] (port=56312 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mo00a-0002Xi-Ld; Fri, 19 Nov 2021 04:16:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=9Xr36W18mSBMJJy+6k3/4V18vDwanwAFHzI4T7Z6Qvk=; b=o3KChPK/M4Ej2bGIkqgD Dc/jtME3vq9e+bcv9Dm2XSVg3RITuHZIfyZgzYD+B7dHnn6BEa8iYsx5UfwcgU2jv/noEHtplkF+g rWzT0HL83C5WPLebKdOhuzDj3vgf8fv4uOUg/hracmS4OlWeIQPxmPpL9ekUO5VSkopeUmTvoGi3E iAITsns++O+v9ZRqxDxGpWYSdIGOtz5/O4QCVHMenwQd6cPCoAjXY1Vz5XokJoBPrsQILfBz+4Hh5 AFXvNNWhJjBdPyktWIkoNsKX5SWb7aMVpMzI7aV0ofPctLJbza1PRIFJIWPIzABDKwOWYOFEKTqG5 ovp2pZIIOMK0Kw==; Received: from [193.50.110.190] (port=37472 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mo00Z-0002PT-2j; Fri, 19 Nov 2021 04:16:36 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20211008050310.407d6b23@tachikoma.lepiller.eu> <87y272lepg.fsf@yoctocell.xyz> <871r4nrc9t.fsf_-_@gnu.org> <20211016041009.5b4ddff0@tachikoma.lepiller.eu> <87sfwybuc7.fsf@gnu.org> <20211119021646.03e85542@tachikoma.lepiller.eu> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 29 Brumaire an 230 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 19 Nov 2021 10:16:32 +0100 In-Reply-To: <20211119021646.03e85542@tachikoma.lepiller.eu> (Julien Lepiller's message of "Fri, 19 Nov 2021 02:16:46 +0100") Message-ID: <87czmwo68f.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637313437; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=9Xr36W18mSBMJJy+6k3/4V18vDwanwAFHzI4T7Z6Qvk=; b=ewKVoyM4qjY17QBEGq02xLoHlPGorX++Nmqwqfx3Qk0iIo2JqyG9i1JPo4SdSKmxxwzp/v bxAnXBlRNfQ7HncLnLCaj4HAmptFn9A9FAXB5LOhFuaVSsir5c0v3e5k3Rn6VLdiqY5nDD 4EtMT6UEbYJIweD5oWWum/793M51FhDPvIwfJ0UQMzBpKrf/pRjC9i9DeCGuGIY6Xl1gvR TV80XIy8NIZupMUWmK+h5HhAWpMs6C8y7xPf5UmvluW8f/HnklQXbdaSRU9LXFM/TF/qA9 HBrlAk0X06h4LGTCutFIxIcnIzZ1hMUVrdPqbzISvLMvUKoyNOUlCBRcPp6f2A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637313437; a=rsa-sha256; cv=none; b=o6oXM7LPxdAwWSwN0bkU4YphA/koQHAoRf3rGhUOJJYc6tGKf8XG/m+bhhou8xnWiQPDoH FvD7KI9fiFWmlb/8uNzTvGQxmD9CAZlqGBXIamllYH6kP3RjiNpacyrJRZlah9RzPeqa2Y 7mlxy+bEb2bV1vFXXmuyE7Tn/7W5UwA1u9rP5WMVsgOhPQShmcU+nJc5xWPjhe7JsDHhHK Wj88oCpHrhjswOp06FeF/gHUIgjmaAvr8rbg2ZlZRXE2/SB972j15APT1d8X+fxcFO/Ewt HZp7KKn2VTpvVL3W8mHGbCUg3X+AP5Ctv6sSGJcyL2UVZmNW5bR255p5caJuiA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="o3KChPK/"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.56 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="o3KChPK/"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 8B0721791E X-Spam-Score: -3.56 X-Migadu-Scanner: scn1.migadu.com X-TUID: /c1XH5ogC+n/ Hi, Julien Lepiller skribis: > I forgot to remove the catch #t around the whole body of the function. > I noticed that guard* was raising &non-continuable so I tried to fix it > by using raise-continuable from (ice-9 exceptions). Is this the correct > solution? I suppose, though I=E2=80=99m not sure why it needs to be continuable: you = could just catch the exception and move on to the next package? > From a60e2ca645f4f8a6da72111d047f8cbb41ebe3e6 Mon Sep 17 00:00:00 2001 > Message-Id: > From: Julien Lepiller > Date: Fri, 8 Oct 2021 04:58:27 +0200 > Subject: [PATCH] import: opam: Do not fail when refreshing. > > Because we throw an error when a package is not in the opam repository, > the updater would crash when encountering a package that is not in opam > but uses the ocaml-build-system, such as opam itself. This catches the > error and continues without updating said package, and lets us update > the rest of the packages. > > * guix/scripts/import/opam.scm (guix-import-opam): Catch not-found > condition and leave. > * guix/import/opam.scm (&opam-not-found-error): New condition type. > (opam-fetch): Raise condition instead of leaving. > (latest-release): Catch not-found condition and warn. > (conditional): Rename from `condition'. > * tests/opam.scm (parse-conditions): Change accordingly. [...] zimoun skribis: > I think is simpler and fix the same th= ing. I=E2=80=99m fine either way. I think there=E2=80=99s value longer-term in = having structured exceptions in importers, though. Julien: your call! Thanks, Ludo=E2=80=99.