From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id mPDzCnKktGF6VQAAgWs5BA (envelope-from ) for ; Sat, 11 Dec 2021 14:15:30 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id WDq8BnKktGG+XAAAB5/wlQ (envelope-from ) for ; Sat, 11 Dec 2021 13:15:30 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E12972FAB6 for ; Sat, 11 Dec 2021 14:15:29 +0100 (CET) Received: from localhost ([::1]:41724 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mw2Dp-0000v0-3P for larch@yhetil.org; Sat, 11 Dec 2021 08:15:29 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39264) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mw2DP-0000ua-4q for guix-patches@gnu.org; Sat, 11 Dec 2021 08:15:05 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:37221) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mw2DO-0003FT-9q for guix-patches@gnu.org; Sat, 11 Dec 2021 08:15:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mw2DO-0004jp-22 for guix-patches@gnu.org; Sat, 11 Dec 2021 08:15:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#52387] [PATCH] Add cl-april. Resent-From: Guillaume Le Vaillant Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 11 Dec 2021 13:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52387 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jacob MacDonald Cc: 52387@debbugs.gnu.org Received: via spool by 52387-submit@debbugs.gnu.org id=B52387.163922847118154 (code B ref 52387); Sat, 11 Dec 2021 13:15:02 +0000 Received: (at 52387) by debbugs.gnu.org; 11 Dec 2021 13:14:31 +0000 Received: from localhost ([127.0.0.1]:48767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mw2Ct-0004ik-AE for submit@debbugs.gnu.org; Sat, 11 Dec 2021 08:14:31 -0500 Received: from mout01.posteo.de ([185.67.36.65]:53091) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mw2Cq-0004iV-96 for 52387@debbugs.gnu.org; Sat, 11 Dec 2021 08:14:30 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 4C139240028 for <52387@debbugs.gnu.org>; Sat, 11 Dec 2021 14:14:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1639228462; bh=nCQRfMxnMEUAhqKPjB9GTfl4bl0K1PwBQMqwzjZ1b+E=; h=From:To:Cc:Subject:Date:From; b=JcLGwZdRW2gXjabVzFOqIcFvJlaHRrtKcXTiwPqgmt0FUCZd8fCHOibxSS1DMYNN9 qWN4HRxzEBoaPZo5TF/RsaLkaxre9L4Lkf3Z7YdpRkBtg0kfRVSDC3KN//JOJnK5QM DxzOBH3tBg1Ef297thZg8N/l44m4PM67T2sKhADAKCIY/yxr033WWpTd5th0G/F3qn 3MGyfMoc5HiyLJA0PKG/ebyd5H028s8ageaotqGOUdXP2U0O0ipyRerG+JnBz4A4Is 3RtqkzV3254h2Twc2wzaBDxYJPmMY0VfoyaHmCMSZ4i0aD5fvzIVQf2Hbhgxxx3eNC 9G0kJJWRdQ1Vw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4JB7XF2Wvdz6tm4; Sat, 11 Dec 2021 14:14:21 +0100 (CET) References: From: Guillaume Le Vaillant Date: Sat, 11 Dec 2021 12:38:07 +0000 In-reply-to: Message-ID: <87czm3thar.fsf@kitej> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1639228529; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=aqvnWi3v0zuaxeVDoXxieFbGwjcZnqef4H25N5LptkQ=; b=Hp4BEJ3d7MLsIlyxywy9oFZ7bopozC2/XgMHzQPld56nyT0Vhi28NFemOvJs0XueVqRVyt M3jTgznWQpvkknz+scwCwqNodwJtl5rKgsf3LKq79iZ/T2BIuZB4ihsevyVS+QR+U0w2cB FwwL6p0XOn0WObY0LMVZv/KJeTN+s9zbEspnr0h4W4hRsCcIjUSZXsyliDVhQC2ppfVWeL dfsZNdWeoMIYzV3xJA3ZMFdb6lq3XxJp0IQwkxJ4AaXLNACLa547kf/h5Tw1DPOhPicHBU Gc3DDpsNCJOfbCQsZe/p5LTvLxZx3o+k6udSm7rpypH+bisBqcqvr5fxdNMTJA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1639228529; a=rsa-sha256; cv=none; b=LEhtDkCz3wqm91Aj0Li+zqPORf1lBZ/Z0F7Mudqtr5yVNRnD6T0a4mWECPYY30c8sqAOgS CdinGozyxu4gptq9LIqtk82udIdx1jyuC34RInCMymNSrF7lany5vQ1BkOnd/otQRk+PfC WJqJwdfPijR4Eae2czDZre/1wNBS94Zhlp8kQ0AH3o0ebLT2YwENMAsGBzuYH71TfBrmsX yXMJ9uOZOs/zVGPyqMwgxynCDfoI4qtRyzmCArvWfN8rWyHQo6CAb5ZWoCencazknWM9Pv YOfvnUIeK3lwDmyiBMeoSwgBCiOH/lkjbdWHWVoeYGAbOEKhxt6NIBt7z/ywIQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=JcLGwZdR; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.66 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=JcLGwZdR; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: E12972FAB6 X-Spam-Score: -3.66 X-Migadu-Scanner: scn1.migadu.com X-TUID: 8GF2qGvoqWD8 --=-=-= Content-Type: text/plain Jacob MacDonald skribis: > April is a subset of APL embedded in Common Lisp. The following series > of patches adds its dependencies and April itself to the end of > lisp-xyz. > > This is the least trivial set of packages I have submitted, so I have > a few things I want to ensure I get right. > 1. Licensing: > a. cl-decimals has no license file and is marked as CC0-licensed in > its system file. Ok. > b. simple-date-time has no license file and is marked as BSD-licensed > in its system file. I marked it as BSD-4. Ok. > c. MaxPC is licensed under the AGPL. This is an issue for the > Apache-licensed April > (https://github.com/phantomics/april/issues/185), and an Apache > version of MaxPC is now bundled with April's source. Does building > April with MaxPC from source violate the AGPL? If so, the dependency > can be swapped out for the bundled one. According to [1] and [2], combining code under AGPL and code under Apache License is possible, and the result would be under AGPL. As the Guix package for April will only contain the things under Apache License, I think we just need to use 'license:asl2.0'. Unless the bundled MaxPC has modifications required for April to work, you can add a snippet to the 'source' field to remove the "maxpc-apache" directory, and use upstream's MaxPC. [1] https://www.apache.org/licenses/GPL-compatibility.html [2] https://opensource.stackexchange.com/questions/8270/can-i-use-apache-2-0-licensed-libraries-with-agpl-licensed-libraries > 2. Bundling: April depends on two systems vex and aplesque. These are > defined in the same repository. I broke them out into three packages > based on the same version of the source. > a. I renamed vex as there is an existing vector math library with > that name. I threw the math library into the patchset as well; It > might not properly belong. > b. I tried to use the #:asd-files and #:asd-systems options to > restrict what got built, but kept getting build failures. I added a > phase to each package to delete unused system files. This works, but > seems brittle. I don't think I understand the ASDF build system. I don't think we need to make three packages in this case. Making just one regular package for April should also build the vex and aplesque subsystems automatically (if all the required dependencies are listed in the 'inputs' field). > 3. Versioning: The latest April tag is a couple years old, while many > of its dependencies lack tags altogether. There is also a discrepancy > between the Git tag and the version numbers recorded in each system > file. Whether I wait for a new tag to bump the package or not, what's > the best way to version the package(s)? It pretty common for Common Lisp libraries not to have tags (or only very old tags), and we then use the commit hash and a revision number. There are many examples of such packages in "lisp-xyz.scm". Could you send an updated patch series? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIUEAREKAC0WIQTLxZxm7Ce5cXlAaz5r6CCK3yH+PwUCYbSkLA8cZ2x2QHBvc3Rl by5uZXQACgkQa+ggit8h/j9waQD/ZWiP3RGC6xcHqwhELRD/BR0TOGuI7KLi5oC/ LYqVD2MA/39pJq/oVbBLvQrG3bDDHrvBvruathb02bmalFMKeP6m =e/rU -----END PGP SIGNATURE----- --=-=-=--