From: Chris Marusich <cmmarusich@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 52940-close@debbugs.gnu.org
Subject: bug#52940: [PATCH] gremlin: Mimic ld.so NEEDED deduplication behavior.
Date: Sat, 08 Jan 2022 18:04:11 -0800 [thread overview]
Message-ID: <87czl1hdgk.fsf_-_@gmail.com> (raw)
In-Reply-To: <87a6gaknml.fsf@gnu.org> ("Ludovic Courtès"'s message of "Wed, 05 Jan 2022 20:07:14 +0100")
[-- Attachment #1: Type: text/plain, Size: 2215 bytes --]
Hi Ludo,
Ludovic Courtès <ludo@gnu.org> writes:
> Good catch! We could go fancy and have ‘loop’ in
> ‘file-needed/recursive’ thread a map of device/inode number pairs to
> file names; when calling ‘search-path’, we’d check whether the file we
> found already is in the set, possibly under a different name, and we’d
> use that name instead of introducing a new one. That’d be more
> efficient that calling ‘canonicalize-path’, especially O(n³) times
> roughly.
>
> But… given that this is a corner case, that modifying (guix build
> gremlin) entails a full rebuild, and that there just should be that
> “/lib/../lib” entry in the first place, I’d lean towards leaving
> gremlin.scm unchanged.
>
> WDYT?
>
> However…
>
>> diff --git a/tests/gremlin.scm b/tests/gremlin.scm
>> index 9af899c89a..86757e62b4 100644
>> --- a/tests/gremlin.scm
>> +++ b/tests/gremlin.scm
>> @@ -1,5 +1,6 @@
>> ;;; GNU Guix --- Functional package management for GNU
>> ;;; Copyright © 2015, 2018, 2020 Ludovic Courtès <ludo@gnu.org>
>> +;;; Copyright © 2022 Chris Marusich <cmmarusich@gmail.com>
>> ;;;
>> ;;; This file is part of GNU Guix.
>> ;;;
>> @@ -92,7 +93,9 @@
>> (loop result))))))
>>
>> (define ground-truth
>> - (remove (cut string-prefix? "linux-vdso.so" <>)
>> + (remove (lambda (entry)
>> + (or (string-prefix? "linux-vdso.so" entry)
>> + (string-prefix? "linux-vdso64.so" entry)))
>> (read-ldd-output pipe)))
>>
>> (and (zero? (close-pipe pipe))
>
> … I think this part should definitely be committed (‘master’ is fine).
I agree that the existing behavior is probably fine. It makes me feel
better to know that you also think so.
With that in mind, I've committed a simpler fix in 6a2050b on master
that just changes the test. I've also updated the guix package two
times. Now, after running "guix pull", I can once again successfully
build the guix package on powerpc64le-linux. Hooray!
Thank you for the review! I'll now close this bug.
--
Chris
PGP: https://savannah.gnu.org/people/viewgpg.php?user_id=106836
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
prev parent reply other threads:[~2022-01-09 2:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-01 23:13 [bug#52940] [PATCH] gremlin: Mimic ld.so NEEDED deduplication behavior Chris Marusich
2022-01-05 19:07 ` Ludovic Courtès
2022-01-09 2:04 ` Chris Marusich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czl1hdgk.fsf_-_@gmail.com \
--to=cmmarusich@gmail.com \
--cc=52940-close@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).