[bug#55551] [PATCH] gnu: Add emacs-corfu-doc.

[bug#55551] [PATCH] gnu: Add emacs-corfu-doc.

[jgart via Guix-patches via]

* gnu/packages/emacs-xyz.scm (emacs-corfu-doc): New variable.
---
 gnu/packages/emacs-xyz.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index b2e2cffffe..e21c4f4308 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -3134,6 +3134,32 @@ (define-public emacs-corfu
 @code{completion-in-region} counterpart of the Vertico minibuffer UI.")
     (license license:gpl3+)))
 
+(define-public emacs-corfu-doc
+  ;; There are no tagged version releases.
+  (let ((commit "96b5de8cced0f2c2069748305bb72cf2db77200e")
+        (revision "0"))
+    (package
+      (name "emacs-corfu-doc")
+      (version (git-version "0.5.1" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/galeo/corfu-doc")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "18xgm8jjppdq43i4wa36pbwlh4jxdgkmfbj13w5q4c7b9cy7r3mf"))))
+      (build-system emacs-build-system)
+      (propagated-inputs (list emacs-corfu))
+      (home-page "https://github.com/galeo/corfu-doc")
+      (synopsis "Documentation popup for Corfu")
+      (description
+"The @code{corfu-doc} package provides a way to display a documentation
+popup for completion candidates when using @code{emacs-corfu}.  It can
+be regarded as @code{emacs-company-quickhelp} for @code{emacs-corfu}.")
+      (license license:gpl3+))))
+
 (define-public emacs-cape
   (package
     (name "emacs-cape")
-- 
2.35.3

[bug#55551] [PATCH] gnu: Add emacs-corfu-doc.

[Maxime Devos]

[-- Attachment #1: Type: text/plain, Size: 526 bytes --]

jgart via Guix-patches via schreef op vr 20-05-2022 om 18:13 [-0500]:
> +(define-public emacs-corfu-doc
> +  ;; There are no tagged version releases.
> +  (let ((commit "96b5de8cced0f2c2069748305bb72cf2db77200e")
> +        (revision "0"))
> +    (package
> +      (name "emacs-corfu-doc")
> +      (version (git-version "0.5.1" revision commit))

That commit says: ‘Version 0.5.1’, so it seems a proper version /
formal release to me, with no need for git-version.

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

[bug#55551] [PATCH v2] gnu: Add emacs-corfu-doc.

[jgart via Guix-patches via]

* gnu/packages/emacs-xyz.scm (emacs-corfu-doc): New variable.

Hi Maxime,

Here's a version 2 of the original patch with your suggestions.

Thank you for the code review.

all best,

jgart
---
 gnu/packages/emacs-xyz.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index b2e2cffffe..c271d0521c 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -3134,6 +3134,31 @@ (define-public emacs-corfu
 @code{completion-in-region} counterpart of the Vertico minibuffer UI.")
     (license license:gpl3+)))
 
+(define-public emacs-corfu-doc
+  (let ((commit "96b5de8cced0f2c2069748305bb72cf2db77200e")
+        (revision "0"))
+    (package
+      (name "emacs-corfu-doc")
+      (version "0.5.1")
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/galeo/corfu-doc")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "18xgm8jjppdq43i4wa36pbwlh4jxdgkmfbj13w5q4c7b9cy7r3mf"))))
+      (build-system emacs-build-system)
+      (propagated-inputs (list emacs-corfu))
+      (home-page "https://github.com/galeo/corfu-doc")
+      (synopsis "Documentation popup for Corfu")
+      (description
+"The @code{corfu-doc} package provides a way to display a documentation
+popup for completion candidates when using @code{emacs-corfu}.  It can
+be regarded as @code{emacs-company-quickhelp} for @code{emacs-corfu}.")
+      (license license:gpl3+))))
+
 (define-public emacs-cape
   (package
     (name "emacs-cape")
-- 
2.35.3

[bug#55551] [PATCH v2] gnu: Add emacs-corfu-doc.

[Tobias Geerinckx-Rice via Guix-patches via]

[-- Attachment #1: Type: text/plain, Size: 254 bytes --]

jgart via Guix-patches via 写道：
> Here's a version 2 of the original patch with [Maxime's] 
> suggestions.

I bumped it further to 0.6.3, and removed the revision & 
let-binding entirely.

Pushed to master; thanks!

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]