From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id WOBNBjCAzGJyFgEAbAwnHQ (envelope-from ) for ; Mon, 11 Jul 2022 21:55:28 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id UMUvBjCAzGJ9NwAA9RJhRA (envelope-from ) for ; Mon, 11 Jul 2022 21:55:28 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A243C9F26 for ; Mon, 11 Jul 2022 21:55:27 +0200 (CEST) Received: from localhost ([::1]:52340 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oAzV8-0005vq-H2 for larch@yhetil.org; Mon, 11 Jul 2022 15:55:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53220) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oAzUk-0005sw-EL for guix-patches@gnu.org; Mon, 11 Jul 2022 15:55:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:47153) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oAzUk-0005pg-49 for guix-patches@gnu.org; Mon, 11 Jul 2022 15:55:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oAzUk-0000sh-1E for guix-patches@gnu.org; Mon, 11 Jul 2022 15:55:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56433] [PATCH] import: pypi: Add special treatment for Tryton package names, Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 11 Jul 2022 19:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56433 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Hartmut Goebel Cc: 56433@debbugs.gnu.org Received: via spool by 56433-submit@debbugs.gnu.org id=B56433.16575692583326 (code B ref 56433); Mon, 11 Jul 2022 19:55:01 +0000 Received: (at 56433) by debbugs.gnu.org; 11 Jul 2022 19:54:18 +0000 Received: from localhost ([127.0.0.1]:41050 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAzU2-0000ra-5t for submit@debbugs.gnu.org; Mon, 11 Jul 2022 15:54:18 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38562) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAzU0-0000rM-Jf for 56433@debbugs.gnu.org; Mon, 11 Jul 2022 15:54:16 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58160) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oAzTu-0005mV-JF; Mon, 11 Jul 2022 15:54:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=sLS03xp1e4ERWti2G3VoFF3y82pbO+eTpsY0+TlKlc8=; b=C2MYEgwwZ+0BdWr87W0i kY3vRXr+3MonUrYeCr3/iCOKpUnLKCSmBjZaaJ0cgTosVwOq/Ol94z8WphXMoxL+X19R8UWUyOGK8 eNUChIXUYciX5BkUgDuwGJ8kPbMUxnO3TYemkvgMe2yLWtoP71FfBk6FFhFeQCbi6hydM1LmGSqX6 r4FW2mHeZd8ziDKov7E0proTogM3d1AknZEn7gOGcfxR/y57Tk/+a6BnY/QUDfFrV9HxRr70gAghA ecdKyttUcZZqZpsOfVDH/qCKd8K4Pp0bOhQYsJ8vXnpAUZOII0vK1UDqcCFDviMsgQRX8qXwoJDJT KxnJpQ4PILO+XA==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:58394 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oAzTu-0006Rg-5S; Mon, 11 Jul 2022 15:54:10 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <026f292cc13e95239135786a8ad830a29d483e41.1657187223.git.h.goebel@crazy-compilers.com> <87sfnbs2tq.fsf@gnu.org> <76110c8d-d498-8dbf-dcb6-a0248dedf8b8@crazy-compilers.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Tridi 23 Messidor an 230 de la =?UTF-8?Q?R=C3=A9volution, ?= jour du Haricot X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 11 Jul 2022 21:54:08 +0200 In-Reply-To: <76110c8d-d498-8dbf-dcb6-a0248dedf8b8@crazy-compilers.com> (Hartmut Goebel's message of "Mon, 11 Jul 2022 15:49:43 +0200") Message-ID: <87czebjuhr.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1657569327; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=sLS03xp1e4ERWti2G3VoFF3y82pbO+eTpsY0+TlKlc8=; b=g945UtMjCXnocgMKqdOzIOHBn2zKygTrm6m3n+EBlt471nRGe3Fe5F9Sie5PY6UyBwA7Iu jxLkYzISolLr6eAAa96ivQ5f/qFYx1nSgKKJLo4s+oCPMKOmR1QNXeyLzHvOQ/d4vEFqVU uMC3m1uL1cP1jzR6BUSynCdu6zHhyhYHJb0jzrtPBfHAsgBXq1xdIlr1w/ZuiNtrSPHtZy tm6ZQLaw1BzbC3vbbwkEWhKg0jkR7Wz3vEJd0rMoOrpSlQjr1gCJYJNzX5MkMzJRQrzJim rzBKiL95WBlHkAchvl+N26FbYIY1TD1uND1HK+mKHqj9WtA1eGEyA5Vhs9/7gw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1657569327; a=rsa-sha256; cv=none; b=TAWAkTWCA6OJ7NNl0cRUUX7a2L9wf/bWm+L2pRZasNEZ6WVGPzYExy7+dy/z2ukGU/8/ko Eo4F0Y32X6gbXUq9dqTq7fIgGvv4trUo3DQsC5JxFVPagaFgGysjfOeoGdc7Xiz/+5bfrd wZTBn/COsZm3n7Z4zTo5zWRAZiaT6Fp1tFiLbsXhetyVOIQojZFZJK4MhOep6yfAsLGmg6 IAIhaaLsvlgY+itO0p1UFS+aZbHLwZLykRySyH8EhSzXUll1Kc2t1WDnR7sg5R1uDTYzbg l6m/nK4+VCrcwEj9wYiTrqA6DNov8tJ7VPEXtpoCkC2H8o8dKdGBIj+TmoN0Jg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=C2MYEgww; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.45 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=C2MYEgww; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: A243C9F26 X-Spam-Score: -4.45 X-Migadu-Scanner: scn0.migadu.com X-TUID: 6719YE1+K6za Hi, Hartmut Goebel skribis: > AFAIU the =E2=80=9Eupstream-name=E2=80=9C property changes the name when = requesting > the upstream source or when updating. The =E2=80=98upstream-name=E2=80=99 property establishes a mapping between = the package at hand and its upstream name, overriding guesswork normally done by importers and updaters. > This fix works into the opposite direction: it fixes the > =E2=80=9Edownstream=E2=80=9C-name =3D the guix package name. > > Name at pypi: > > * =E2=80=9Enormal=E2=80=9C Python package: myCoolModule > * Trytond package: trytond-cool_addon. > > Name at guix: > > * =E2=80=9Enormal=E2=80=9C Python package: python-mycoolmodule =E2=80=94= =E2=80=9Cpython-=E2=80=9D prefix > * Trytond package: trytond-cool-addon =E2=80=94 no =E2=80=9Cpython-=E2= =80=9D prefix Ooh, got it. So yes, this patch makes sense to me. (I=E2=80=99m surprised= we decided against the =E2=80=9Cpython-=E2=80=9D prefix back then, but that=E2= =80=99s history.) > Looks like this is not clear from the commit message. Does this > changed message make it clear? I think the commit message is fine, but=E2=80=A6 > Trytond modules are Python packages, and treated like this in guix. > Anyhow, since they are add-ons for the =E2=80=9CTrytond=E2=80=9C applicat= ion, > their guix package name do not get the "python-" prefix like other > Python modules, (see also https://issues.guix.gnu.org/46057#1). This > change disables > adding the "python-" prefix to the guix packge name for Trytond modules > when importing and updating, thus > inhibiting irritating messages like =E2=80=9Econsider removing this propa= gated > input: > trytond-party, consider adding this propagated input: python-trytond-part= y=E2=80=9C. =E2=80=A6 I=E2=80=99m not sure I fully understand this part: you=E2=80=99re= talking about messages produced by =E2=80=98guix refresh=E2=80=99, right? Do you have th= e example of a command that triggers this? Perhaps you can include that example in the commit message to make things perfectly clear. Anyway, LGTM, thanks! Ludo=E2=80=99.