unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: Sughosha <Sughosha@proton.me>
Cc: 57999@debbugs.gnu.org, maxim.cournoyer@gmail.com
Subject: [bug#57999] [PATCH] gnu: Add textpieces
Date: Sun, 16 Oct 2022 19:27:29 +0100	[thread overview]
Message-ID: <87czarbp04.fsf@cbaines.net> (raw)
In-Reply-To: <hIbSRv41X_s3LKsXCfvcu1hKe20yYm6Amz0RRrVlHwKXxqJIZ5ibjpzYl5xIF25wz_IflW3CHp8W_N45JGRpJOg1epcrm-8JC8UKdMML0j0=@proton.me>

[-- Attachment #1: Type: text/plain, Size: 720 bytes --]


Sughosha via Guix-patches via <guix-patches@gnu.org> writes:

> Thanks for reviewing. The problem is only that while validating the
> appstream it requires connecting to internet, but in Guix packaging
> works offline. Otherwise if built outside Guix, then it passes the
> test.
>
> And, I will correct and send another patch file.

Hi both,

I got a bit confused and I thought an updated patch was attached to this
reply, and went ahead and pushed as
fc68b97db12b34dec558fde73d651aa0d3bbd446, with a couple of tweaks.

I did miss changing some of the things that Maxim suggested though. If
you can Sughosha, please do send a patch to make the relevant changes,
otherwise I can try and clean things up.

Thanks,

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

  reply	other threads:[~2022-10-16 18:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-22  6:23 [bug#57999] [PATCH] gnu: Add textpieces Sughosha via Guix-patches via
2022-09-28 17:26 ` Maxim Cournoyer
2022-09-28 17:35   ` Sughosha via Guix-patches via
2022-10-16 18:27     ` Christopher Baines [this message]
2022-10-17  5:19       ` Sughosha via Guix-patches via
2022-10-18 10:15         ` bug#57999: " Christopher Baines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87czarbp04.fsf@cbaines.net \
    --to=mail@cbaines.net \
    --cc=57999@debbugs.gnu.org \
    --cc=Sughosha@proton.me \
    --cc=maxim.cournoyer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).