From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id MKDdFfkmFGSGWQAASxT56A (envelope-from ) for ; Fri, 17 Mar 2023 09:38:17 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id WBzkFfkmFGSbewEA9RJhRA (envelope-from ) for ; Fri, 17 Mar 2023 09:38:17 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2D357293CB for ; Fri, 17 Mar 2023 09:38:17 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1679042297; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=FPh2KU19btAx+mtQrc1H5sByNd1YGhKPJs1lwfMxdgc=; b=L92jjLXf1nZe05yq50cAggFYwvtB4rZj42V/IXceys9jPbPJCEsEhEyqKhPfhVaBG3Dx2U VNz2J6Ub+BXq5BXfWU2h3/sy9pqe0BGz3uPnhcJYgBcMy7WLjWaUwjF0sUpvTnWk7WLXBu O9RKn97qQ55McUj2kZz7vFRsGTZ3gMr3bZWk9KPk8mSbRKQOc2vzHEPB1Y7mhHkQk8H9ll gjrgGUi4LgJZuzexTvUKx26LE4BJF4rkS/umY6EhjG2WTzfh9CALaPGqA91sHjYucnIwql kYLtu/3G6AWYTupqLdtZ2whYkm8atRI845XPPhNVdvHk4DAK0GvBmcmMzRm3KA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1679042297; a=rsa-sha256; cv=none; b=Xle3dB4fN8HvnDmcm9AdGC/hXau3X2FWBxi9usq6gIn2fgCLLle/7oI7Okz6/qfRPUnB4i fUwPrTWv3sl+stQWhTa3943DRUv1Qq3de9lPcfg2wIExGtnza/phgX6kwhnlHT/i2kaVHi EIVBmKJr+oli5x4TsDX7fxcVB8QZ6d9ico/4eGEHPXl/OV6aqwLhnqmaPZV0U0pEfQ9bDI 0e2os1nqmgCBpG7akVyxF0q0LeZ976niKA/0EGR/UoR+pH/X1G41BnbaKDFVG3e+VeEmpu bt8TMpjY8xB9PSSWaRWblEmeGM4xbO9tKq+Wlp8FAvdx8QVrtMMjfMOcvoLokg== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pd5bA-0007Hb-U8; Fri, 17 Mar 2023 04:38:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pd5b9-0007HG-6T for guix-patches@gnu.org; Fri, 17 Mar 2023 04:38:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pd5b8-0005T9-Rz for guix-patches@gnu.org; Fri, 17 Mar 2023 04:38:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pd5b8-00084e-Gu for guix-patches@gnu.org; Fri, 17 Mar 2023 04:38:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62122] [PATCH 1/4] gnu: Add emacs-sphinx-doc. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 17 Mar 2023 08:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62122 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Rostislav Svoboda Cc: 62122@debbugs.gnu.org Received: via spool by 62122-submit@debbugs.gnu.org id=B62122.167904222430968 (code B ref 62122); Fri, 17 Mar 2023 08:38:02 +0000 Received: (at 62122) by debbugs.gnu.org; 17 Mar 2023 08:37:04 +0000 Received: from localhost ([127.0.0.1]:43626 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pd5aB-00083P-Mb for submit@debbugs.gnu.org; Fri, 17 Mar 2023 04:37:03 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:35601) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pd5a8-00082p-Fj for 62122@debbugs.gnu.org; Fri, 17 Mar 2023 04:37:02 -0400 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id BDEA3FF80A; Fri, 17 Mar 2023 08:36:53 +0000 (UTC) From: Nicolas Goaziou References: <20230311144938.765-1-Rostislav.Svoboda@gmail.com> Date: Fri, 17 Mar 2023 09:36:52 +0100 In-Reply-To: <20230311144938.765-1-Rostislav.Svoboda@gmail.com> (Rostislav Svoboda's message of "Sat, 11 Mar 2023 15:49:35 +0100") Message-ID: <87cz57dba3.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: X-Migadu-Queue-Id: 2D357293CB X-Spam-Score: -3.74 X-Migadu-Spam-Score: -3.74 X-Migadu-Scanner: scn0.migadu.com List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-TUID: xj/KDxIVoxo6 Hello, Rostislav Svoboda writes: > * gnu/packages/emacs-xyz.scm (emacs-sphinx-doc): New variable. Thank you. Some comments follow. > +(define-public emacs-sphinx-doc > + (let ((commit "1eda612a44ef027e5229895daa77db99a21b8801")) Since you're using a non-tagged commit, you also need to bind revision to "0" or "1". FWIW, I prefer latter because Repology thinks "version-0" predates "version". > + (package > + (name "emacs-sphinx-doc") > + (version "0.1.0") Base version is "0.3.0" according to Version keyword. Therefore, this shoul= d be (git-version "0.3.0" revision commit) > + (home-page > + "https://github.com/naiquevin/sphinx-doc.el") You can use a single line here. > + (synopsis > + "Generate Sphinx friendly docstrings for Python functions") Ditto. Maybe add "in Emacs" at the end? > + (description > + "Emacs minor mode for inserting docstring skeleton for Python fun= ctions > +and methods. This should be a full sentence. Sphinx Doc is an Emacs minor mode=E2=80=A6 Could you send an updated patch? Regards, --=20 Nicolas Goaziou