From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id CCPtAH13MGTxawEASxT56A (envelope-from ) for ; Fri, 07 Apr 2023 22:05:17 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id OF+4AH13MGQXTAEAauVa8A (envelope-from ) for ; Fri, 07 Apr 2023 22:05:17 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 75D2C24E94 for ; Fri, 7 Apr 2023 22:05:16 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pksKY-0006nz-Vl; Fri, 07 Apr 2023 16:05:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pksKW-0006nL-NE for guix-patches@gnu.org; Fri, 07 Apr 2023 16:05:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pksKV-0005Rk-J8 for guix-patches@gnu.org; Fri, 07 Apr 2023 16:05:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pksKT-0006Cf-US for guix-patches@gnu.org; Fri, 07 Apr 2023 16:05:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#60788] [PATCH] services: Add vnstat-service-type. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 07 Apr 2023 20:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60788 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Bruno Victal , 60788@debbugs.gnu.org Received: via spool by 60788-submit@debbugs.gnu.org id=B60788.168089787423809 (code B ref 60788); Fri, 07 Apr 2023 20:05:01 +0000 Received: (at 60788) by debbugs.gnu.org; 7 Apr 2023 20:04:34 +0000 Received: from localhost ([127.0.0.1]:57274 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pksK2-0006Bw-19 for submit@debbugs.gnu.org; Fri, 07 Apr 2023 16:04:34 -0400 Received: from mail-qt1-f182.google.com ([209.85.160.182]:38750) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pksK0-0006Bi-3b for 60788@debbugs.gnu.org; Fri, 07 Apr 2023 16:04:32 -0400 Received: by mail-qt1-f182.google.com with SMTP id y4so11453570qti.5 for <60788@debbugs.gnu.org>; Fri, 07 Apr 2023 13:04:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680897866; x=1683489866; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=UpjN8Y/29XZSR7rXzWFfztFAXNYrk34Tl5GBHijBA3M=; b=MHkclXeo3+OdOT6NRgdx1uqaE59QK3RRyQ74PfCtz6CbXz0wiRmii+8hIdgLLu6x0p fPrqkEEaCTsGa8fs0VH/97TJdvOu4wi0MZ3Z0V+3txOTB3KQQBne1KKfXFfPk5jBsbSj hbM7md5eFvSfJxO+7ULto1FnTT3FK/ST8ogim9kN+OdPclqD5EixjeVrQDqy151crr0D lZCOK/Hhq54zbnX2Bsv9nBxpQjmLD2weYEZ4TPK5uZq0wjsDiSHigBuzuRixyVvBHjGk 3KN2ol2zGVCHJSv+Ae0OlNGe/ZV9rh9kHmzZl9Yjzhfb+fhJ5wtBBCcrfBxqJmM5967Y alIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680897866; x=1683489866; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=UpjN8Y/29XZSR7rXzWFfztFAXNYrk34Tl5GBHijBA3M=; b=G9HLoqbkfZOz/YB7vDkgT/w6DmQp/pi0BLjuzUd262fG523u0gIZTTJEjG7j4rJuRr hwi1EekhouO/AUhU+sV43jq0rJZS/LXFLbq0h2WgvXOBWDwmE+FpRWDqjzTQEvGYQYgd Zf8c+OiZL6FgtDOWlswilzXMXyhe4pglg04GpVjaqlQggF2+ysNSWB20jJtavYPotjdy +Shw4o9ZbxV8M0CTNNL8ZluunJaSOW6XXXEoBPzbS3S431S2TPW3pn4CAB4D11U0GvrG UDOSG+ayPL/IdStyW1wWZsh5S+rxEfUE/Zb7dWz3qCy2dU87AkK9vwpaPDZep9IWngC9 Ca8w== X-Gm-Message-State: AAQBX9d8GaoJ8Ikv3tPxqxlS9ygHr++r4zGosSHooageBKb4db2jD2C0 6TIpPHTwDyVivu8DAaY5cT40WYXYMjk= X-Google-Smtp-Source: AKy350YQc7Nd3pfAyYgxm8CxSKKyOl8gh+qW1cA1UmhHsS3orejc4UZvnsTA7KWxFGREX1vzaM0cUg== X-Received: by 2002:ac8:7fc2:0:b0:3e3:93ae:d104 with SMTP id b2-20020ac87fc2000000b003e393aed104mr5885677qtk.30.1680897866252; Fri, 07 Apr 2023 13:04:26 -0700 (PDT) Received: from hurd (dsl-205-233-125-210.b2b2c.ca. [205.233.125.210]) by smtp.gmail.com with ESMTPSA id o24-20020ac841d8000000b003de4e646d63sm1410489qtm.32.2023.04.07.13.04.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Apr 2023 13:04:25 -0700 (PDT) From: Maxim Cournoyer References: <95b646eb6b23dec213cba43b6e4e7ddc4a601d0f.1673640404.git.mirai@makinata.eu> <87edovd8em.fsf_-_@gnu.org> Date: Fri, 07 Apr 2023 16:04:24 -0400 In-Reply-To: <87edovd8em.fsf_-_@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Fri, 07 Apr 2023 17:22:25 +0200") Message-ID: <87cz4ftq5z.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1680897916; a=rsa-sha256; cv=none; b=f0mJyJRmDrI0vnpDnxh+jTCDlNBARrwZdeqUHbXG/QLM/kEe4DP9xhMjgoC4xqX4hFpLLg z4C/Ofz5KrjQ32MKhm70/5JjkaUdgJFlldnjx3k8kzvmKBGqNjpbujTL5dFDEeKiR5SLIv v3JtE891P/798pBljb/WNrGTb8y7vnCeRoCSYuE0wgiBo11iiO5h42uarLCsB8I/ckAvyX JJaLE1YUDpNBMDlwRvgrrRWxNwDXyXEQNZ+dApNr0/5sU71QdUrmzAJT6Tacx6lnuJ6mth P4gZrm6LyYVUQRM9HDMzMqlEWVd4P4XZBa8q3gSpPohMpAyUwr5V3bf5tg1rdg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=MHkclXeo; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1680897916; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=UpjN8Y/29XZSR7rXzWFfztFAXNYrk34Tl5GBHijBA3M=; b=ShfGaP92d3encgVsGL2N4NpU5oYdTAm//argzwopgLWxA08/OPJX4gkufB1FoJvfP0s7Fo PQbLORrJt8nktt3JgJ00LKFhwBQ/Yla1GtISsls/8/a4pegh6+MjB7LCsF+dFbH4pd3XpW FNdBVAIhScHMa49GAZ2rn5vNt1U1+vq/4QFx2n9/3+JwW766JLJzVhMKkTo81kzxpvOVHn qf+GKbjv8xlG3MqT99XXd7cyIHMkoASHZ1Qvr9GQkWT9sjk9jEDykRtLr5JbyM8e00EK8+ 8VI5xjxIJ9oY3y0GLP7ExBpb+DTy4RslNKMXvmp9T00jhOdqMUEsGBJzE3XnYg== Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=MHkclXeo; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -3.22 X-Spam-Score: -3.22 X-Migadu-Queue-Id: 75D2C24E94 X-TUID: EyigQHeX/LKf Hi Ludo, Ludovic Court=C3=A8s writes: > Hi! > > Bruno Victal skribis: > >> * gnu/services/monitoring.scm (vnstat-service-type): New variable. >> * doc/guix.texi (Monitoring Services): Document it. >> --- >> >> Changes since v8: >> * Forgot to amend commit in v8, v9 corrects this. > > Sorry to chime in after 9 versions (!). > > I think a system test would be nice, we generally require it upfront, > but since Maxim wrote it can come later, let=E2=80=99s not let it block t= his > patch any longer. I didn't mean to lower our standards; I wasn't sure if that policy of ours was strict, since a few system services do not have corresponding tests, IIRC. I wary a bit that demanding a system test for each added service may cause scalability problems in the long run, as each demand a disk-heavy image to be generated and the test to run in a VM, which makes it expensive/slow. On the other hand, it's nice to know about any regressions when they happen rather than on a reboot... If we have such a policy, perhaps we should explicit it in our documented contribution guidelines? --=20 Thanks, Maxim