unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: John Kehayias via Guix-patches via <guix-patches@gnu.org>
To: Felix Lechner <felix.lechner@lease-up.com>
Cc: guix-devel@gnu.org, 63098@debbugs.gnu.org
Subject: [bug#63098] [PATCH] gnu: guitarix: Update to 0.44.1.
Date: Wed, 26 Apr 2023 22:28:34 +0000	[thread overview]
Message-ID: <87cz3q5ldh.fsf@protonmail.com> (raw)
In-Reply-To: <CAFHYt54VFXG00ZhmJCW7W6ZxBLVg8oODEu647bFHwxG5trbQGQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 8704 bytes --]

Hi Felix,

On Wed, Apr 26, 2023 at 02:57 PM, Felix Lechner via \"Development of
GNU Guix and the GNU System distribution.\" wrote:

> Hi,
>
> With a recent checkout of Guix, guitarix fails to build from source.
> It may be a Python issue. A pertinent excerpt of the log is below.
>
> Without a patch ready, I wasn't sure where and how to file this report. Thanks!
>

The usual bug-guix@gnu.org list will do just fine I would say.

In any event, I'm cc'ing the patch list with a quick patch that
updates the package which builds fine for me locally; I didn't test
running it though. I also updated to gexps and removed the
native-inputs label. Since this was an update and the package
currently doesn't build, I put it as one patch, but maybe it should be
split up? I'm not sure (I think usually as separate commit, but here a
fix/update for broken package seemed opportune), feel free to chime in
anyone. I also did this super quickly, apologies for any silly
mistakes.

Thanks for the report!
John

> Kind regards
> Felix
>
> * * *
>
> [ 477/1048] Compiling src/gx_head/engine/gx_resampler.cpp
> In file included from
> /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gthread.h:32,
>                  from
> /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gasyncqueue.h:32,
>                  from
> /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib.h:32,
>                  from
> /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gi18n.h:21,
>                  from
> /gnu/store/cbjgz6f8nrb7804nnmmlvpd4y78p8zf3-glibmm-2.64.5/include/glibmm-2.4/glibmm/i18n.h:23,
>                  from ../src/headers/engine.h:43,
>                  from ../src/gx_head/engine/gx_resampler.cpp:27:
> ../src/headers/gx_system.h: In function ‘bool
> gx_system::atomic_compare_and_exchange(volatile int*, int, int)’:
> /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gatomic.h:163:44:
> error: invalid conversion from ‘volatile void*’ to ‘void*’
> [-fpermissive]
>   163 |     __atomic_compare_exchange_n ((atomic), &gaicae_oldval,
> (newval), FALSE, __ATOMIC_SEQ_CST, __ATOMIC_SEQ_CST) ? TRUE : FALSE; \
>       |                                            ^~~~~~~~~~~~~~
>       |                                            |
>       |                                            volatile void*
> ../src/headers/gx_system.h:115:12: note: in expansion of macro
> ‘g_atomic_int_compare_and_exchange’
>   115 |     return g_atomic_int_compare_and_exchange(p, oldv, newv);
>       |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> In file included from
> /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gthread.h:32,
>                  from
> /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gasyncqueue.h:32,
>                  from
> /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib.h:32,
>                  from
> /gnu/store/3cl87br64f94fr6w45cpwzyn1kv9ma2p-gtk+-3.24.37/include/gtk-3.0/gdk/gdkconfig.h:8,
>                  from
> /gnu/store/3cl87br64f94fr6w45cpwzyn1kv9ma2p-gtk+-3.24.37/include/gtk-3.0/gdk/gdk.h:30,
>                  from
> /gnu/store/3cl87br64f94fr6w45cpwzyn1kv9ma2p-gtk+-3.24.37/include/gtk-3.0/gtk/gtk.h:30,
>                  from ../src/headers/guitarix.h:35,
>                  from ../src/gx_head/gui/gx_main_boxes.cpp:25:
> ../src/headers/gx_system.h: In function ‘bool
> gx_system::atomic_compare_and_exchange(volatile int*, int, int)’:
> /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gatomic.h:163:44:
> error: invalid conversion from ‘volatile void*’ to ‘void*’
> [-fpermissive]
>   163 |     __atomic_compare_exchange_n ((atomic), &gaicae_oldval,
> (newval), FALSE, __ATOMIC_SEQ_CST, __ATOMIC_SEQ_CST) ? TRUE : FALSE; \
>       |                                            ^~~~~~~~~~~~~~
>       |                                            |
>       |                                            volatile void*
> ../src/headers/gx_system.h:115:12: note: in expansion of macro
> ‘g_atomic_int_compare_and_exchange’
>   115 |     return g_atomic_int_compare_and_exchange(p, oldv, newv);
>       |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> In file included from
> /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gthread.h:32,
>                  from
> /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gasyncqueue.h:32,
>                  from
> /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib.h:32,
>                  from
> /gnu/store/3cl87br64f94fr6w45cpwzyn1kv9ma2p-gtk+-3.24.37/include/gtk-3.0/gdk/gdkconfig.h:8,
>                  from
> /gnu/store/3cl87br64f94fr6w45cpwzyn1kv9ma2p-gtk+-3.24.37/include/gtk-3.0/gdk/gdk.h:30,
>                  from
> /gnu/store/3cl87br64f94fr6w45cpwzyn1kv9ma2p-gtk+-3.24.37/include/gtk-3.0/gtk/gtk.h:30,
>                  from ../src/headers/guitarix.h:35,
>                  from ../src/gx_head/gui/gx_main_midi.cpp:25:
> ../src/headers/gx_system.h: In function ‘bool
> gx_system::atomic_compare_and_exchange(volatile int*, int, int)’:
> /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gatomic.h:163:44:
> error: invalid conversion from ‘volatile void*’ to ‘void*’
> [-fpermissive]
>   163 |     __atomic_compare_exchange_n ((atomic), &gaicae_oldval,
> (newval), FALSE, __ATOMIC_SEQ_CST, __ATOMIC_SEQ_CST) ? TRUE : FALSE; \
>       |                                            ^~~~~~~~~~~~~~
>       |                                            |
>       |                                            volatile void*
> ../src/headers/gx_system.h:115:12: note: in expansion of macro
> ‘g_atomic_int_compare_and_exchange’
>   115 |     return g_atomic_int_compare_and_exchange(p, oldv, newv);
>       |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> In file included from
> /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gthread.h:32,
>                  from
> /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gasyncqueue.h:32,
>                  from
> /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib.h:32,
>                  from
> /gnu/store/3cl87br64f94fr6w45cpwzyn1kv9ma2p-gtk+-3.24.37/include/gtk-3.0/gdk/gdkconfig.h:8,
>                  from
> /gnu/store/3cl87br64f94fr6w45cpwzyn1kv9ma2p-gtk+-3.24.37/include/gtk-3.0/gdk/gdk.h:30,
>                  from
> /gnu/store/3cl87br64f94fr6w45cpwzyn1kv9ma2p-gtk+-3.24.37/include/gtk-3.0/gtk/gtk.h:30,
>                  from ../src/headers/guitarix.h:35,
>                  from ../src/headers/avahi_discover.h:26,
>                  from ../src/gx_head/gui/avahi_discover.cpp:21:
> ../src/headers/gx_system.h: In function ‘bool
> gx_system::atomic_compare_and_exchange(volatile int*, int, int)’:
> /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gatomic.h:163:44:
> error: invalid conversion from ‘volatile void*’ to ‘void*’
> [-fpermissive]
>   163 |     __atomic_compare_exchange_n ((atomic), &gaicae_oldval,
> (newval), FALSE, __ATOMIC_SEQ_CST, __ATOMIC_SEQ_CST) ? TRUE : FALSE; \
>       |                                            ^~~~~~~~~~~~~~
>       |                                            |
>       |                                            volatile void*
> ../src/headers/gx_system.h:115:12: note: in expansion of macro
> ‘g_atomic_int_compare_and_exchange’
>   115 |     return g_atomic_int_compare_and_exchange(p, oldv, newv);
>       |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Waf: Leaving directory
> `/tmp/guix-build-guitarix-0.43.1.drv-0/guitarix-0.43.1/build'
> Build failed
>  -> task in 'guitarix' failed with exit status 1 (run with -v to
> display more information)
>  -> task in 'guitarix' failed with exit status 1 (run with -v to
> display more information)
>  -> task in 'guitarix' failed with exit status 1 (run with -v to
> display more information)
>  -> task in 'guitarix' failed with exit status 1 (run with -v to
> display more information)
> error: in phase 'build': uncaught exception:
> %exception #<&invoke-error program: "python" arguments: ("waf"
> "build") exit-status: 1 term-signal: #f stop-signal: #f>
> phase `build' failed after 68.7 seconds
> command "python" "waf" "build" failed with status 1

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-guitarix-Update-to-0.44.1.patch --]
[-- Type: text/x-patch; name=0001-gnu-guitarix-Update-to-0.44.1.patch, Size: 2270 bytes --]

From c652ee7b7339d287b623692190d66c3f5f3a90ee Mon Sep 17 00:00:00 2001
From: John Kehayias <john.kehayias@protonmail.com>
Date: Wed, 26 Apr 2023 18:25:35 -0400
Subject: [PATCH] gnu: guitarix: Update to 0.44.1.

* gnu/packages/audio.scm (guitarix): Update to 0.44.1.
[arguments]: Use gexps.
[native-inputs]: Remove labels
---
 gnu/packages/audio.scm | 26 +++++++++++++-------------
 1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index dca5e516a1..c369fe1bd4 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -2314,7 +2314,7 @@ (define-public freepats-gm
 (define-public guitarix
   (package
     (name "guitarix")
-    (version "0.43.1")
+    (version "0.44.1")
     (source (origin
              (method url-fetch)
              (uri (string-append
@@ -2322,14 +2322,14 @@ (define-public guitarix
                    version ".tar.xz"))
              (sha256
               (base32
-               "1bsjlfd7x09p3iiljilyfbns6hpqn9cgp6psl4ccd6i1lwascfrm"))))
+               "063cdvrzrpnj08dm22z651hy5cz5bnsywf1z8b2kib2i9xskvs3p"))))
     (build-system waf-build-system)
     (arguments
-     `(#:tests? #f ; no "check" target
-       #:configure-flags
-       (list
-        ;; Add the output lib directory to the RUNPATH.
-        (string-append "--ldflags=-Wl,-rpath=" %output "/lib"))))
+     (list #:tests? #f ; no "check" target
+           #:configure-flags
+           #~(list
+              ;; Add the output lib directory to the RUNPATH.
+              (string-append "--ldflags=-Wl,-rpath=" #$output "/lib"))))
     (inputs
      (list libsndfile
            boost
@@ -2347,12 +2347,12 @@ (define-public guitarix
            zita-resampler
            zita-convolver))
     (native-inputs
-     `(("gperf" ,gperf)
-       ("faust" ,faust)
-       ("intltool" ,intltool)
-       ("gettext" ,gettext-minimal)
-       ("pkg-config" ,pkg-config)
-       ("sassc" ,sassc)))
+     (list gperf
+           faust
+           intltool
+           gettext-minimal
+           pkg-config
+           sassc))
     (native-search-paths
      (list (search-path-specification
             (variable "LV2_PATH")
-- 
2.39.2


       reply	other threads:[~2023-04-26 22:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAFHYt54VFXG00ZhmJCW7W6ZxBLVg8oODEu647bFHwxG5trbQGQ@mail.gmail.com>
2023-04-26 22:28 ` John Kehayias via Guix-patches via [this message]
2023-04-27 14:42   ` [bug#63098] [PATCH] gnu: guitarix: Update to 0.44.1 Felix Lechner via Guix-patches via
2023-04-30 20:34   ` Ludovic Courtès
2023-05-02  4:59     ` bug#63098: " John Kehayias via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cz3q5ldh.fsf@protonmail.com \
    --to=guix-patches@gnu.org \
    --cc=63098@debbugs.gnu.org \
    --cc=felix.lechner@lease-up.com \
    --cc=guix-devel@gnu.org \
    --cc=john.kehayias@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).