From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id sMwaNvsE7mR9EgAAG6o9tA:P1 (envelope-from ) for ; Tue, 29 Aug 2023 16:47:24 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id sMwaNvsE7mR9EgAAG6o9tA (envelope-from ) for ; Tue, 29 Aug 2023 16:47:23 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8BA5E67CA8 for ; Tue, 29 Aug 2023 16:47:23 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=OX565Vjw; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1693320443; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=w/gA6EWjgiuYunNR2IOlVdMPunpPG1QvMhaYhtIOPGM=; b=FPzX0Iee8rIRz5ScdwWA7KH/Tz4EnY/gXqwNM1LC/JaxkcIzczsHU0T4JNdDyUDu9RRF9e HA68KrIMibdwPn8H/DHKY2mSIeUS/YW96S5vISZ/Zfn0/2XvvOQKLxdHAAC2DFtJAYXHMq PK00qSNTzZ43dfKckzCAy3vI328Ob284km4xor+0oKc7AfoDH0awvgWCSEGs2R+umlhLTX XWMcguh8ygVvvyLsb+o5shSfCgVweZCS0Xeo9oFwk33yMfFzC2JaxBvTWMgVePA2R3fFKa z6/DLux1Ao4g8U1ENYV6Ge+fDwIN/vuxGkzIEgh6qr0X6QroUnZ14GEINTn/jQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=OX565Vjw; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1693320443; a=rsa-sha256; cv=none; b=gyRizBrzt26PlDZmwF+PKV4zgwDJ0JkMvDjALj549APBHYwZeKikHG+osR7ynVmeXkSVRV NbSRzrq/AIdpTiwz9oR2RwNFdusd0AueWlW77Vqw5iQu1sU6hwpgDYTrJ2Q7bS69KzuyGS 0/zVGfk9aD+/weBNAbao0qZbCW/8KH+IEDJlJFdawDK5LyvdbA+ekdt0wvUyxOPejFEoMg 2e5Q97a1FJsvndZd/IBfF7g++hpVcA9klK2evEskUWdVwfNLAzfSoJpbLnRI/rksgPPA5X hg4Wfd+HP/DSkuOJjFJ/aGq4EA8VOkUvzTTfCa+LxV8Ax5BObWVX7gW+d7p3Uw== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qazzn-0003FP-Am; Tue, 29 Aug 2023 10:47:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qazzd-00036g-F6 for guix-patches@gnu.org; Tue, 29 Aug 2023 10:47:04 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qazza-00053P-JU for guix-patches@gnu.org; Tue, 29 Aug 2023 10:46:55 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qazzh-0001VG-Ic for guix-patches@gnu.org; Tue, 29 Aug 2023 10:47:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#60571] [PATCH v2 3/4] gnu: Add icu4c-for-skia. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 29 Aug 2023 14:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60571 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Nicolas Graves Cc: 60571@debbugs.gnu.org Received: via spool by 60571-submit@debbugs.gnu.org id=B60571.16933203825730 (code B ref 60571); Tue, 29 Aug 2023 14:47:01 +0000 Received: (at 60571) by debbugs.gnu.org; 29 Aug 2023 14:46:22 +0000 Received: from localhost ([127.0.0.1]:51368 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qazz3-0001UL-Jk for submit@debbugs.gnu.org; Tue, 29 Aug 2023 10:46:21 -0400 Received: from mail-qt1-x82a.google.com ([2607:f8b0:4864:20::82a]:62683) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qazz1-0001U8-Ev for 60571@debbugs.gnu.org; Tue, 29 Aug 2023 10:46:20 -0400 Received: by mail-qt1-x82a.google.com with SMTP id d75a77b69052e-4121788397fso14105951cf.0 for <60571@debbugs.gnu.org>; Tue, 29 Aug 2023 07:46:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693320366; x=1693925166; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=w/gA6EWjgiuYunNR2IOlVdMPunpPG1QvMhaYhtIOPGM=; b=OX565VjwxMh36uUFcFtU9+fh5RwSH971XEaFIAU/YKKPzIdcnwD0E6ixPHX6b8NwPq sCUD466paega/FwNMKNpjJ8fyfCVUK9ldpeUblGbdd6i5ik+1hATCY7pYsi8j520JkCy Ngqdj8q4QVTKyh4A9nGafRBlS/ZfI22DTyGC1qDOmlxFJB7tryexXeg1K6bRiGgc9QTo D1oj6OvWeW//nF2mW/DL7GiOEw8zAJxvVgPnqwTIx6FKXxHK+cg4N9WFMi90MMLgHDml e9h2QjKU2OAO0iYVyaaLtrCqdIrIGQqi1ukn7ClKMPGj0BJ0IN3lhBlQVPvoODxjP4xg IDjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693320366; x=1693925166; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=w/gA6EWjgiuYunNR2IOlVdMPunpPG1QvMhaYhtIOPGM=; b=XccGdXxeWUC3leXAhyDQ57ShxGrn9fSs3gMtoZ8Vvsr7eG/7pRywoP6KEBYhXP7TtZ i0JEoZy2D19AKSJokSsT2VSoob3aPNNVazCnYbHka+dXGJPQFd4jUZTdB7e4QYYWDdmn cH6Z7sFnEv0EW5LfIzhPC2BDiSFCD2Xa5+Kk3XOFtPYpN8pkDVunYnEjBkB/IHRQQfOt YO0MtXrRUwmnammtWVt+ecAzmF5n8B7D8o6VuDN1akkZdCrgAVy8uMzpR0UZF5HoJm8g k4UcILFvFU3bz7EbpojV7Fm7fK9A2K9+TCb1ie3nJ/OuZ1NZSenK+Ls8b4CEhGOdgOkO AbBg== X-Gm-Message-State: AOJu0YwOQbGkbFlGS5gcMPMz0K2qL4cRNIJfz2npkOibDpasL0z96Rw5 q3RRq6Idvndxnt8UBLZk8lFf+AGVwWkGhg== X-Google-Smtp-Source: AGHT+IFMrINe6R1+bi7QOrKfN80i3Lc5jRVXmDcmlZ/zF43EIc37xjrTuJYbCd3+tpcexpoLGZhobQ== X-Received: by 2002:a05:622a:1909:b0:400:9f2c:1211 with SMTP id w9-20020a05622a190900b004009f2c1211mr3343975qtc.29.1693320366565; Tue, 29 Aug 2023 07:46:06 -0700 (PDT) Received: from hurd (dsl-10-132-204.b2b2c.ca. [72.10.132.204]) by smtp.gmail.com with ESMTPSA id iw10-20020a05622a6f8a00b00410929fe3b9sm3016678qtb.58.2023.08.29.07.46.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Aug 2023 07:46:06 -0700 (PDT) From: Maxim Cournoyer References: <28d93ea0e4bda4dbbc9a653cfefb7e569b827ada.1693140822.git.ngraves@ngraves.fr> <874jkjgoch.fsf@gmail.com> <87ledunf4j.fsf@ngraves.fr> Date: Tue, 29 Aug 2023 10:46:05 -0400 In-Reply-To: <87ledunf4j.fsf@ngraves.fr> (Nicolas Graves's message of "Tue, 29 Aug 2023 15:37:48 +0200") Message-ID: <87cyz5c3f6.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx0.migadu.com X-Migadu-Spam-Score: -5.13 X-Spam-Score: -5.13 X-Migadu-Queue-Id: 8BA5E67CA8 X-TUID: 1VWoFTIyNEPb Hi Nicolas, Nicolas Graves writes: > On 2023-08-28 11:48, Maxim Cournoyer wrote: > >> Hello! >> >> Nicolas Graves writes: >> >> >> The comments are a bit terse; I'd expound them to complete sentences >> with a tad more context. > > Will try to expand a bit, but that will be hard, the commits are very > old and my memory of this mostly faded. > >> >> I'm confused here; we re-run the configure script post installation? >> How does that work? If that's really needed it needs a proper >> explanatory comment. > > IIRC, since we use this version of icu4c to run tests, we needed to > also build some "data". It's rather a reconfiguration to build data > rather than a re-run of the configuration script post-installation. That would perfect in an explanatory comment :-). >> >> The rest looks good! It's seems a tricky package, well done! Could you >> please send a v2 with the above suggestions/comments taken into account? > > Doing so Super! Thanks for seeing it through. -- Thanks, Maxim