unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou via Guix-patches via <guix-patches@gnu.org>
To: 67211@debbugs.gnu.org
Cc: tristan@cott.am, cox.katherine.e+guix@gmail.com,
	liliana.prikler@gmail.com, andrew@trop.in
Subject: [bug#67211] [PATCH] gnu: Add emacs-adwaita-dark-theme
Date: Thu, 16 Nov 2023 12:58:17 +0100	[thread overview]
Message-ID: <87cyw9yko6.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <9d33e4f09468d48a77db6c2dac38e25ff1fb9001.1700084634.git.tristan@cott.am> (Tristan Cottam via Guix-patches via's message of "Wed, 15 Nov 2023 22:43:54 +0100")

Hello,

Tristan Cottam via Guix-patches via <guix-patches@gnu.org> writes:

> I agree, I had missed that version bump commit. However, it isn't in fact the
> last one, so I left the rest as it is.

My point is that is it usually better to package version bumps rather
than arbitrary commits. IOW, I'd rather drop the revision and package
057c39313341907b35c68d2179226886a0c276fd instead.

> +      (description
> +       "adwaita-dark-theme is an Adwaita-inspired dark color scheme for
> +Emacs.")

You didn't change this. Is it intentional?

Regards,
-- 
Nicolas Goaziou






  reply	other threads:[~2023-11-16 11:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-15 21:43 [bug#67211] [PATCH] gnu: Add emacs-adwaita-dark-theme Tristan Cottam via Guix-patches via
2023-11-16 11:58 ` Nicolas Goaziou via Guix-patches via [this message]
2023-11-16 15:38   ` Tristan Cottam via Guix-patches via
2023-11-16 19:57     ` Nicolas Goaziou via Guix-patches via
2023-11-16 20:35       ` bug#67211: " Tristan Cottam via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cyw9yko6.fsf@nicolasgoaziou.fr \
    --to=guix-patches@gnu.org \
    --cc=67211@debbugs.gnu.org \
    --cc=andrew@trop.in \
    --cc=cox.katherine.e+guix@gmail.com \
    --cc=liliana.prikler@gmail.com \
    --cc=mail@nicolasgoaziou.fr \
    --cc=tristan@cott.am \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).