From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id QG9cJqJErmUuAAAAe85BDQ:P1 (envelope-from ) for ; Mon, 22 Jan 2024 11:34:10 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id QG9cJqJErmUuAAAAe85BDQ (envelope-from ) for ; Mon, 22 Jan 2024 11:34:10 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lassieur.org header.s=fm2 header.b=ofNOjHxQ; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm3 header.b="W rLnXwQ"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1705919650; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=NtUqHLZwdW2bJYVSA+rF61HL5JBMWkmwTqTw6GOaOg4=; b=oUN46oaKqRQ9kDd2L9RIwFW4dMr8QOhOHgDDUPdmGqvnFxKVlzHAaeGt0J/SU/2mbgFX8i L70+oJCYciCvSBUiANsR/6sQFKSJGt/1MH/iRn5BgiLurBMAzNGu1B2WbKHUh2N6WMZlEK +GvgEsXZYpujWUxEMrbWsYzVH7TK+bTcAJN5OmIT9tnbw2UR/70jAi6hjn6vh1dGnKIE28 wvY0zTsiWb2Kc/PTQBS7pgUGgQD94I3TH7ZqnlVrxFfdLvC6Fb8peld3uln8gkaQ7Lpmuf edqKVSfZUjq9m+Q8W0aitA8gYiMpHJett7ujaHTJkMQGH8rd7WVDxfWAL2ThTw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lassieur.org header.s=fm2 header.b=ofNOjHxQ; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm3 header.b="W rLnXwQ"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1705919650; a=rsa-sha256; cv=none; b=i2tiAQSWTojvU0HRq+aFcfgBzZOjvb2fYFCC7yMYht8R1htSGRNVicml800/1KISDSplGy XZA3nhotS56kYGrYaNsilTOVV2IkA+3jwfkE6eIf0FnHT4/XhJe/da3ib44DgYxXHwchCN HfN/jCa/IDU8b8FlUZsAmYzQNES0e9LIY/1mCsj097vE3NzCT5UAMKvgp4jkw3MKFby6wh eRnahHO2ujbYjlTmVwzHFZSc3NWgSmb18R6JCwMZZWlvI8n22PPgwZQQk2ntIo6pnLYVJu rD+VnKUU5w3dUJjTeRktHPncpPE4cZub4l/t/Z3f0I25VKKfKr59ATGttKroCA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 59C73245ED for ; Mon, 22 Jan 2024 11:34:09 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rRrcx-0004QC-7T; Mon, 22 Jan 2024 05:34:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rRrct-0004NR-3m for guix-patches@gnu.org; Mon, 22 Jan 2024 05:33:59 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rRrcs-0004Z7-Qe for guix-patches@gnu.org; Mon, 22 Jan 2024 05:33:58 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rRrcw-0000sQ-Oi for guix-patches@gnu.org; Mon, 22 Jan 2024 05:34:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#68577] [PATCH 2/2] gnu: Add mullvad-browser. Resent-From: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 22 Jan 2024 10:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68577 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mark H Weaver Cc: =?UTF-8?Q?Andr=C3=A9?= Batista , 68577@debbugs.gnu.org, Jonathan Brielmaier , Ian Eure Received: via spool by 68577-submit@debbugs.gnu.org id=B68577.17059196323344 (code B ref 68577); Mon, 22 Jan 2024 10:34:02 +0000 Received: (at 68577) by debbugs.gnu.org; 22 Jan 2024 10:33:52 +0000 Received: from localhost ([127.0.0.1]:39951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rRrcl-0000rs-Qt for submit@debbugs.gnu.org; Mon, 22 Jan 2024 05:33:52 -0500 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:39605) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rRrcj-0000rU-FO for 68577@debbugs.gnu.org; Mon, 22 Jan 2024 05:33:51 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id F16B73200A57; Mon, 22 Jan 2024 05:33:38 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Mon, 22 Jan 2024 05:33:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lassieur.org; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1705919618; x=1706006018; bh=NtUqHLZwdW2bJYVSA+rF61HL5JBMWkmwTqTw6GOaOg4=; b= ofNOjHxQfRVEGfkssODk3DPh/jaLJY6bgpwEbW6eaS0CIJb6xGvGRNprTmlv2Jz2 b+AeKGdccQSakFodN80lojcGXXtv2bJFHCSrQZ+MRnkI/K/SmtIVCqPMo+wtzLNO sN62yfqIf6Qad9e2O8wNbyCza6uLw9RYq98wDcy/KSUxRJHZBqYA8xNbjANmbHh6 uVnC1pJDM35A9AHlhL6jCuXd+dnZbA/G/7yfqdPxo4Y+dyXPqMDlE/oDmi7JSecT D/lvWqeWFPbW53nOLIHc+jJMaPRxiiB3DMFiAINk0K6Efs7kSDMEVB04K77S28YH MUYJeKlx1MSuxwNu9+4M2g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1705919618; x= 1706006018; bh=NtUqHLZwdW2bJYVSA+rF61HL5JBMWkmwTqTw6GOaOg4=; b=W rLnXwQ+2XrGVbWBg+NC/8gNBQ/gA5cno1HhRMPP82QX11c2/bSYMxO/KaIBC0jfz tv2DY7mpGVHcJyGJTknaTzvbbPbamI91e2cZcZfAc8VlWHHbXtiyFLSjdYaafBLt l//6mQAPOS5R5SOBxmkhvcRIE2IweFhpKS2yLzPgceL2v9h7Ktz5pm5pWLKSURqI 21+Ewg22tyZQLfcIVZ7YNMBNhoZg8/zx7JguSXmNR7HADygvvSED9cAQwF6Tz0Rd erUX3UwP9vfMHql5J4U5229J/8Lw84pfO9ji8EVMzLx4X8EWqMHS5dzUoE5e+5/p 2mkmhAB3BaYId4qXoDLSw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdekiedgudeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkfgggtgfgsehtqhertddtreejnecuhfhrohhmpeevlhor mhgvnhhtucfnrghsshhivghurhcuoegtlhgvmhgvnhhtsehlrghsshhivghurhdrohhrgh eqnecuggftrfgrthhtvghrnhepjeeggeduuefhvdfhtddvfeffvdelvdetkeduueduffei gefgheffgfeigfeuuddvnecuffhomhgrihhnpehtohhrphhrohhjvggtthdrohhrghenuc evlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegtlhgvmhgv nhhtsehlrghsshhivghurhdrohhrgh X-ME-Proxy: Feedback-ID: i4c21472a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 22 Jan 2024 05:33:36 -0500 (EST) From: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur In-Reply-To: <87y1chnc4i.fsf@netris.org> (Mark H. Weaver's message of "Mon, 22 Jan 2024 00:57:22 -0500") References: <174f8492bd3c72fa1bd186ee29e66eb837684768.1705619435.git.clement@lassieur.org> <87y1chnc4i.fsf@netris.org> Date: Mon, 22 Jan 2024 11:33:34 +0100 Message-ID: <87cytt64jl.fsf@lassieur.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -2.77 X-Spam-Score: -2.77 X-Migadu-Queue-Id: 59C73245ED X-Migadu-Scanner: mx12.migadu.com X-TUID: /dh5b/KYxYYx On Mon, Jan 22 2024, Mark H Weaver wrote: > Hi Cl=C3=A9ment, > > Cl=C3=A9ment Lassieur writes: > >> +(define-public mullvadbrowser-assets >> + ;; This is a prebuilt Mullvad Browser from which we take the assets w= e need. >> + (package >> + (name "mullvadbrowser-assets") >> + (version %mullvadbrowser-version) >> + (source >> + (origin >> + (method url-fetch) >> + (uri >> + (string-append >> + "https://archive.torproject.org/tor-package-archive/mullvadbro= wser/" >> + version "/mullvad-browser-linux-x86_64-" version ".tar.xz")) >> + (sha256 >> + (base32 >> + "1i7vf7cn6s5iajsp4999jpxxn8qblljrrmfs4nswmc2swdmi07gk")))) >> + (arguments >> + (list >> + #:install-plan >> + ''(("Browser" "." #:include-regexp >> + ("^\\./fonts/" >> + "^\\./fontconfig/fonts.conf" >> + ;; Mullvad Browser Extension >> + "^\\./distribution/extensions/\\{d19a89b9-76c1-4a61-bcd4-49e= 8de916403\\}.xpi" >> + ))))) >> + (build-system copy-build-system) >> + (home-page "https://www.torproject.org") >> + (synopsis "Mullvad Browser assets") >> + (description "This package contains fonts and configuration files f= or >> +Mullvad Browser.") >> + (license license:silofl1.1))) > > Guix packages should, wherever feasible, avoid using components from > pre-built binary distributions. Each required font family should be > added as a separate Guix package following our conventions for font > packages. Not feasible in this case, because fonts are used for fingerprinting. We need to make sure they are identical to upstream fonts. We should do the same to Icecat by the way. > As for the configuration files: how about distributing them > separately, or as part of the Mullvad source distribution? What's the issue?