From: "Ludovic Courtès" <ludo@gnu.org>
To: Daniel Ziltener <dziltener@lyrion.ch>
Cc: 68564@debbugs.gnu.org
Subject: [bug#68564] [PATCH] build-system: fix the Chicken build system
Date: Mon, 05 Feb 2024 22:35:31 +0100 [thread overview]
Message-ID: <87cytabnmk.fsf@gnu.org> (raw)
In-Reply-To: <5f79ce0097f1092706b65abd99940d06@lyrion.ch> (Daniel Ziltener's message of "Thu, 18 Jan 2024 11:09:12 +0100")
Hi Daniel,
Daniel Ziltener <dziltener@lyrion.ch> skribis:
> ---
> guix/build-system/chicken.scm | 68 +++++++++++++++++++----------
> guix/build/chicken-build-system.scm | 17 +++-----
> 2 files changed, 50 insertions(+), 35 deletions(-)
This change contains several seemingly unrelated changes, some
cosmetic/stylistic and others that have a functional impact, but it’s
not clear to me what the fix is.
Could you clarify what problem you’re trying to fix?
It’s also important to separate unrelated changes to help reviewers and
to help our future selves should we need to bisect the Git history.
> (define %chicken-build-system-modules
> ;; Build-side modules imported and used by default.
> - `((guix build chicken-build-system)
> + `((zilti build chicken-build-system)
Leftover change?
> + (modules '((zilti build chicken-build-system)
Ditto.
> + #$(with-build-variables inputs outputs
> + #~(chicken-build #:name #$name
> + #:source #+source
It’s best if we can avoid ‘with-build-variables’: ‘%build-inputs’ and
‘%outputs’, which this form adds, are now considered deprecated.
> (define* (setup-chicken-environment #:key inputs outputs #:allow-other-keys)
> (setenv "CHICKEN_INSTALL_REPOSITORY"
> - (string-concatenate
> - ;; see TODO item about binary version above
> - (append (list (assoc-ref outputs "out") "/var/lib/chicken/11/")
> - (let ((oldenv (getenv "CHICKEN_INSTALL_REPOSITORY")))
> - (if oldenv
> - (list ":" oldenv)
> - '())))))
> + (string-append (assoc-ref outputs "out") "/var/lib/chicken/11/"))
> + (setenv "CHICKEN_INSTALL_PREFIX"
> + (string-append (assoc-ref outputs "out") "/bin/"))
> + (setenv "CHICKEN_REPOSITORY_PATH"
> + (string-append (getenv "CHICKEN_REPOSITORY_PATH")
> + ":" (getenv "CHICKEN_INSTALL_REPOSITORY")))
> (setenv "CHICKEN_EGG_CACHE" (getcwd))
> #t)
>
> @@ -104,10 +103,6 @@ (define* (check #:key egg-name tests? #:allow-other-keys)
> ;; there is no "-test-only" option, but we've already run install
> ;; so this just runs tests.
> ;; i think it's a fair assumption that phases won't be reordered.
> - (setenv "CHICKEN_REPOSITORY_PATH"
> - (string-append (getenv "CHICKEN_INSTALL_REPOSITORY")
> - ":"
> - (getenv "CHICKEN_REPOSITORY_PATH")))
Could you explain why this statement is moved from one phase to the
other?
Thanks,
Ludo’.
next prev parent reply other threads:[~2024-02-05 21:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 10:09 [bug#68564] [PATCH] build-system: fix the Chicken build system Daniel Ziltener via Guix-patches via
2024-02-05 21:35 ` Ludovic Courtès [this message]
2024-03-07 21:45 ` Daniel Ziltener via Guix-patches via
2024-03-07 21:45 ` Daniel Ziltener via Guix-patches via
2024-03-08 9:49 ` Daniel Ziltener via Guix-patches via
2024-03-26 13:18 ` Daniel Ziltener via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cytabnmk.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=68564@debbugs.gnu.org \
--cc=dziltener@lyrion.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).